Closed Bug 957833 Opened 6 years ago Closed 6 years ago

ship CSS Variables (that is, enable the preference)

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla31
Tracking Status
firefox31 + fixed
relnote-firefox --- 31+

People

(Reporter: heycam, Assigned: heycam)

References

Details

(Keywords: dev-doc-complete, feature, Whiteboard: [qa-])

Attachments

(1 file)

Blink is the only other implementation of Variables currently, and they don't do variable fallback yet.  I guess we should wait.

Also we maybe should wait until we implement the CSSVariableMap part of the spec, which we don't yet.
Blocks: 947242
Severity: normal → enhancement
Blocks: 950436
Bug 950501 will probably resolve through spec, nevertheless IMHO this is a prerequesite before enabling. What about Bug 950264, Bug 950381, Bug 952338?

Also: Adding Bug 773296 for good measure.

(In reply to Cameron McCormack (:heycam) (away 24–25 Feb) from comment #0)
> Also we maybe should wait until we implement the CSSVariableMap part of the
> spec, which we don't yet.

Is there a bug on file yet?
Depends on: 950501, 773296
The working group agreed to take the spec to CR:
http://lists.w3.org/Archives/Public/www-style/2014Jan/0604.html
although it hasn't happened yet.

We should try to get this shipped sooner rather than later.
Summary: unpref CSS Variables → ship CSS Variables (that is, enable the preference)
I agree.  I spoke to Tab about Blink removing their implementation for the time being, and whether that should influence our decision to ship, and he was fine with us shipping.  Bug 950436 should be fixed first, though.  Let's not implement the CSSVariableMap stuff; I've indicated on www-style that I don't think we need it, and the [MapClass] stuff is going to be changed in Web IDL anyway.
Attached patch patchSplinter Review
Intent to ship email: https://groups.google.com/forum/#!topic/mozilla.dev.platform/wlc4FhqZBXA
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #8392760 - Flags: review?(dbaron)
Depends on: 985838
Comment on attachment 8392760 [details] [diff] [review]
patch

r=dbaron

Can you track making sure Tab makes the spec edit for what goes insde var() functions, so that that doesn't get dropped?
Attachment #8392760 - Flags: review?(dbaron) → review+
The spec has already been changed to use <custom-property-name> in the syntax for var().
https://hg.mozilla.org/mozilla-central/rev/a95e1a0fb26b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Florin, please make sure this gets assigned to the appropriate person for testing before release.
QA Contact: florin.mezei
Whiteboard: [qa+]
Adding appropriate flag nominations so this can be tracked by QA and RelMan.
relnote-firefox: --- → ?
Keywords: feature
I assume we will also want to relnote this?
Flags: needinfo?(lsblakk)
(In reply to Benjamin Kerensa [:bkerensa] from comment #11)
> I assume we will also want to relnote this?

The flag is already set to relnote-firefox?
yup, relnote flag is up - thanks
Flags: needinfo?(lsblakk)
I see all bugs that this depends on are already covered automatically. Is there anything needed from the Manual side?
Flags: needinfo?(cam)
Added in the release note for 31.
Don't think any manual testing is required, thanks Florin.
Flags: needinfo?(cam)
Whiteboard: [qa+] → [qa-]
You need to log in before you can comment on or make changes to this bug.