957833 - ship CSS Variables (that is, enable the preference)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Cameron McCormack (:heycam)]

Blink is the only other implementation of Variables currently, and they don't do variable fallback yet.  I guess we should wait.

Also we maybe should wait until we implement the CSSVariableMap part of the spec, which we don't yet.

Comment 1

[Florian Bender]

Bug 950501 will probably resolve through spec, nevertheless IMHO this is a prerequesite before enabling. What about Bug 950264, Bug 950381, Bug 952338?

Also: Adding Bug 773296 for good measure.

(In reply to Cameron McCormack (:heycam) (away 24–25 Feb) from comment #0)
> Also we maybe should wait until we implement the CSSVariableMap part of the
> spec, which we don't yet.

Is there a bug on file yet?

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The working group agreed to take the spec to CR:
http://lists.w3.org/Archives/Public/www-style/2014Jan/0604.html
although it hasn't happened yet.

We should try to get this shipped sooner rather than later.

Comment 3

[Cameron McCormack (:heycam)]

I agree.  I spoke to Tab about Blink removing their implementation for the time being, and whether that should influence our decision to ship, and he was fine with us shipping.  Bug 950436 should be fixed first, though.  Let's not implement the CSSVariableMap stuff; I've indicated on www-style that I don't think we need it, and the [MapClass] stuff is going to be changed in Web IDL anyway.

Comment 4

[Cameron McCormack (:heycam)]

Attachment: patch

Intent to ship email: https://groups.google.com/forum/#!topic/mozilla.dev.platform/wlc4FhqZBXA

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8392760 [details] [diff] [review]
patch

r=dbaron

Can you track making sure Tab makes the spec edit for what goes insde var() functions, so that that doesn't get dropped?

Comment 6

[Cameron McCormack (:heycam)]

The spec has already been changed to use <custom-property-name> in the syntax for var().

Comment 7

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a95e1a0fb26b

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a95e1a0fb26b

Comment 9

[u279076]

Florin, please make sure this gets assigned to the appropriate person for testing before release.

Comment 10

[u279076]

Adding appropriate flag nominations so this can be tracked by QA and RelMan.

Comment 11

[Benjamin Kerensa [:bkerensa]]

I assume we will also want to relnote this?

Comment 12

[Matthew N. [:MattN]]

(In reply to Benjamin Kerensa [:bkerensa] from comment #11)
> I assume we will also want to relnote this?

The flag is already set to relnote-firefox?

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

yup, relnote flag is up - thanks

Comment 14

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

I see all bugs that this depends on are already covered automatically. Is there anything needed from the Manual side?

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Added in the release note for 31.

Comment 16

[Cameron McCormack (:heycam)]

Don't think any manual testing is required, thanks Florin.