Closed
Bug 1312353
Opened 8 years ago
Closed 4 years ago
Hook Chatzilla into LOCALE_MERGEDIR process
Categories
(SeaMonkey :: Build Config, defect)
SeaMonkey
Build Config
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1604663
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
1.60 KB,
patch
|
ewong
:
review+
frg
:
feedback+
|
Details | Diff | Splinter Review |
1.74 KB,
patch
|
ewong
:
review+
frg
:
feedback+
|
Details | Diff | Splinter Review |
At the moment if locales miss out entities in Chatzilla then it can cause extra work to get repacks to work. If CZ was hooked into the LOCALE_MERGEDIR process then it would help.
This puts a caller into SM's merge-% and adds merge-% to the INSTALLERS_TARGETS
Attachment #8803795 -
Flags: review?(ewong)
Attachment #8803795 -
Flags: feedback?(frgrahl)
Switches to using in-tree compare-locales (could use the one used in SM's locale Makefile instead)
Puts hook in for merge-%
Uses LOCALE_MERGEDIR for target libs
Attachment #8803796 -
Flags: review?(ewong)
Attachment #8803796 -
Flags: feedback?(frgrahl)
![]() |
||
Comment 4•8 years ago
|
||
Comment on attachment 8803796 [details] [diff] [review]
Add hooks to CZ's locales Makefile
Still have not set up merge so take it with a grain of salt but looks ok to me. Building localized chatzilla with makexpi.py still works (not using makefile.in).
Attachment #8803796 -
Flags: feedback?(frgrahl) → feedback+
![]() |
||
Comment 5•8 years ago
|
||
Comment on attachment 8803795 [details] [diff] [review]
Add callers to SM's locale Makefile
ok too.
Attachment #8803795 -
Flags: feedback?(frgrahl) → feedback+
Comment 6•8 years ago
|
||
This bug is in fact a dupe of bug 485871. Interestingly, both Ian and I did write very similar patches independently, though I like mine better, because it does not make merge mandatory to be able to build :)
![]() |
||
Updated•8 years ago
|
Attachment #8803795 -
Flags: review?(ewong) → review+
Comment 7•8 years ago
|
||
Heads up, I'm changing how compare-locales works quite drastically right now, and how it integrates into the build.
bug 1370506 is the start of that, and bug 1372254 tracks other work related to compare-locales 2.0.
I expect the fix for this bug to look different once that work lands.
![]() |
||
Updated•8 years ago
|
Blocks: 2.53BulkMalfunctions
![]() |
||
Comment 9•7 years ago
|
||
Comment on attachment 8803796 [details] [diff] [review]
Add hooks to CZ's locales Makefile
Review of attachment 8803796 [details] [diff] [review]:
-----------------------------------------------------------------
seems logical.. though I suspect we'll need to change how we repack stuff later..
Attachment #8803796 -
Flags: review?(ewong) → review+
![]() |
||
Updated•7 years ago
|
Blocks: 2.55BulkMalfunctions
![]() |
||
Comment 10•7 years ago
|
||
Comment on attachment 8803796 [details] [diff] [review]
Add hooks to CZ's locales Makefile
Unsure if it could just be checked in. Wouldn't this need to be reviewed by a cZ maintainer?
Flags: needinfo?(iann_bugzilla)
![]() |
||
Updated•7 years ago
|
Blocks: 2.56BulkMalfunctions
![]() |
||
Updated•7 years ago
|
Blocks: 2.57BulkMalfunctions
Assignee | ||
Comment 12•4 years ago
|
||
The code that does this had changed and bug 1604663 covers what now needs to be done.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Flags: needinfo?(iann_bugzilla)
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•