1312417 - Remove test_orientation_sandbox_no_lock.html and friends

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Hi William, in bug 1310297 , we are removing B2G related annotations to test manifests from mozilla-central.

test_orientation_sandbox_no_lock.html won't be executed after this. Should it be switched to a different platform or get removed?

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This also applies to the other test_orientation-* tests.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

And test_window_orientation.html.

Comment 3

[André Bargull [:anba]]

The support file dom/base/test/orientationcommon.js [1] doesn't even contain valid JavaScript code.

[1] https://dxr.mozilla.org/mozilla-central/rev/88030580b14bb253a55bc174c987a9fa43c3fb55/dom/base/test/orientationcommon.js#4

Comment 4

[Andrew Overholt [:overholt]]

Do we need this coverage on Android?

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Pretty sure this has never worked on Android, so it's probably fine to remove it.

Comment 6

[Mark Banner (:standard8)]

Taking as the invalid js in orientationcommon.js is getting in the way of investigating enabling ESLint on dom/base.

Comment 7

[Mark Banner (:standard8)]

Attachment: Bug 1312417 - Remove test_orientation_sandbox_no_lock.html and friends as they aren't used and have invalid js.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a7632140ea5
Remove test_orientation_sandbox_no_lock.html and friends as they aren't used and have invalid js. r=baku

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3a7632140ea5