Closed Bug 1312417 Opened 3 years ago Closed Last year

Remove test_orientation_sandbox_no_lock.html and friends

Categories

(Core :: DOM: Core & HTML, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: aryx, Assigned: standard8)

Details

Attachments

(1 file)

Hi William, in bug 1310297 , we are removing B2G related annotations to test manifests from mozilla-central.

test_orientation_sandbox_no_lock.html won't be executed after this. Should it be switched to a different platform or get removed?
Flags: needinfo?(wchen)
This also applies to the other test_orientation-* tests.
Summary: Investigate whether test_orientation_sandbox_no_lock.html can be removed → Investigate whether test_orientation_sandbox_no_lock.html and friends can be removed
And test_window_orientation.html.
The support file dom/base/test/orientationcommon.js [1] doesn't even contain valid JavaScript code.

[1] https://dxr.mozilla.org/mozilla-central/rev/88030580b14bb253a55bc174c987a9fa43c3fb55/dom/base/test/orientationcommon.js#4
Do we need this coverage on Android?
Flags: needinfo?(william) → needinfo?(snorp)
Priority: -- → P3
Pretty sure this has never worked on Android, so it's probably fine to remove it.
Flags: needinfo?(snorp)
Summary: Investigate whether test_orientation_sandbox_no_lock.html and friends can be removed → Remove test_orientation_sandbox_no_lock.html and friends
Taking as the invalid js in orientationcommon.js is getting in the way of investigating enabling ESLint on dom/base.
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a7632140ea5
Remove test_orientation_sandbox_no_lock.html and friends as they aren't used and have invalid js. r=baku
https://hg.mozilla.org/mozilla-central/rev/3a7632140ea5
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.