Closed Bug 1310297 Opened 8 years ago Closed 8 years ago

Remove test annotations using b2g, mulet or gonk

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: aryx, Assigned: aryx)

References

(Blocks 1 open bug)

Details

Attachments

(71 files, 9 obsolete files)

58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
58 bytes, text/x-review-board-request
RyanVM
: review+
Details
B2G related code gets removed from mozilla-central, see bug 1306391.
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=93fa979b61a0f80ee2dbded31f6566a8a3a4222e&selectedJob=29177611 Only touched the test manifests. Removals of tests and e.g. interfaces implemented for them belong into other bugs, especially if it has to be evaluated if code should be kept because its use in standard interfaces can be foreseen for the upcoming months.
Comment on attachment 8801230 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: browser. https://reviewboard.mozilla.org/r/85944/#review84632
Attachment #8801230 - Flags: review?(ryanvm) → review+
Comment on attachment 8801231 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: caps. https://reviewboard.mozilla.org/r/85946/#review84634
Attachment #8801231 - Flags: review?(ryanvm) → review+
Comment on attachment 8801232 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: chrome. https://reviewboard.mozilla.org/r/85948/#review84636
Attachment #8801232 - Flags: review?(ryanvm) → review+
Comment on attachment 8801233 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: devtools. https://reviewboard.mozilla.org/r/85950/#review84638 ::: devtools/client/performance/test/unit/xpcshell.ini:13 (Diff revision 1) > [test_frame-utils-01.js] > [test_frame-utils-02.js] > [test_marker-blueprint.js] > [test_marker-utils.js] > [test_profiler-categories.js] > [test_jit-graph-data.js] Can you please remove the trailing whitespace from this line while you're here? ::: devtools/server/tests/unit/xpcshell.ini:137 (Diff revision 1) > [test_conditional_breakpoint-01.js] > [test_conditional_breakpoint-02.js] > [test_conditional_breakpoint-03.js] > [test_eventlooplag_actor.js] > -skip-if = toolkit != "gonk" > +skip-if = true > +reason = only ran on B2G Please ping Paul Rouget about whether this test can be removed or not. Looks like bug 962511 where this landed was only ever intended for B2G to begin with. It also may be that there's other code that can go besides just the test at this point. Certainly fine for a follow-up, though. ::: devtools/shared/security/tests/unit/xpcshell.ini:13 (Diff revision 1) > -# Failures on B2G emulator debug, B2G emulator-x86-kk > -# See bug 1234972 and bug 1199472 > -skip-if = toolkit == 'gonk' && (debug || android_version > '15') > [test_oob_cert_auth.js] > -# Failures on B2G emulator debug, B2G emulator-x86-kk and Android opt > -# See bug 1141544, bug 1163052, bug 1166032 and bug 1241831 > +# Failures on Android opt, see bug 1141544 > +skip-if = (toolkit == 'android' && !debug) Do you mind seeing if this still fails on Android opt or not? Maybe we can just re-enable it across the board and close out bug 1141544. I've also ni? myself in that bug to check otherwise, but if you beat me to it, great :)
Attachment #8801233 - Flags: review?(ryanvm) → review+
Comment on attachment 8801234 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: docshell. https://reviewboard.mozilla.org/r/85952/#review84646 ::: docshell/test/chrome/chrome.ini:71 (Diff revision 1) > [test_bug449778.xul] > [test_bug449780.xul] > [test_bug453650.xul] > [test_bug454235.xul] > # bug 684176 > skip-if = toolkit == "gtk2" Another possible cleanup bug we could file: getting rid of GTK2 annotations now that we're on GTK3 across the board AFAIK. ::: docshell/test/iframesandbox/mochitest.ini:24 (Diff revision 1) > [test_sibling_navigation_by_location.html] > tags = openwindow > [test_top_navigation_by_location_exotic.html] > -skip-if = (buildapp == 'b2g' && toolkit != 'gonk') || android_version == '18' #bug 948948, NS_ERROR_FAILURE from nsWindowWatcher::GetPrompt > +skip-if = android_version == '18' > [test_top_navigation_by_location.html] > -skip-if = (buildapp == 'b2g' && toolkit != 'gonk') || android_version == '18' #bug 948948, NS_ERROR_FAILURE from nsWindowWatcher::GetPrompt > +skip-if = android_version == '18' Please leave the bug number here as I'm pretty sure it's applicable to Android as well (window.open doesn't work there either). ::: docshell/test/mochitest.ini:62 (Diff revision 1) > support-files = bug530396-noref.sjs bug530396-subframe.html > [test_bug540462.html] > -skip-if = (buildapp == 'b2g' && toolkit != 'gonk') #Bug 931116, b2g desktop specific, initial triage > [test_bug551225.html] > [test_bug570341.html] > -skip-if = (toolkit == 'gonk' && debug) || (android_version == '18' && debug) #debug-only failure, android bug 1040769 > +skip-if = (android_version == '18' && debug) #debug-only failure, bug 1040769 Might be worth seeing if this still fails since Android 4.3 tests migrated to Taskcluster. ::: docshell/test/mochitest.ini:66 (Diff revision 1) > -skip-if = (toolkit == 'gonk' && debug) || (android_version == '18' && debug) #debug-only failure, android bug 1040769 > +skip-if = (android_version == '18' && debug) #debug-only failure, bug 1040769 > [test_bug580069.html] > [test_bug590573.html] > -skip-if = buildapp == 'b2g' #bug 823022 # b2g(queryinterfaces into webnavigation, might suffer from something similar as bug 823022) b2g-debug(queryinterfaces into webnavigation, might suffer from something similar as bug 823022) b2g-desktop(queryinterfaces into webnavigation, might suffer from something similar as bug 823022) > [test_bug598895.html] > -skip-if = (buildapp == 'b2g' && toolkit != 'gonk') || toolkit == 'android' #Bug 931116, b2g desktop specific, initial triage > +skip-if = toolkit == 'android' Older-than time test disabling, might be worth seeing if it still fails or not on Android. ::: docshell/test/mochitest.ini:69 (Diff revision 1) > -skip-if = buildapp == 'b2g' #bug 823022 # b2g(queryinterfaces into webnavigation, might suffer from something similar as bug 823022) b2g-debug(queryinterfaces into webnavigation, might suffer from something similar as bug 823022) b2g-desktop(queryinterfaces into webnavigation, might suffer from something similar as bug 823022) > [test_bug598895.html] > -skip-if = (buildapp == 'b2g' && toolkit != 'gonk') || toolkit == 'android' #Bug 931116, b2g desktop specific, initial triage > +skip-if = toolkit == 'android' > [test_bug634834.html] > [test_bug637644.html] > -skip-if = (buildapp == 'b2g' && toolkit != 'gonk') || toolkit == 'android' #Bug 931116, b2g desktop specific, initial triage > +skip-if = toolkit == 'android' Same as previous comment. ::: docshell/test/mochitest.ini:76 (Diff revision 1) > [test_bug653741.html] > [test_bug660404.html] > -skip-if = (buildapp == 'b2g' && toolkit != 'gonk') #Bug 931116, b2g desktop specific, initial triage > [test_bug662170.html] > [test_bug668513.html] > -skip-if = (buildapp == 'b2g' && toolkit != 'gonk') || toolkit == 'android' #Bug 931116, b2g desktop specific, initial triage > +skip-if = toolkit == 'android' And again. ::: docshell/test/mochitest.ini:90 (Diff revision 1) > -skip-if = (buildapp == 'b2g' && toolkit != 'gonk') #Bug 931116, b2g desktop specific, initial triage > [test_bug797909.html] > [test_bug1045096.html] > [test_bug1186774.html] > [test_framedhistoryframes.html] > -skip-if = (buildapp == 'b2g' && toolkit != 'gonk') || toolkit == 'android' #Bug 931116, b2g desktop specific, initial triage, and also bug 784321 > +skip-if = toolkit == 'android' # bug 784321 And again (test disabling going back to 2012, ouch). ::: docshell/test/mochitest.ini:95 (Diff revision 1) > [test_pushState_after_document_open.html] > [test_windowedhistoryframes.html] > -skip-if = (buildapp == 'b2g' && toolkit != 'gonk') #Bug 931116, b2g desktop specific, initial triage > [test_bug1121701.html] > -skip-if = (buildapp == 'b2g' || buildapp == 'mulet') > [test_forceinheritprincipal_overrule_owner.html] While you're here, can you please alphabetize these last few tests hanging off the end of the list? ::: docshell/test/navigation/mochitest.ini:41 (Diff revision 1) > file_bug1300461_redirect.html > file_bug1300461_redirect.html^headers^ > file_bug1300461_back.html > > [test_bug13871.html] > -skip-if = buildapp == 'b2g' || buildapp == 'mulet' || toolkit == 'android' #RANDOM # Bug 1136180 disabled on B2G Desktop and Mulet for intermittent failures > +skip-if = toolkit == 'android' #RANDOM Some of these poorly-annotated Android skips might be worth checking on Try too.
Attachment #8801234 - Flags: review?(ryanvm) → review+
Comment on attachment 8801235 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/animation. https://reviewboard.mozilla.org/r/85954/#review84652
Attachment #8801235 - Flags: review?(ryanvm) → review+
Comment on attachment 8801236 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/apps. https://reviewboard.mozilla.org/r/85956/#review84654 ::: dom/apps/tests/chrome.ini:2 (Diff revision 1) > [DEFAULT] > -skip-if = buildapp != 'mulet' > +skip-if = true ### Bug 1255339: blacklist because no more mozApps I'm wondering if these should just be removed at this point. Probably worth pinging gerard-majax about it.
Comment on attachment 8801237 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/archivereader. https://reviewboard.mozilla.org/r/85958/#review84656
Attachment #8801237 - Flags: review?(ryanvm) → review+
Comment on attachment 8801238 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/base. https://reviewboard.mozilla.org/r/85960/#review84660 ::: dom/base/test/chrome.ini:28 (Diff revision 1) > -skip-if = buildapp == 'mulet' > [test_bug945152.html] > [test_bug1008126.html] > [test_sandboxed_blob_uri.html] > [test_websocket_frame.html] > [test_mozbrowser_apis_allowed.html] Please alphabetize these while you're here. ::: dom/base/test/mochitest.ini:279 (Diff revision 1) > [test_bug51034.html] > [test_bug116083.html] > subsuite = clipboard > [test_bug166235.html] > subsuite = clipboard > -skip-if = buildapp == 'b2g' || toolkit == 'android' # b2g(clipboard undefined) b2g-debug(clipboard undefined) b2g-desktop(clipboard undefined) > +skip-if = toolkit == 'android' More craptasically-commented Android disablings worth checking on :( ::: dom/base/test/mochitest.ini:305 (Diff revision 1) > [test_bug333673.html] > [test_bug337631.html] > [test_bug338541.xhtml] > [test_bug338583.html] > -# b2g(https not working, bug 907770) b2g-debug(https not working, bug 907770) b2g-desktop(43 total - bug 901343, specialpowers.wrap issue createsystemxhr) > # e10s - bug 970589, bug 1091934 This line isn't needed anymore, is it? ::: dom/base/test/mochitest.ini:417 (Diff revision 1) > [test_bug459424.html] > [test_bug461555.html] > [test_bug461735.html] > [test_bug465767.html] > [test_bug466080.html] > -skip-if = buildapp == 'b2g' || toolkit == 'android' # b2g(bug 901356, also fails on android) b2g-debug(bug 901356, also fails on android) b2g-desktop(bug 901356, also fails on android) > +skip-if = toolkit == 'android' # bug 901356 Another one for the "I wonder if this even fails on Android anymore" list. Especially on a WONTFIXed bug. ::: dom/base/test/mochitest.ini:618 (Diff revision 1) > [test_clearTimeoutIntervalNoArg.html] > [test_constructor-assignment.html] > [test_constructor.html] > [test_copyimage.html] > subsuite = clipboard > -skip-if = (buildapp == 'b2g' && toolkit != 'gonk') || (toolkit != 'cocoa' && toolkit != 'gonk' && toolkit != 'gtk2' && toolkit != 'gtk3' && toolkit != 'windows') #b2g-desktop(Bug 931116, b2g desktop specific, initial triage) > +skip-if = (toolkit != 'cocoa' && toolkit != 'gonk' && toolkit != 'gtk2' && toolkit != 'gtk3' && toolkit != 'windows') Couldn't this just be more clearly written as just skip-if = toolkit == 'android' at this point? Plus there's still a gonk reference in that line otherwise. ::: dom/base/test/mochitest.ini:732 (Diff revision 1) > [test_orientation_frame.html] > -skip-if = toolkit != 'gonk' > +skip-if = true # Test only ran on Gonk > [test_orientation_frame_lock.html] > -skip-if = toolkit != 'gonk' > +skip-if = true # Test only ran on Gonk > [test_orientation_sandbox_no_lock.html] > -skip-if = toolkit != 'gonk' > +skip-if = true # Test only ran on Gonk Please file a follow-up bug and ni? wchen to see whether these are needed anymore or not. You can also change the comment to point to that bug instead then. ::: dom/base/test/mochitest.ini:794 (Diff revision 1) > [test_websocket3.html] > -skip-if = buildapp == 'b2g' || toolkit == 'android' # TC: Bug 1144079 - Re-enable Mulet mochitests and reftests taskcluster-specific disables. > +skip-if = toolkit == 'android' > [test_websocket4.html] > -skip-if = buildapp == 'b2g' || toolkit == 'android' # TC: Bug 1144079 - Re-enable Mulet mochitests and reftests taskcluster-specific disables. > +skip-if = toolkit == 'android' > [test_websocket5.html] > -skip-if = buildapp == 'b2g' || toolkit == 'android' # TC: Bug 1144079 - Re-enable Mulet mochitests and reftests taskcluster-specific disables. > +skip-if = toolkit == 'android' Would love to know if these work on Android at this point. ::: dom/base/test/mochitest.ini:806 (Diff revision 1) > [test_window_enumeration.html] > [test_window_extensible.html] > [test_window_indexing.html] > [test_window_named_frame_enumeration.html] > [test_window_orientation.html] > -skip-if = toolkit != 'gonk' > +skip-if = true # Test only ran on Gonk Same as test_orientation* ::: dom/base/test/websocket_hybi/mochitest.ini:13 (Diff revision 1) > [test_receive-blob.html] > -skip-if = buildapp == 'b2g' || toolkit == 'android' > +skip-if = toolkit == 'android' > [test_send-arraybuffer.html] > -skip-if = buildapp == 'b2g' || toolkit == 'android' > +skip-if = toolkit == 'android' > [test_send-blob.html] > -skip-if = buildapp == 'b2g' || toolkit == 'android' > +skip-if = toolkit == 'android' More older-than-time disablings on Android :(
Attachment #8801238 - Flags: review?(ryanvm) → review+
Comment on attachment 8801239 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/bindings. https://reviewboard.mozilla.org/r/85962/#review84666
Attachment #8801239 - Flags: review?(ryanvm) → review+
Comment on attachment 8801240 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/broadcastchannel. https://reviewboard.mozilla.org/r/85964/#review84668
Attachment #8801240 - Flags: review?(ryanvm) → review+
Comment on attachment 8801241 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/browser-element. https://reviewboard.mozilla.org/r/85966/#review84670
Attachment #8801241 - Flags: review?(ryanvm) → review+
Comment on attachment 8801236 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/apps. https://reviewboard.mozilla.org/r/85956/#review84672
Attachment #8801236 - Flags: review?(ryanvm) → review+
Comment on attachment 8801242 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/cache. https://reviewboard.mozilla.org/r/85968/#review84678 ::: dom/browser-element/mochitest/mochitest-oop.ini:6 (Diff revision 1) > [DEFAULT] > # Both the "inproc" and "oop" versions of OpenMixedProcess open remote frames, > # so we don't run that test on platforms which don't support OOP tests. > # OOP tests don't work on native-fennec (bug 774939). > # Bug 960345 - Disabled on OSX debug for frequent crashes. > -skip-if = os == "android" || (toolkit == "cocoa" && debug) || buildapp == 'mulet' || (buildapp == 'b2g' && (toolkit != 'gonk' || debug)) || e10s > +skip-if = os == "android" || (toolkit == "cocoa" && debug) || e10s I messed up over in bug 960345. I'm going to check soon if these can be re-enabled on OSX debug and will do so if they succeed on Try. ::: dom/browser-element/mochitest/mochitest-oop.ini:89 (Diff revision 1) > [test_browserElement_oop_ReloadPostRequest.html] > disabled = Disabling some OOP tests for WebIDL scope changes > [test_browserElement_oop_RemoveBrowserElement.html] > [test_browserElement_oop_ScrollEvent.html] > [test_browserElement_oop_SecurityChange.html] > -skip-if = toolkit == 'android' || (toolkit == 'gonk' && !debug) #TIMED_OUT, bug 766586 > +skip-if = toolkit == 'android' #TIMED_OUT, bug 766586 Goodness, another one disabled over bug 766586. ::: dom/browser-element/mochitest/mochitest.ini:122 (Diff revision 1) > [test_browserElement_inproc_CopyPaste.html] > subsuite = clipboard > skip-if = (os == "android") # Disabled on Android, see bug 1230421 > [test_browserElement_inproc_DataURI.html] > [test_browserElement_inproc_Download.html] > disabled = bug 1022281 Another one I'd be curious about whether it passes or not at this point. ::: dom/browser-element/mochitest/mochitest.ini:143 (Diff revision 1) > [test_browserElement_inproc_Opensearch.html] > [test_browserElement_inproc_PrivateBrowsing.html] > [test_browserElement_inproc_PromptCheck.html] > [test_browserElement_inproc_PromptConfirm.html] > # Disabled on B2G Emulator because permission cannot be asserted in content process, > # need to fix either bug 1094055 or bug 1020135. Useless comment can go. ::: dom/browser-element/mochitest/mochitest.ini:148 (Diff revision 1) > [test_browserElement_inproc_Proxy.html] > -skip-if = toolkit == 'gonk' || buildapp == 'mulet' > [test_browserElement_inproc_RemoveBrowserElement.html] > [test_browserElement_inproc_ScrollEvent.html] > [test_browserElement_inproc_SecurityChange.html] > -skip-if = toolkit == 'android' || (toolkit == 'gonk' && !debug) # android(TIMED_OUT, bug 766586) androidx86(TIMED_OUT, bug 766586) > +skip-if = toolkit == 'android' # android(TIMED_OUT, bug 766586) androidx86(TIMED_OUT, bug 766586) Wonder if this still fails on Android or not. Either way, please clean up the comment as it's redundantly-written as it stands currently. ::: dom/browser-element/mochitest/mochitest.ini:161 (Diff revision 1) > [test_browserElement_inproc_XFrameOptionsSameOrigin.html] > [test_browserElement_oop_NextPaint.html] > # Disabled due to https://bugzilla.mozilla.org/show_bug.cgi?id=774100 > disabled = temp disabling some OOP tests for WebIDL scope changes > [test_browserElement_inproc_Reload.html] > disabled = bug 774100 The last comments in the referenced bug suggest we could try re-enabling these too. And if they're otherwise broken, we should probably file a new bug or re-open that one (depending on the failure method).
Attachment #8801242 - Flags: review?(ryanvm) → review+
Comment on attachment 8801243 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/canvas. https://reviewboard.mozilla.org/r/85970/#review84694 ::: dom/cache/test/mochitest/mochitest.ini (Diff revision 1) > [test_cache_put.html] > [test_cache_requestCache.html] > [test_cache_delete.html] > [test_cache_put_reorder.html] > [test_cache_https.html] > - skip-if = buildapp == 'b2g' # bug 1162353 Can the referenced bug be closed now? Not sure if there are other annotations for it in the tree too.
Attachment #8801243 - Flags: review?(ryanvm) → review+
Comment on attachment 8801244 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/console. https://reviewboard.mozilla.org/r/85972/#review84696 r- for the accidentally-disabled tests. ::: dom/canvas/test/mochitest.ini:215 (Diff revision 1) > [test_bug1215072.html] > subsuite = gpu > [test_canvas.html] > -skip-if = (toolkit == 'gonk' && debug) || (android_version == '18' && debug) #debug-only crash; bug 933541 #android 4.3 debug bug 1143317 > +skip-if = (android_version == '18' && debug) #android 4.3 debug bug 1143317 > [test_canvas_focusring.html] > -skip-if = (toolkit == 'gonk' && !debug) || os == 'win' #specialpowers.wrap > +skip-if = os == 'win' #specialpowers.wrap I'm pretty sure the comment here applied to the B2G skip. Can you please double-check that? ::: dom/canvas/test/reftest/reftest.list:140 (Diff revision 1) > -fuzzy(5,30000) skip-if(!(Android||B2G)) skip-if(Android) pref(webgl.prefer-16bpp,true) == webgl-color-test.html?16bpp&________&premult&_____ wrapper.html?colors-no-alpha.png > -fuzzy(5,30000) skip-if(!(Android||B2G)) skip-if(Android) pref(webgl.prefer-16bpp,true) pref(webgl.force-layers-readback,true) == webgl-color-test.html?16bpp&readback&premult&_____ wrapper.html?colors-no-alpha.png > -fuzzy(9,40000) skip-if(!(Android||B2G)) skip-if(Android) pref(webgl.prefer-16bpp,true) == webgl-color-test.html?16bpp&________&_______&alpha wrapper.html?colors-non-premult.png > -fuzzy(9,40000) skip-if(!(Android||B2G)) skip-if(Android) pref(webgl.prefer-16bpp,true) pref(webgl.force-layers-readback,true) == webgl-color-test.html?16bpp&readback&_______&alpha wrapper.html?colors-non-premult.png > -fuzzy(9,40000) skip-if(!(Android||B2G)) skip-if(Android) pref(webgl.prefer-16bpp,true) == webgl-color-test.html?16bpp&________&premult&alpha wrapper.html?colors-premult.png > -fuzzy(9,40000) skip-if(!(Android||B2G)) skip-if(Android) pref(webgl.prefer-16bpp,true) pref(webgl.force-layers-readback,true) == webgl-color-test.html?16bpp&readback&premult&alpha wrapper.html?colors-premult.png > +# fuzzy(5,30000) pref(webgl.prefer-16bpp,true) == webgl-color-test.html?16bpp&________&premult&_____ wrapper.html?colors-no-alpha.png > +# fuzzy(5,30000) pref(webgl.prefer-16bpp,true) pref(webgl.force-layers-readback,true) == webgl-color-test.html?16bpp&readback&premult&_____ wrapper.html?colors-no-alpha.png > +# fuzzy(9,40000) pref(webgl.prefer-16bpp,true) == webgl-color-test.html?16bpp&________&_______&alpha wrapper.html?colors-non-premult.png > +# fuzzy(9,40000) pref(webgl.prefer-16bpp,true) pref(webgl.force-layers-readback,true) == webgl-color-test.html?16bpp&readback&_______&alpha wrapper.html?colors-non-premult.png > +# fuzzy(9,40000) pref(webgl.prefer-16bpp,true) == webgl-color-test.html?16bpp&________&premult&alpha wrapper.html?colors-premult.png > +# fuzzy(9,40000) pref(webgl.prefer-16bpp,true) pref(webgl.force-layers-readback,true) == webgl-color-test.html?16bpp&readback&premult&alpha wrapper.html?colors-premult.png Did you mean to comment out these test entries? ::: dom/canvas/test/reftest/reftest.list:160 (Diff revision 1) > # Bug 815648 > == stroketext-shadow.html stroketext-shadow-ref.html > > # focus rings > -pref(canvas.focusring.enabled,true) skip-if(B2G) skip-if(cocoaWidget) skip-if(winWidget) needs-focus == drawFocusIfNeeded.html drawFocusIfNeeded-ref.html > -pref(canvas.customfocusring.enabled,true) skip-if(B2G) skip-if(cocoaWidget) skip-if(Android) skip-if(winWidget) fuzzy-if(gtkWidget,64,410) needs-focus == drawCustomFocusRing.html drawCustomFocusRing-ref.html > +pref(canvas.focusring.enabled,true) skip-if(cocoaWidget) skip-if(winWidget) needs-focus == drawFocusIfNeeded.html drawFocusIfNeeded-ref.html > +pref(canvas.customfocusring.enabled,true) skip-if(cocoaWidget) skip-if(Android) skip-if(winWidget) fuzzy-if(gtkWidget,64,410) needs-focus == drawCustomFocusRing.html drawCustomFocusRing-ref.html While you're here, can you please consolidate the skip-ifs? There's no reason to leave them separate like that. ::: dom/canvas/test/webgl-mochitest/mochitest.ini:3 (Diff revision 1) > [DEFAULT] > subsuite = webgl > -skip-if = ((os == 'linux') && (buildapp == 'b2g')) > +skip-if = (os == 'linux') You're disabling these tests on Linux when they weren't previously. The original condition as given was for Linux B2G Desktop builds.
Attachment #8801244 - Flags: review?(ryanvm) → review-
Comment on attachment 8801245 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/crypto. https://reviewboard.mozilla.org/r/85974/#review84698
Attachment #8801245 - Flags: review?(ryanvm) → review+
Comment on attachment 8801246 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/devicestorage. https://reviewboard.mozilla.org/r/85976/#review84700 ::: dom/contacts/tests/chrome.ini:18 (Diff revision 1) > file_contacts_substringmatchingVE.html > file_contacts_substringmatchingCL.html > test_migration_chrome.js > file_migration.html > > # renaming with "_a_" to execure before others, since we hardcode open of Remove the trailing whitespace while you're here please.
Attachment #8801246 - Flags: review?(ryanvm) → review+
Comment on attachment 8801247 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/encoding. https://reviewboard.mozilla.org/r/85978/#review84702
Attachment #8801247 - Flags: review?(ryanvm) → review+
Comment on attachment 8801248 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/events. https://reviewboard.mozilla.org/r/85980/#review84704 ::: dom/devicestorage/test/mochitest.ini:28 (Diff revision 1) > [test_sanity.html] > [test_usedSpace.html] > [test_watch.html] > [test_watchOther.html] > [test_storageAreaListener.html] > -skip-if = (toolkit != 'gonk') > +skip-if = true # Test only ran on Gonk Check with Dave Hylands if we need this test anymore. Also, please fix up the alphabetization while you're here.
Attachment #8801248 - Flags: review?(ryanvm) → review+
Comment on attachment 8801249 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/html. https://reviewboard.mozilla.org/r/85982/#review84706 This looks OK to me as it is, but I'd rather just remove these tests at this point if they're not useful outside of B2G. Maybe Fabrice can rubberstamp the total removal of this directory?
Attachment #8801249 - Flags: review?(ryanvm) → review+
Comment on attachment 8801250 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/imptests. https://reviewboard.mozilla.org/r/85984/#review84708 ::: dom/encoding/test/mochitest.ini:27 (Diff revision 1) > [test_TextEncoder.html] > [test_stringencoding.html] > -skip-if = buildapp == 'b2g' # b2g(Test timed out on b2g board) b2g-debug(Test timed out on b2g board) b2g-desktop(Test timed out on b2g board) > [test_submit_euckr.html] > [test_TLD.html] > [test_utf16_files.html] Clean up the alphabetizing while you're here. ::: dom/encoding/test/unit/xpcshell.ini:13 (Diff revision 1) > [test_big5.js] > [test_euc-jp.js] > [test_euc-kr.js] > [test_gbk.js] > [test_iso-2022-jp.js] > [test_shift_jis.js] Alphebetization and extra newline. The harness runs them alphabetically anyway.
Attachment #8801250 - Flags: review?(ryanvm) → review+
Comment on attachment 8801251 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/indexedDB. https://reviewboard.mozilla.org/r/85986/#review84710 ::: dom/events/test/mochitest.ini:42 (Diff revision 1) > -# Sometimes fails to finish after tests pass on 'B2G ICS Emulator'. > -skip-if = (os == 'b2g') > [test_bug422132.html] > -skip-if = buildapp == 'b2g' # b2g(2 failures out of 8, mousewheel test) b2g-debug(2 failures out of 8, mousewheel test) b2g-desktop(2 failures out of 8, mousewheel test) > [test_bug426082.html] > -skip-if = buildapp == 'mulet' || buildapp == 'b2g' || os == "win" || toolkit == 'android' # b2g(1 failure out of 6, Moving the mouse down from the label should have unpressed the button) b2g-debug(1 failure out of 6, Moving the mouse down from the label should have unpressed the button) b2g-desktop(1 failure out of 6, Moving the mouse down from the label should have unpressed the button) > +skip-if = os == "win" || toolkit == 'android' Looks like the Windows annotation goes back to bug 921693. Not sure about Android. Would be interesting to see if the test passes these days, though. Especially given that it was recently revamped for e10s. ::: dom/events/test/mochitest.ini:44 (Diff revision 1) > [test_bug422132.html] > -skip-if = buildapp == 'b2g' # b2g(2 failures out of 8, mousewheel test) b2g-debug(2 failures out of 8, mousewheel test) b2g-desktop(2 failures out of 8, mousewheel test) > [test_bug426082.html] > -skip-if = buildapp == 'mulet' || buildapp == 'b2g' || os == "win" || toolkit == 'android' # b2g(1 failure out of 6, Moving the mouse down from the label should have unpressed the button) b2g-debug(1 failure out of 6, Moving the mouse down from the label should have unpressed the button) b2g-desktop(1 failure out of 6, Moving the mouse down from the label should have unpressed the button) > +skip-if = os == "win" || toolkit == 'android' > [test_bug427537.html] > [test_bug1003432.html] WHY? Of all the random places to put a test... ::: dom/events/test/mochitest.ini:61 (Diff revision 1) > -skip-if = buildapp == 'mulet' || (buildapp == 'b2g' && toolkit != 'gonk') #Bug 931116, b2g desktop specific, initial triage > [test_bug502818.html] > skip-if = toolkit == 'android' #CRASH_DUMP, RANDOM > [test_bug508479.html] > -skip-if = buildapp == 'mulet' || buildapp == 'b2g' || toolkit == 'android' #CRASH_DUMP, RANDOM # b2g(drag event, also fails on Android) b2g-debug(drag event, also fails on Android) b2g-desktop(drag event, also fails on Android) > +skip-if = toolkit == 'android' #CRASH_DUMP, RANDOM # drag event fails > [test_bug822898.html] *sigh* ::: dom/events/test/pointerevents/mochitest.ini:2 (Diff revision 1) > [DEFAULT] > -skip-if = (toolkit == 'gonk') || (os == 'android') # Bug 1178701 - Issue on 'B2G ICS Emulator' and 'Android' > +skip-if = os == 'android' # Bug 1178701 Ugh, pointing to a closed bug. We should see if these still fail on Android and file a proper bug for fixing and re-enabling them if they don't. Especially since there are people in Taipei actively working on pointer events now.
Attachment #8801251 - Flags: review?(ryanvm) → review+
Comment on attachment 8801252 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/inputmethod. https://reviewboard.mozilla.org/r/85988/#review84714 ::: dom/html/test/chrome.ini:11 (Diff revision 1) > [test_anchor_ping.html] > -skip-if = buildapp == 'b2g' || os == 'android' > +skip-if = os == 'android' > [test_audio_wakelock.html] > -skip-if = buildapp == 'mulet' # TC: Bug 1144079 - Re-enable Mulet mochitests and reftests taskcluster-specific disables. > [test_video_wakelock.html] > -skip-if = toolkit == 'android' || (toolkit == 'gonk' && debug) #bug 871015, bug 881443 > +skip-if = toolkit == 'android' #bug 871015 Wonder if we still need this annotation.
Attachment #8801252 - Flags: review?(ryanvm) → review+
Comment on attachment 8801253 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/ipc. https://reviewboard.mozilla.org/r/85990/#review84750 ::: dom/imptests/html/mochitest.ini:16 (Diff revision 1) > subsuite = gpu > -skip-if = (toolkit == 'android') || (buildapp == 'b2g') #android(WebGL) > +skip-if = toolkit == 'android' #android(WebGL) > [webgl/test_compressedTexSubImage2D.html] > subsuite = gpu > skip-if = true # Bug 1226336 > -#skip-if = (toolkit == 'android') || (buildapp == 'b2g') #android(WebGL) > +#skip-if = toolkit == 'android' #android(WebGL) This is pretty silly. Let's just remove the commented-out line.
Attachment #8801253 - Flags: review?(ryanvm) → review+
Comment on attachment 8801254 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/json. https://reviewboard.mozilla.org/r/85992/#review84752 r- due to the accidentally disabled test. ::: dom/indexedDB/test/mochitest.ini:206 (Diff revision 1) > [test_invalid_version.html] > -skip-if = (buildapp == 'b2g' && toolkit != 'gonk') # Bug 931116 > [test_invalidate.html] > # disabled for the moment > skip-if = true > -# skip-if = (buildapp == 'b2g' && toolkit != 'gonk') # Bug 931116 > +# [test_key_requirements.html] This looks wrong.
Attachment #8801254 - Flags: review?(ryanvm) → review-
Comment on attachment 8801255 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/jsurl. https://reviewboard.mozilla.org/r/85994/#review84754 Looks fine, but this is another one I'd like to see about removing outright if possible. Check with Fabrice.
Attachment #8801255 - Flags: review?(ryanvm) → review+
Comment on attachment 8801256 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/media. https://reviewboard.mozilla.org/r/85996/#review84756 Looks fine, but doesn't appear to have any value outside of B2G. Check with James Cheng if we can remove this outright.
Attachment #8801256 - Flags: review?(ryanvm) → review+
Comment on attachment 8801257 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/network. https://reviewboard.mozilla.org/r/85998/#review84758
Attachment #8801257 - Flags: review?(ryanvm) → review+
Comment on attachment 8801258 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/notification. https://reviewboard.mozilla.org/r/86000/#review84760 Please alphabetize the tests while you're here.
Attachment #8801258 - Flags: review?(ryanvm) → review+
Comment on attachment 8801259 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/permission. https://reviewboard.mozilla.org/r/86002/#review84762
Attachment #8801259 - Flags: review?(ryanvm) → review+
Comment on attachment 8801260 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/plugins. https://reviewboard.mozilla.org/r/86004/#review84764 ::: dom/media/mediasource/test/mochitest.ini:62 (Diff revision 1) > [test_DurationChange.html] > [test_DurationUpdated.html] > [test_DurationUpdated_mp4.html] > skip-if = ((os == "win" && os_version == "5.1") || (toolkit == 'android')) # Not supported on xp and android 2.3 > [test_EndOfStream.html] > -skip-if = (true || toolkit == 'android' || buildapp == 'mulet') #timeout android/mulet only bug 1101187 and bug 1182946 > +skip-if = (true || toolkit == 'android') #timeout android only bug 1101187 and bug 1182946 This is...interesting. ::: dom/media/mediasource/test/mochitest.ini:64 (Diff revision 1) > [test_DurationUpdated_mp4.html] > skip-if = ((os == "win" && os_version == "5.1") || (toolkit == 'android')) # Not supported on xp and android 2.3 > [test_EndOfStream.html] > -skip-if = (true || toolkit == 'android' || buildapp == 'mulet') #timeout android/mulet only bug 1101187 and bug 1182946 > +skip-if = (true || toolkit == 'android') #timeout android only bug 1101187 and bug 1182946 > [test_EndOfStream_mp4.html] > -skip-if = ((os == "win" && os_version == "5.1") || (toolkit == 'android' || buildapp == 'mulet')) # Not supported on xp and android 2.3 > +skip-if = ((os == "win" && os_version == "5.1") || (toolkit == 'android')) # Not supported on xp and android 2.3 I wonder how many of these tests would pass on Android if indeed it's an issue with 2.3 specifically. ::: dom/media/test/crashtests/crashtests.list:81 (Diff revision 1) > load 1045650.html > load 1080986.html > load 1122218.html > load 1127188.html > load 1157994.html > -skip-if(!B2G) load 1158427.html > +skip-if(true) load 1158427.html # Test only ran on B2G I think this test can be removed. Paul Adenot can probably say for sure. ::: dom/media/test/crashtests/crashtests.list:99 (Diff revision 1) > load offline-buffer-source-ended-1.html > load oscillator-ended-1.html > load oscillator-ended-2.html > load video-replay-after-audio-end.html > # This needs to run at the end to avoid leaking busted state into other tests. > -skip-if(B2G) load 691096-1.html # bug 852821 > +load 691096-1.html # bug 852821 Comment can be removed. ::: dom/media/test/mochitest.ini:26 (Diff revision 1) > # test first check canPlayType for the type, and if it's not supported, just > # do ok(true, "Type not supported") and stop the test. > > [DEFAULT] > subsuite = media > -skip-if = buildapp == 'mulet' || android_version == '18' > +skip-if = android_version == '18' I believe this is because we're running them on real devices now via autophone, but can we please add a comment to that effect while we're here? ::: dom/media/test/mochitest.ini:642 (Diff revision 1) > [test_bug448534.html] > -skip-if = buildapp == 'mulet' > [test_bug463162.xhtml] > [test_bug465498.html] > [test_bug495145.html] > skip-if = (os == 'mac' && os_version == '10.6') # bug 1021174 Definitely want a follow-up bug for getting rid of 10.6 annotations too. ::: dom/media/test/mochitest.ini:781 (Diff revision 1) > tags=msg > [test_mediarecorder_webm_support.html] > skip-if = os == 'android' || arch == 'arm' || arch == 'arm64' > tags=msg > [test_mediarecorder_mp4_support.html] > -skip-if = toolkit != 'gonk' || android_version < '17' # Android/Gonk before SDK version 17 does not have the OMX Encoder API. > +skip-if = true # Test only ran on Gonk Check with Randell Jesup if we need this test at all anymore.
Attachment #8801260 - Flags: review?(ryanvm) → review+
Comment on attachment 8801261 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/power. https://reviewboard.mozilla.org/r/86006/#review84766 Check with Fabrice if these are needed at all anymore.
Attachment #8801261 - Flags: review?(ryanvm) → review+
Comment on attachment 8801262 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/presentation. https://reviewboard.mozilla.org/r/86008/#review84768 Check with Fabrice if these can go.
Attachment #8801262 - Flags: review?(ryanvm) → review+
Comment on attachment 8801263 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/promise. https://reviewboard.mozilla.org/r/86010/#review84770 ::: dom/network/tests/mochitest.ini:18 (Diff revision 1) > [test_networkstats_disabled.html] > -skip-if = toolkit != "gonk" > +skip-if = true # Test only ran on Gonk > [test_networkstats_enabled_no_perm.html] > -skip-if = toolkit != "gonk" > +skip-if = true # Test only ran on Gonk > [test_networkstats_enabled_perm.html] > -skip-if = toolkit != "gonk" > +skip-if = true # Test only ran on Gonk Check with Fabrice if the networkstats tests can be removed outright.
Attachment #8801263 - Flags: review?(ryanvm) → review+
Comment on attachment 8801264 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/push. https://reviewboard.mozilla.org/r/86012/#review84772
Attachment #8801264 - Flags: review?(ryanvm) → review+
Comment on attachment 8801265 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/security. https://reviewboard.mozilla.org/r/86014/#review84774
Attachment #8801265 - Flags: review?(ryanvm) → review+
Comment on attachment 8801266 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/svg. https://reviewboard.mozilla.org/r/86016/#review84776
Attachment #8801266 - Flags: review?(ryanvm) → review+
Comment on attachment 8801267 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/system. https://reviewboard.mozilla.org/r/86018/#review84778 ::: dom/plugins/test/reftest/reftest.list:10 (Diff revision 1) > fails-if(!haveTestPlugin) fuzzy-if(skiaContent&&haveTestPlugin,1,164000) == plugin-alpha-opacity.html div-alpha-opacity.html > random-if(/^Windows\x20NT\x206\.1/.test(http.oscpu)) fails-if(!haveTestPlugin) == windowless-clipping-1.html windowless-clipping-1-ref.html # bug 631832 > # fuzzy because of anti-aliasing in dashed border > fuzzy(16,256) random-if(/^Windows\x20NT\x206\.1/.test(http.oscpu)) fails-if(!haveTestPlugin) == border-padding-1.html border-padding-1-ref.html # bug 629430 > fuzzy(16,256) random-if(/^Windows\x20NT\x206\.1/.test(http.oscpu)) fails-if(!haveTestPlugin) == border-padding-2.html border-padding-2-ref.html # bug 629430 > -fuzzy(16,256) random-if(/^Windows\x20NT\x206\.1/.test(http.oscpu)) skip-if(!haveTestPlugin) skip-if(Android||B2G) == border-padding-3.html border-padding-3-ref.html # bug 629430 # bug 773482 > +fuzzy(16,256) random-if(/^Windows\x20NT\x206\.1/.test(http.oscpu)) skip-if(!haveTestPlugin) skip-if(Android) == border-padding-3.html border-padding-3-ref.html # bug 629430 # bug 773482 Please consolidate the skip-ifs into one condition.
Attachment #8801267 - Flags: review?(ryanvm) → review+
Comment on attachment 8801268 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/tests. https://reviewboard.mozilla.org/r/86020/#review84780 ::: dom/power/test/chrome.ini:9 (Diff revision 1) > [test_power_set_screen_brightness.html] > -skip-if = toolkit != "gonk" > +skip-if = true # Test only ran on Gonk > [test_power_set_screen_enabled.html] > -skip-if = toolkit != "gonk" > +skip-if = true # Test only ran on Gonk > [test_power_set_key_light_enabled.html] > -skip-if = toolkit != "gonk" > +skip-if = true # Test only ran on Gonk Check with Fabrice if these can be removed outright.
Attachment #8801268 - Flags: review?(ryanvm) → review+
Comment on attachment 8801269 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/url. https://reviewboard.mozilla.org/r/86022/#review84784
Attachment #8801269 - Flags: review?(ryanvm) → review+
Comment on attachment 8801270 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/workers. https://reviewboard.mozilla.org/r/86024/#review84786
Attachment #8801270 - Flags: review?(ryanvm) → review+
Comment on attachment 8801271 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/xbl. https://reviewboard.mozilla.org/r/86026/#review84788
Attachment #8801271 - Flags: review?(ryanvm) → review+
Comment on attachment 8801272 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/xhr. https://reviewboard.mozilla.org/r/86028/#review84790 Looks like another directory ripe for removal. Check with Fabrice.
Attachment #8801272 - Flags: review?(ryanvm) → review+
Comment on attachment 8801273 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/xml. https://reviewboard.mozilla.org/r/86030/#review84792
Attachment #8801273 - Flags: review?(ryanvm) → review+
Comment on attachment 8801274 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/xul. https://reviewboard.mozilla.org/r/86032/#review84794 More to check with Fabrice about. Please fix up the ordering too.
Attachment #8801274 - Flags: review?(ryanvm) → review+
Comment on attachment 8801275 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: editor. https://reviewboard.mozilla.org/r/86034/#review84796
Attachment #8801275 - Flags: review?(ryanvm) → review+
Comment on attachment 8801276 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: embedding. https://reviewboard.mozilla.org/r/86036/#review84798 ::: dom/system/tests/mochitest.ini:8 (Diff revision 1) > preload-SystemUpdateManager-jsm.js > file_bug1197901.html > > [test_system_update_enabled.html] > -skip-if = buildapp != 'b2g' > +skip-if = true # Tests only ran on B2G > [test_bug1197901.html] Please alphabetize.
Attachment #8801276 - Flags: review?(ryanvm) → review+
Comment on attachment 8801277 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: extensions. https://reviewboard.mozilla.org/r/86038/#review84800 ::: dom/tests/browser/browser.ini:16 (Diff revision 1) > !/dom/tests/mochitest/geolocation/network_geolocation.sjs > > [browser_test_toolbars_visibility.js] > support-files = > test_new_window_from_content_child.html > [browser_bug1008941_dismissGeolocationHanger.js] Please alphabetize. ::: dom/tests/mochitest/ajax/offline/mochitest.ini:90 (Diff revision 1) > [test_obsolete.html] > -skip-if = buildapp == 'b2g' > [test_offlineIFrame.html] > -skip-if = buildapp == 'b2g' > # [test_offlineMode.html] > # disabled due to bug 656943 Can we please turn this into a proper skip? ::: dom/tests/mochitest/ajax/prototype/mochitest.ini:67 (Diff revision 1) > test/unit/tmp/selector_test.html > test/unit/tmp/string_test.html > test/unit/tmp/unit_test.html > > [test_Prototype.html] > -skip-if = (toolkit == 'gonk' && debug) || toolkit == 'android' #debug-only timeout > +skip-if = toolkit == 'android' #debug-only timeout Comment doesn't appear to match the skip-if condition. ::: dom/tests/mochitest/ajax/scriptaculous/mochitest.ini:34 (Diff revision 1) > test/unit/sortable_test.html > test/unit/string_test.html > test/unit/unit_test.html > > [test_Scriptaculous.html] > -skip-if = (toolkit == 'gonk' && debug) || toolkit == 'android' #debug-only failure > +skip-if = toolkit == 'android' #debug-only failure Same as previous. ::: dom/tests/mochitest/general/chrome.ini:8 (Diff revision 1) > [test_innerScreen.xul] > [test_offsets.css] > [test_offsets.js] > [test_offsets.xul] > -skip-if = buildapp == 'mulet' > [test_idleapi_permissions.html] Please alphabetize. ::: dom/tests/mochitest/general/mochitest.ini:125 (Diff revision 1) > [test_selectevents.html] > -skip-if = buildapp == 'b2g' || buildapp == 'mulet' || toolkit == 'android' # Mouse doesn't select in the same way > +skip-if = toolkit == 'android' # bug 1230232 - Mouse doesn't select in the same way > -# Disabled on Android, see bug 1230232 > [test_WebKitCSSMatrix.html] > [test_resource_timing_frameset.html] > [test_bug1208217.html] Please alphabetize.
Attachment #8801277 - Flags: review?(ryanvm) → review+
Comment on attachment 8801278 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: gfx. https://reviewboard.mozilla.org/r/86040/#review84802 ::: dom/url/tests/chrome.ini:12 (Diff revision 1) > jsm_url_worker.js > !/dom/workers/test/dom_worker_helper.js > > [test_url.xul] > [test_worker_url.xul] > [test_bug883784.xul] Alphabetize please :)
Attachment #8801278 - Flags: review?(ryanvm) → review+
Comment on attachment 8801279 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: image. https://reviewboard.mozilla.org/r/86042/#review84804
Attachment #8801279 - Flags: review?(ryanvm) → review+
Comment on attachment 8801280 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: intl. https://reviewboard.mozilla.org/r/86044/#review84806 ::: dom/xbl/test/mochitest.ini:42 (Diff revision 1) > [test_bug821850.html] > -skip-if = buildapp == 'mulet' > [test_bug844783.html] > [test_bug872273.xhtml] > [test_bug946815.html] > -skip-if = toolkit != "gonk" > +skip-if = true # Test only ran on Gonk. Check with bholley if this can be removed outright.
Attachment #8801280 - Flags: review?(ryanvm) → review+
Comment on attachment 8801281 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: ipc. https://reviewboard.mozilla.org/r/86046/#review84808 ::: dom/xhr/tests/mochitest.ini:101 (Diff revision 1) > -skip-if = buildapp == 'b2g' > [test_worker_xhr_responseURL.html] > [test_worker_xhr_system.html] > [test_worker_xhr_timeout.html] > skip-if = (os == "win") || (os == "mac") || toolkit == 'android' #bug 798220 > [test_relativeLoad.html] More painful test ordering :(
Attachment #8801281 - Flags: review?(ryanvm) → review+
Comment on attachment 8801282 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: js. https://reviewboard.mozilla.org/r/86048/#review84810
Attachment #8801282 - Flags: review?(ryanvm) → review+
Comment on attachment 8801283 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: layout/base. https://reviewboard.mozilla.org/r/86050/#review84812
Attachment #8801283 - Flags: review?(ryanvm) → review+
Comment on attachment 8801284 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: layout/forms. https://reviewboard.mozilla.org/r/86052/#review84814
Attachment #8801284 - Flags: review?(ryanvm) → review+
Comment on attachment 8801285 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: layout/generic. https://reviewboard.mozilla.org/r/86054/#review84816
Attachment #8801285 - Flags: review?(ryanvm) → review+
Comment on attachment 8801286 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: layout/inspector. https://reviewboard.mozilla.org/r/86056/#review84818
Attachment #8801286 - Flags: review?(ryanvm) → review+
Comment on attachment 8801287 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: layout/style. https://reviewboard.mozilla.org/r/86058/#review84820 ::: gfx/layers/apz/test/mochitest/mochitest.ini:42 (Diff revision 1) > - skip-if = (os == 'android') || (os == 'b2g') || (buildapp == 'mulet') # wheel events not supported on mobile; see bug 1164274 for mulet > + skip-if = (os == 'android') # wheel events not supported on mobile > [test_wheel_scroll.html] > - skip-if = (os == 'android') || (os == 'b2g') || (buildapp == 'mulet') # wheel events not supported on mobile; see bug 1164274 for mulet > + skip-if = (os == 'android') # wheel events not supported on mobile > [test_wheel_transactions.html] > - skip-if = (os == 'android') || (os == 'b2g') || (buildapp == 'mulet') # wheel events not supported on mobile; see bug 1164274 for mulet > + skip-if = (os == 'android') # wheel events not supported on mobile > [test_bug1151667.html] Please alphabetize.
Attachment #8801287 - Flags: review?(ryanvm) → review+
Comment on attachment 8801288 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: layout/xul. https://reviewboard.mozilla.org/r/86060/#review84822 ::: image/test/mochitest/mochitest.ini:92 (Diff revision 1) > # [test_bug435296.html] > # disabled - See bug 578591 > [test_bug466586.html] > [test_bug468160.html] > # [test_bug478398.html] > # disabled - See bug 579139 Please make this and the one above it proper skip-ifs while you're here. ::: image/test/mochitest/mochitest.ini:120 (Diff revision 1) > -skip-if = toolkit == "gonk" #Bug 997034 - canvas.toDataURL() often causes lost connection to device. > [test_error_events.html] > [test_short_gif_header.html] > [test_image_buffer_limit.html] > -#skip-if = toolkit != "gonk" #Image buffer limit is only set for Firefox OS currently. > +#skip-if = true #Image buffer limit was only set for Firefox OS. > disabled = bug 1060869 Please see what Timothy Nikkel thinks about whether we should keep this test or not. ::: image/test/mochitest/mochitest.ini:156 (Diff revision 1) > [test_undisplayed_iframe.html] > -skip-if = buildapp == 'b2g' || os == 'android' > +skip-if = os == 'android' > [test_xultree_animation.xhtml] > -skip-if = buildapp == 'b2g' || os == 'android' > +skip-if = os == 'android' > [test_bug1132427.html] > -skip-if = buildapp == 'b2g' || os == 'android' > +skip-if = os == 'android' Please alphabetize. ::: image/test/reftest/gif/reftest.list:48 (Diff revision 1) > # --BOUNDARYOMG\r\n > # Content-Type: image/gif\r\n > # \r\n > # <contents of blue.gif> (no newline) > # --BOUNDARYOMG--\r\n > # Please kill this trailing whitespace while you're here.
Attachment #8801288 - Flags: review?(ryanvm) → review+
Comment on attachment 8801289 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: modules. https://reviewboard.mozilla.org/r/86062/#review84824
Attachment #8801289 - Flags: review?(ryanvm) → review+
Comment on attachment 8801290 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: netwerk. https://reviewboard.mozilla.org/r/86064/#review84826
Attachment #8801290 - Flags: review?(ryanvm) → review+
Comment on attachment 8801291 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: parser. https://reviewboard.mozilla.org/r/86066/#review84828 ::: js/xpconnect/tests/chrome/chrome.ini:88 (Diff revision 1) > [test_bug1074863.html] > [test_bug1092477.xul] > [test_bug1124898.html] > [test_bug1126911.html] > [test_bug1281071.xul] > [test_xrayToJS.xul] Please alphabetize.
Attachment #8801291 - Flags: review?(ryanvm) → review+
Comment on attachment 8801292 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: rdf. https://reviewboard.mozilla.org/r/86068/#review84830 ::: layout/base/tests/mochitest.ini:85 (Diff revision 1) > [test_bug404209.xhtml] > [test_bug416896.html] > [test_bug423523.html] > [test_bug449781.html] > [test_bug450930.xhtml] > -skip-if = buildapp == 'b2g' || true # bug 934301 # b2g(times out) b2g-debug(times out) b2g-desktop(times out) > +skip-if = true # bug 934301 Might be worth seeing if this passes these days.
Attachment #8801292 - Flags: review?(ryanvm) → review+
Comment on attachment 8801293 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: security. https://reviewboard.mozilla.org/r/86070/#review84832 ::: layout/forms/test/mochitest.ini:63 (Diff revision 1) > [test_bug961363.html] > skip-if = toolkit == 'android' # Bug 1021644 - Fails when pushed into a different chunk on Android > [test_bug1111995.html] > -skip-if = buildapp == 'mulet' || buildapp == 'b2g' > [test_select_vertical.html] > -skip-if = e10s || buildapp == 'mulet' || buildapp == 'b2g' || toolkit == 'android' # Bug 1170129 - vertical <select> popup not implemented for e10s # <select> elements don't use an in-page popup on B2G/Android > +skip-if = e10s || toolkit == 'android' # Bug 1170129 - vertical <select> popup not implemented for e10s # <select> elements don't use an in-page popup on Android Please alphabetize.
Attachment #8801293 - Flags: review?(ryanvm) → review+
Comment on attachment 8801294 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: services. https://reviewboard.mozilla.org/r/86072/#review84834 ::: layout/generic/test/chrome.ini:16 (Diff revision 1) > [test_bug469613.xul] > [test_bug469774.xul] > [test_bug508115.xul] > [test_bug514732-2.xul] > [test_bug632379.xul] > -skip-if = buildapp == 'mulet' || os == 'linux' # Bug 1207914 for Linux > +skip-if = os == 'linux' # Bug 1207914 for Linux You can drop the "for Linux" part from this
Attachment #8801294 - Flags: review?(ryanvm) → review+
Comment on attachment 8801295 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: storage. https://reviewboard.mozilla.org/r/86074/#review84836
Attachment #8801295 - Flags: review?(ryanvm) → review+
Comment on attachment 8801296 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: toolkit. https://reviewboard.mozilla.org/r/86076/#review84838
Attachment #8801296 - Flags: review?(ryanvm) → review+
Comment on attachment 8801297 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: uriloader. https://reviewboard.mozilla.org/r/86078/#review84840 ::: layout/xul/test/mochitest.ini:11 (Diff revision 1) > skip-if = toolkit == 'android' #bug 798806 > [test_bug563416.html] > [test_resizer_incontent.xul] > [test_splitter.xul] > skip-if = toolkit == 'android' # no XUL theme > [test_bug1197913.xul] Please alphabetize.
Comment on attachment 8801297 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: uriloader. https://reviewboard.mozilla.org/r/86078/#review84842
Attachment #8801297 - Flags: review?(ryanvm) → review+
Comment on attachment 8801298 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: widget. https://reviewboard.mozilla.org/r/86080/#review84844
Attachment #8801298 - Flags: review?(ryanvm) → review+
Comment on attachment 8801299 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: xpcom. https://reviewboard.mozilla.org/r/86082/#review84846 ::: netwerk/test/mochitests/mochitest.ini:24 (Diff revision 1) > [test_user_agent_overrides.html] > [test_user_agent_updates.html] > [test_user_agent_updates_reset.html] > [test_viewsource_unlinkable.html] > [test_xhr_method_case.html] > [test_loadinfo_redirectchain.html] Please alphabetize.
Attachment #8801299 - Flags: review?(ryanvm) → review+
Comment on attachment 8801299 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: xpcom. https://reviewboard.mozilla.org/r/86082/#review84848 ::: netwerk/test/unit/xpcshell_b2g.ini:4 (Diff revision 1) > [DEFAULT] > head = head_channels.js head_cache.js head_cache2.js > tail = > -skip-if = buildapp != 'b2g' > +skip-if = true This can probably go. Check with Fabrice.
Comment on attachment 8801300 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: xpfe. https://reviewboard.mozilla.org/r/86084/#review84850
Attachment #8801300 - Flags: review?(ryanvm) → review+
Comment on attachment 8801301 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: xpcom. https://reviewboard.mozilla.org/r/86086/#review84852
Attachment #8801301 - Flags: review?(ryanvm) → review+
Comment on attachment 8801302 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: xpfe. https://reviewboard.mozilla.org/r/86088/#review84854
Attachment #8801302 - Flags: review?(ryanvm) → review+
Comment on attachment 8801303 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: xpfe. https://reviewboard.mozilla.org/r/86090/#review84856 ::: services/fxaccounts/tests/xpcshell/xpcshell.ini:16 (Diff revision 1) > [test_credentials.js] > [test_loginmgr_storage.js] > -skip-if = appname == 'b2g' # login manager storage only used on desktop. > [test_manager.js] > -skip-if = appname != 'b2g' > -reason = FxAccountsManager is only available for B2G for now > +skip-if = true > +reason = FxAccountsManager was only available for B2G Check with markh as to whether this test can be dropped or not.
Attachment #8801303 - Flags: review?(ryanvm) → review+
Comment on attachment 8801304 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: storage. https://reviewboard.mozilla.org/r/86092/#review84858
Attachment #8801304 - Flags: review?(ryanvm) → review+
Comment on attachment 8801305 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: toolkit. https://reviewboard.mozilla.org/r/86094/#review84860 ::: toolkit/components/osfile/tests/xpcshell/xpcshell.ini:17 (Diff revision 1) > [test_osfile_async_append.js] > [test_osfile_async_bytes.js] > [test_osfile_async_copy.js] > [test_osfile_async_flush.js] > [test_osfile_async_largefiles.js] > [test_osfile_async_setDates.js] Please alphabetize. I'm a bit nervous about removing the requesttimeoutfactor line as well (mostly for Android), but we'll see how it goes. ::: toolkit/identity/tests/unit/xpcshell.ini:4 (Diff revision 1) > [DEFAULT] > head = head_identity.js > tail = tail_identity.js > -skip-if = (appname != "b2g" || toolkit == 'gonk') > +skip-if = true # Tests ran only on non-Gonk B2G I think this can go now. Maybe markh would know for sure. ::: toolkit/mozapps/update/tests/unit_aus_update/xpcshell.ini:26 (Diff revision 1) > [downloadResumeForSameAppVersion.js] > [downloadCompleteAfterPartialFailure.js] > -skip-if = buildapp == "mulet" || toolkit == 'gonk' > -reason = custom nsIUpdatePrompt > [downloadFileTooBig_gonk.js] > -skip-if = toolkit != 'gonk' > +skip-if = true This can probably go. Check with Fabrice.
Attachment #8801305 - Flags: review?(ryanvm) → review+
Comment on attachment 8801306 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: uriloader. https://reviewboard.mozilla.org/r/86096/#review84862
Attachment #8801306 - Flags: review?(ryanvm) → review+
Comment on attachment 8801307 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: widget. https://reviewboard.mozilla.org/r/86098/#review84864
Attachment #8801307 - Flags: review?(ryanvm) → review+
Comment on attachment 8801308 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: xpcom. https://reviewboard.mozilla.org/r/86100/#review84866
Attachment #8801308 - Flags: review?(ryanvm) → review+
Comment on attachment 8801309 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: xpfe. https://reviewboard.mozilla.org/r/86102/#review84868
Attachment #8801309 - Flags: review?(ryanvm) → review+
Comment on attachment 8801244 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/console. https://reviewboard.mozilla.org/r/85972/#review84696 > I'm pretty sure the comment here applied to the B2G skip. Can you please double-check that? Yes, it was. Fixed. > Did you mean to comment out these test entries? Yes, the test don't run on any platform since https://hg.mozilla.org/mozilla-central/rev/bef797e6c129 landed.
Comment on attachment 8801244 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/console. https://reviewboard.mozilla.org/r/85972/#review84696 > Yes, the test don't run on any platform since https://hg.mozilla.org/mozilla-central/rev/bef797e6c129 landed. I feel like skip-if(true) better clarifies the intent here in that case.
Comment on attachment 8801299 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: xpcom. https://reviewboard.mozilla.org/r/86082/#review84848 > This can probably go. Check with Fabrice. This got removed in bug 1310721 / https://hg.mozilla.org/integration/mozilla-inbound/rev/df41cedc3884
Comment on attachment 8801260 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/plugins. https://reviewboard.mozilla.org/r/86004/#review84764 > This is...interesting. Needinfo jya https://bugzilla.mozilla.org/show_bug.cgi?id=1182946#c36 > Definitely want a follow-up bug for getting rid of 10.6 annotations too. Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1312519
Comment on attachment 8801256 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/media. https://reviewboard.mozilla.org/r/85996/#review84756 inputport is designed for TV product on B2G. It is no longer required. Please remove it, Thanks.
Comment on attachment 8801233 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: devtools. https://reviewboard.mozilla.org/r/85950/#review84638 > Do you mind seeing if this still fails on Android opt or not? Maybe we can just re-enable it across the board and close out bug 1141544. I've also ni? myself in that bug to check otherwise, but if you beat me to it, great :) This passed https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad4d80865d4662879dd72a6bb39b732fae75d3e4 , removed the annotation.
Comment on attachment 8801234 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: docshell. https://reviewboard.mozilla.org/r/85952/#review84646 > Another possible cleanup bug we could file: getting rid of GTK2 annotations now that we're on GTK3 across the board AFAIK. Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1312400 > Some of these poorly-annotated Android skips might be worth checking on Try too. Test run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=840db0870cd4928e868f8cf11a42aa5de8c3482f From the tests I enabled, only test_bug570341.html from docshell/test/mochitest.ini and test_bug13871.html and test_bug270414.html both from docshell/test/navigation/mochitest.ini didn't fail instantly.
Comment on attachment 8801238 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/base. https://reviewboard.mozilla.org/r/85960/#review84660 test_bug466080.html is the only enabled test which didn't fail immediately on Android. Test run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7df28a2d5182c64311cbb7851d2feefbfec2d4a1&selectedJob=29782110 > More craptasically-commented Android disablings worth checking on :( Still failing https://treeherder.mozilla.org/logviewer.html#?job_id=29782110&repo=try > Please file a follow-up bug and ni? wchen to see whether these are needed anymore or not. You can also change the comment to point to that bug instead then. Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1312417 > Would love to know if these work on Android at this point. Still fail: https://treeherder.mozilla.org/logviewer.html#?job_id=29790629&repo=try > More older-than-time disablings on Android :( And still failing: https://treeherder.mozilla.org/logviewer.html#?job_id=29790629&repo=try
Comment on attachment 8801251 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/indexedDB. https://reviewboard.mozilla.org/r/85986/#review84710 > Looks like the Windows annotation goes back to bug 921693. Not sure about Android. Would be interesting to see if the test passes these days, though. Especially given that it was recently revamped for e10s. Didn't fail on the try push https://treeherder.mozilla.org/#/jobs?repo=try&revision=91b37db0a6563f048587cb555a4d6e6d5d0fec5c , removed both annotations. > Ugh, pointing to a closed bug. We should see if these still fail on Android and file a proper bug for fixing and re-enabling them if they don't. Especially since there are people in Taipei actively working on pointer events now. Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1312791
Comment on attachment 8801292 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: rdf. https://reviewboard.mozilla.org/r/86068/#review84830 > Might be worth seeing if this passes these days. Didn't see it fail in https://treeherder.mozilla.org/#/jobs?repo=try&revision=91b37db0a6563f048587cb555a4d6e6d5d0fec5c , so enabled it.
Comment on attachment 8801256 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/media. https://reviewboard.mozilla.org/r/85996/#review84756 Created bug 1312800 for the removal and dropped this patch for this bug.
Comment on attachment 8801233 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: devtools. https://reviewboard.mozilla.org/r/85950/#review87420 ::: devtools/server/tests/unit/xpcshell.ini:137 (Diff revision 1) > [test_conditional_breakpoint-01.js] > [test_conditional_breakpoint-02.js] > [test_conditional_breakpoint-03.js] > [test_eventlooplag_actor.js] > -skip-if = toolkit != "gonk" > +skip-if = true > +reason = only ran on B2G Can be removed, filed bug 1312807 because also the frontend has to be dropped.
Comment on attachment 8801303 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: xpfe. https://reviewboard.mozilla.org/r/86090/#review84856 > Check with markh as to whether this test can be dropped or not. Removed and filed bug 1313062 for the FxAccountsManager removal.
Comment on attachment 8801305 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: toolkit. https://reviewboard.mozilla.org/r/86094/#review84860 > I think this can go now. Maybe markh would know for sure. Created bug 1313045 and dropped this.
Comment on attachment 8801234 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: docshell. https://reviewboard.mozilla.org/r/85952/#review84646
Comment on attachment 8801272 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/xhr. https://reviewboard.mozilla.org/r/86028/#review84790 Already removed in bug 1312591.
Comment on attachment 8801305 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: toolkit. https://reviewboard.mozilla.org/r/86094/#review84860 > This can probably go. Check with Fabrice. Removed.
Comment on attachment 8801274 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/xul. https://reviewboard.mozilla.org/r/86032/#review84794 Filed bug 1313155.
Comment on attachment 8801268 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/tests. https://reviewboard.mozilla.org/r/86020/#review84780 > Check with Fabrice if these can be removed outright. Removed them.
Comment on attachment 8801263 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/promise. https://reviewboard.mozilla.org/r/86010/#review84770 > Check with Fabrice if the networkstats tests can be removed outright. Removed them.
Comment on attachment 8801261 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/power. https://reviewboard.mozilla.org/r/86006/#review84766 Yes, can go, filed bug 1313159.
Comment on attachment 8801249 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/html. https://reviewboard.mozilla.org/r/85982/#review84706 Filed bug 1313167.
Comment on attachment 8801255 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/jsurl. https://reviewboard.mozilla.org/r/85994/#review84754 Filed bug 1313169.
Comment on attachment 8801238 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/base. https://reviewboard.mozilla.org/r/85960/#review84660 > Another one for the "I wonder if this even fails on Android anymore" list. Especially on a WONTFIXed bug. Didn't see it fail in the Try push, so enabled it.
Comment on attachment 8801242 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/cache. https://reviewboard.mozilla.org/r/85968/#review84678 > Another one I'd be curious about whether it passes or not at this point. Fails: https://treeherder.mozilla.org/logviewer.html#?job_id=29826727&repo=try > Wonder if this still fails on Android or not. Either way, please clean up the comment as it's redundantly-written as it stands currently. Hasn't failed in https://treeherder.mozilla.org/#/jobs?repo=try&revision=91b37db0a6563f048587cb555a4d6e6d5d0fec5c&selectedJob=29825601 > The last comments in the referenced bug suggest we could try re-enabling these too. And if they're otherwise broken, we should probably file a new bug or re-open that one (depending on the failure method). Times out: https://treeherder.mozilla.org/logviewer.html#?job_id=29828866&repo=try The Makefile.in linked in the bug is gone.
Comment on attachment 8801260 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/plugins. https://reviewboard.mozilla.org/r/86004/#review84764 > I wonder how many of these tests would pass on Android if indeed it's an issue with 2.3 specifically. There are intermittent failures at least for these tests: test_DrainOnMissingData_mp4.html test_FrameSelection_mp4.html test_SeekToEnd_mp4.html test_SeekTwice_mp4.html test_Threshold_mp4.html test_WaitingOnMissingDataEnded_mp4.html Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=91b37db0a6563f048587cb555a4d6e6d5d0fec5c > I think this test can be removed. Paul Adenot can probably say for sure. Enabled it globally on padenot's suggestion.
Comment on attachment 8801244 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/console. https://reviewboard.mozilla.org/r/85972/#review88712
Attachment #8801244 - Flags: review?(ryanvm) → review+
Comment on attachment 8801254 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/json. https://reviewboard.mozilla.org/r/85992/#review88714 ::: dom/inputmethod/mochitest/chrome.ini:3 (Diff revision 3) > [DEFAULT] > -# dom/inputmethod only makes sense on B2G > -run-if = (buildapp == 'b2g' && toolkit != 'gonk') || buildapp == 'mulet' > +# dom/inputmethod only made sense on B2G > +skip-if = true I'm wondering if these can go at this point.
Attachment #8801254 - Flags: review?(ryanvm) → review+
(In reply to Ryan VanderMeulen [:RyanVM] from comment #133) > ::: dom/xbl/test/mochitest.ini:42 > > [test_bug946815.html] > > -skip-if = toolkit != "gonk" > > +skip-if = true # Test only ran on Gonk. > > Check with bholley if this can be removed outright. Removed it (can't find the comment on review board, opening older revisions shows other patches because some patches got removed). (In reply to Ryan VanderMeulen [:RyanVM] from comment #113) > ::: dom/media/test/crashtests/crashtests.list:81 > > load 1157994.html > > -skip-if(!B2G) load 1158427.html > > +skip-if(true) load 1158427.html # Test only ran on B2G > > I think this test can be removed. Paul Adenot can probably say for sure. Enabled it globally. > > [test_mediarecorder_mp4_support.html] > > -skip-if = toolkit != 'gonk' || android_version < '17' # Android/Gonk before SDK version 17 does not have the OMX Encoder API. > > +skip-if = true # Test only ran on Gonk > > Check with Randell Jesup if we need this test at all anymore. Removed it.
Comment on attachment 8801260 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/plugins. https://reviewboard.mozilla.org/r/86004/#review84764 > Needinfo jya https://bugzilla.mozilla.org/show_bug.cgi?id=1182946#c36 jya handled this in bug 1314212
Comment on attachment 8801254 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/json. https://reviewboard.mozilla.org/r/85992/#review88714 > I'm wondering if these can go at this point. Filed bug 1313169 for dropping dom/inputmethod.
Comment on attachment 8801236 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/apps. Alexandre, this patch disables the dom/apps chrome tests. Should they be kept in tree? If I remember, there were more app-related tests in different directories, but they seem to have already been removed.
Attachment #8801236 - Flags: feedback?(lissyx+mozillians)
Well there is ongoing work to put a bullet into dom/apps completely, so I would say just remove them, no value in keeping. Now technically I am no peer of this, but I don't think it would be a problem in this case :)
Comment on attachment 8801236 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/apps. https://reviewboard.mozilla.org/r/85956/#review90578
Attachment #8801236 - Flags: review+
Attachment #8801236 - Flags: feedback?(lissyx+mozillians)
Comment on attachment 8801236 [details] Bug 1310297 - Remove test annotations using b2g, mulet or gonk: dom/apps. https://reviewboard.mozilla.org/r/85956/#review84654 > I'm wondering if these should just be removed at this point. Probably worth pinging gerard-majax about it. Removed the chrome tests.
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/7ef66a5e57ac Remove test annotations using b2g, mulet or gonk: browser. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/c190459f9e03 Remove test annotations using b2g, mulet or gonk: caps. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/2b55ec912ac5 Remove test annotations using b2g, mulet or gonk: chrome. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/89738aaf87c1 Remove test annotations using b2g, mulet or gonk: devtools. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/82ab05df35f7 Remove test annotations using b2g, mulet or gonk: docshell. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/1e3310aa319d Remove test annotations using b2g, mulet or gonk: dom/animation. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/365227cc8c6b Remove test annotations using b2g, mulet or gonk: dom/apps. r=gerard-majax,RyanVM https://hg.mozilla.org/integration/autoland/rev/9d136b70985b Remove test annotations using b2g, mulet or gonk: dom/archivereader. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/6809bf6acf2e Remove test annotations using b2g, mulet or gonk: dom/base. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/63e0fce78144 Remove test annotations using b2g, mulet or gonk: dom/bindings. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/3cf5abd5dede Remove test annotations using b2g, mulet or gonk: dom/broadcastchannel. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/8a5ca86cb5d7 Remove test annotations using b2g, mulet or gonk: dom/browser-element. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/a6711dd19615 Remove test annotations using b2g, mulet or gonk: dom/cache. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/72f599526c3e Remove test annotations using b2g, mulet or gonk: dom/canvas. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/8b48318b227c Remove test annotations using b2g, mulet or gonk: dom/console. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/c94607d8ac87 Remove test annotations using b2g, mulet or gonk: dom/crypto. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/05a67089ffd2 Remove test annotations using b2g, mulet or gonk: dom/devicestorage. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/3a97d4394764 Remove test annotations using b2g, mulet or gonk: dom/encoding. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/f462dcc8b14d Remove test annotations using b2g, mulet or gonk: dom/events. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/fe49064ccca0 Remove test annotations using b2g, mulet or gonk: dom/html. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/888033db1e2e Remove test annotations using b2g, mulet or gonk: dom/imptests. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/bf145f0505bd Remove test annotations using b2g, mulet or gonk: dom/indexedDB. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/e077cd6f207c Remove test annotations using b2g, mulet or gonk: dom/inputmethod. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/eccf63d3738e Remove test annotations using b2g, mulet or gonk: dom/ipc. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/a7019a80d007 Remove test annotations using b2g, mulet or gonk: dom/json. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/0c132727ac31 Remove test annotations using b2g, mulet or gonk: dom/jsurl. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/3b3a7ce28a42 Remove test annotations using b2g, mulet or gonk: dom/media. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/66c24d153af8 Remove test annotations using b2g, mulet or gonk: dom/network. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/c2798e814069 Remove test annotations using b2g, mulet or gonk: dom/notification. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/d33f4926f6cf Remove test annotations using b2g, mulet or gonk: dom/permission. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/8649b3243a13 Remove test annotations using b2g, mulet or gonk: dom/plugins. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/bc97752afd9c Remove test annotations using b2g, mulet or gonk: dom/power. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/057a4086031c Remove test annotations using b2g, mulet or gonk: dom/presentation. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/756a94ac4754 Remove test annotations using b2g, mulet or gonk: dom/promise. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/656892c00905 Remove test annotations using b2g, mulet or gonk: dom/push. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/77b8d2222315 Remove test annotations using b2g, mulet or gonk: dom/security. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/4e9bd4063b15 Remove test annotations using b2g, mulet or gonk: dom/svg. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/3d25e5ad5459 Remove test annotations using b2g, mulet or gonk: dom/system. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/648493535386 Remove test annotations using b2g, mulet or gonk: dom/tests. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/8ada21f8ae7b Remove test annotations using b2g, mulet or gonk: dom/url. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/460ebcbf27cd Remove test annotations using b2g, mulet or gonk: dom/workers. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/17bfe7005aa7 Remove test annotations using b2g, mulet or gonk: dom/xbl. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/2b3b14097348 Remove test annotations using b2g, mulet or gonk: dom/xhr. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/abc467f5968e Remove test annotations using b2g, mulet or gonk: dom/xml. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/4a9b93ec7422 Remove test annotations using b2g, mulet or gonk: dom/xul. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/1d609a2887cd Remove test annotations using b2g, mulet or gonk: editor. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/563383b1a546 Remove test annotations using b2g, mulet or gonk: embedding. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/b68d70646ba1 Remove test annotations using b2g, mulet or gonk: extensions. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/3a43dbeb1c09 Remove test annotations using b2g, mulet or gonk: gfx. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/73f2d5cb1ebd Remove test annotations using b2g, mulet or gonk: image. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/76a3e514d699 Remove test annotations using b2g, mulet or gonk: intl. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/e337b15543f4 Remove test annotations using b2g, mulet or gonk: ipc. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/bf711dd4d4da Remove test annotations using b2g, mulet or gonk: js. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/05156801c3c1 Remove test annotations using b2g, mulet or gonk: layout/base. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/dd75620065a9 Remove test annotations using b2g, mulet or gonk: layout/forms. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/4dbb0f3fcb90 Remove test annotations using b2g, mulet or gonk: layout/generic. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/b62631078e5a Remove test annotations using b2g, mulet or gonk: layout/inspector. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/3b561c7b5e4f Remove test annotations using b2g, mulet or gonk: layout/style. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/a0244d81e456 Remove test annotations using b2g, mulet or gonk: layout/xul. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/60c84b2e1a0e Remove test annotations using b2g, mulet or gonk: modules. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/7f4ebf66b98e Remove test annotations using b2g, mulet or gonk: netwerk. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/18b940b7127b Remove test annotations using b2g, mulet or gonk: parser. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/1ebca799fd9c Remove test annotations using b2g, mulet or gonk: rdf. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/d5f6ee4455be Remove test annotations using b2g, mulet or gonk: security. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/47326eec64a8 Remove test annotations using b2g, mulet or gonk: services. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/c92eb49b6d37 Remove test annotations using b2g, mulet or gonk: storage. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/f82afee9057c Remove test annotations using b2g, mulet or gonk: toolkit. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/fc19521feaa5 Remove test annotations using b2g, mulet or gonk: uriloader. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/bfab724f8ed8 Remove test annotations using b2g, mulet or gonk: widget. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/7d0ab5434a3c Remove test annotations using b2g, mulet or gonk: xpcom. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/f943477f8ad2 Remove test annotations using b2g, mulet or gonk: xpfe. r=RyanVM
Thank you for doing this!
https://hg.mozilla.org/mozilla-central/rev/7ef66a5e57ac https://hg.mozilla.org/mozilla-central/rev/c190459f9e03 https://hg.mozilla.org/mozilla-central/rev/2b55ec912ac5 https://hg.mozilla.org/mozilla-central/rev/89738aaf87c1 https://hg.mozilla.org/mozilla-central/rev/82ab05df35f7 https://hg.mozilla.org/mozilla-central/rev/1e3310aa319d https://hg.mozilla.org/mozilla-central/rev/365227cc8c6b https://hg.mozilla.org/mozilla-central/rev/9d136b70985b https://hg.mozilla.org/mozilla-central/rev/6809bf6acf2e https://hg.mozilla.org/mozilla-central/rev/63e0fce78144 https://hg.mozilla.org/mozilla-central/rev/3cf5abd5dede https://hg.mozilla.org/mozilla-central/rev/8a5ca86cb5d7 https://hg.mozilla.org/mozilla-central/rev/a6711dd19615 https://hg.mozilla.org/mozilla-central/rev/72f599526c3e https://hg.mozilla.org/mozilla-central/rev/8b48318b227c https://hg.mozilla.org/mozilla-central/rev/c94607d8ac87 https://hg.mozilla.org/mozilla-central/rev/05a67089ffd2 https://hg.mozilla.org/mozilla-central/rev/3a97d4394764 https://hg.mozilla.org/mozilla-central/rev/f462dcc8b14d https://hg.mozilla.org/mozilla-central/rev/fe49064ccca0 https://hg.mozilla.org/mozilla-central/rev/888033db1e2e https://hg.mozilla.org/mozilla-central/rev/bf145f0505bd https://hg.mozilla.org/mozilla-central/rev/e077cd6f207c https://hg.mozilla.org/mozilla-central/rev/eccf63d3738e https://hg.mozilla.org/mozilla-central/rev/a7019a80d007 https://hg.mozilla.org/mozilla-central/rev/0c132727ac31 https://hg.mozilla.org/mozilla-central/rev/3b3a7ce28a42 https://hg.mozilla.org/mozilla-central/rev/66c24d153af8 https://hg.mozilla.org/mozilla-central/rev/c2798e814069 https://hg.mozilla.org/mozilla-central/rev/d33f4926f6cf https://hg.mozilla.org/mozilla-central/rev/8649b3243a13 https://hg.mozilla.org/mozilla-central/rev/bc97752afd9c https://hg.mozilla.org/mozilla-central/rev/057a4086031c https://hg.mozilla.org/mozilla-central/rev/756a94ac4754 https://hg.mozilla.org/mozilla-central/rev/656892c00905 https://hg.mozilla.org/mozilla-central/rev/77b8d2222315 https://hg.mozilla.org/mozilla-central/rev/4e9bd4063b15 https://hg.mozilla.org/mozilla-central/rev/3d25e5ad5459 https://hg.mozilla.org/mozilla-central/rev/648493535386 https://hg.mozilla.org/mozilla-central/rev/8ada21f8ae7b https://hg.mozilla.org/mozilla-central/rev/460ebcbf27cd https://hg.mozilla.org/mozilla-central/rev/17bfe7005aa7 https://hg.mozilla.org/mozilla-central/rev/2b3b14097348 https://hg.mozilla.org/mozilla-central/rev/abc467f5968e https://hg.mozilla.org/mozilla-central/rev/4a9b93ec7422 https://hg.mozilla.org/mozilla-central/rev/1d609a2887cd https://hg.mozilla.org/mozilla-central/rev/563383b1a546 https://hg.mozilla.org/mozilla-central/rev/b68d70646ba1 https://hg.mozilla.org/mozilla-central/rev/3a43dbeb1c09 https://hg.mozilla.org/mozilla-central/rev/73f2d5cb1ebd https://hg.mozilla.org/mozilla-central/rev/76a3e514d699 https://hg.mozilla.org/mozilla-central/rev/e337b15543f4 https://hg.mozilla.org/mozilla-central/rev/bf711dd4d4da https://hg.mozilla.org/mozilla-central/rev/05156801c3c1 https://hg.mozilla.org/mozilla-central/rev/dd75620065a9 https://hg.mozilla.org/mozilla-central/rev/4dbb0f3fcb90 https://hg.mozilla.org/mozilla-central/rev/b62631078e5a https://hg.mozilla.org/mozilla-central/rev/3b561c7b5e4f https://hg.mozilla.org/mozilla-central/rev/a0244d81e456 https://hg.mozilla.org/mozilla-central/rev/60c84b2e1a0e https://hg.mozilla.org/mozilla-central/rev/7f4ebf66b98e https://hg.mozilla.org/mozilla-central/rev/18b940b7127b https://hg.mozilla.org/mozilla-central/rev/1ebca799fd9c https://hg.mozilla.org/mozilla-central/rev/d5f6ee4455be https://hg.mozilla.org/mozilla-central/rev/47326eec64a8 https://hg.mozilla.org/mozilla-central/rev/c92eb49b6d37 https://hg.mozilla.org/mozilla-central/rev/f82afee9057c https://hg.mozilla.org/mozilla-central/rev/fc19521feaa5 https://hg.mozilla.org/mozilla-central/rev/bfab724f8ed8 https://hg.mozilla.org/mozilla-central/rev/7d0ab5434a3c https://hg.mozilla.org/mozilla-central/rev/f943477f8ad2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Epic. Thanks for doing this!
No longer blocks: 1369194
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: