1312434 - Make sure that activity stream panel is accessible (a11y friendly)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Our current top sites panel can be navigated using Talkback / the Voice Assistant. We should make sure that this is still true for the new AS panel.

Comment 1

[Andrzej Hunt :ahunt]

I'll use this bug to fix the most glaring / low-hanging issues. I've filed bug 1315197 to look into improving topsites, since that's a bit more tricky and I don't have any good solutions there yet.

Issues I'll tackle here:
- Menu buttons are non-accessible (no description)
- "Highlights" title comes directly before the topsites list (i.e. after you swipe through the top sites / history / bookmarks, Talkback proceeds to the highlights title, and then continues with the individual topsites)

More evaluation required:
- Talkback can walk through topsites, however the topsites pager doesn't automatically scroll. I.e. it once you have walked through the topsites on screen, the off-screen topsites will be described (but you can't see them).
-- Option 1: force the ViewPager to automatically scroll: I've been trying to do this, but it doesn't work satisfactorily.
-- Option 2: switch to something different. (RecyclerView has good auto-scrolling behaviour, as visible when going through highlights - but we'd need to use RecyclerView + LinearSnapHelper or similar to keep the paging behaviour, and that requires support library >= 24.2).
-- Option 3: make the paging behaviour more explicit?

I feel like it would be good to get an accessibility expert look at topsites to determine what good behaviour would be.

Comment 2

[Andrzej Hunt :ahunt]

Attachment: Bug 1312434 - Post: cleanup obsolete layout params

By default, a TextView within e.g. a RelativeLayout will be used as the description for
the entire layout. I.e. traversal of the RecyclerView would begin with the Highlights title
being read, and the entire toppanel (i.e. TopSites + the Highlights title) being focused,
followed by traversing the TopSites pager. Instead we want to make sure TopSites are
traversed _before_ getting to the highlights title.

Review commit: https://reviewboard.mozilla.org/r/90624/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90624/

Comment 3

[Andrzej Hunt :ahunt]

Attachment: Bug 1312434 - add ContentDescription to Activity Stream menus and topsites

Review commit: https://reviewboard.mozilla.org/r/90626/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90626/

Comment 4

[Andrzej Hunt :ahunt]

I also added another bug to look at the menus: Bug 1315201.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8807480 [details]
Bug 1312434 - Post: cleanup obsolete layout params

https://reviewboard.mozilla.org/r/90624/#review90814

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8807481 [details]
Bug 1312434 - add ContentDescription to Activity Stream menus and topsites

https://reviewboard.mozilla.org/r/90626/#review90816

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e56f56c09a1
Move Highlights title into separate RV item for better accessibility traversal r=sebastian
https://hg.mozilla.org/integration/autoland/rev/9af814b282fa
add ContentDescription to Activity Stream menus and topsites r=sebastian

Comment 8

[Andrzej Hunt :ahunt]

Comment on attachment 8807480 [details]
Bug 1312434 - Post: cleanup obsolete layout params

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/90624/diff/1-2/

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8807480 [details]
Bug 1312434 - Post: cleanup obsolete layout params

https://reviewboard.mozilla.org/r/90624/#review91242

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39feb13d7962
Post: cleanup obsolete layout params r=sebastian

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8e56f56c09a1
https://hg.mozilla.org/mozilla-central/rev/9af814b282fa
https://hg.mozilla.org/mozilla-central/rev/39feb13d7962