Closed Bug 1312434 Opened 3 years ago Closed 3 years ago

Make sure that activity stream panel is accessible (a11y friendly)

Categories

(Firefox for Android :: General, defect, P1)

All
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 52
Iteration:
1.8
Tracking Status
firefox52 --- fixed

People

(Reporter: sebastian, Assigned: ahunt)

References

(Blocks 1 open bug)

Details

(Whiteboard: [MobileAS])

Attachments

(1 file, 1 obsolete file)

Our current top sites panel can be navigated using Talkback / the Voice Assistant. We should make sure that this is still true for the new AS panel.
Whiteboard: [MobileAS]
Assignee: nobody → ahunt
Iteration: --- → 1.8
Priority: P2 → P1
Blocks: 1315197
I'll use this bug to fix the most glaring / low-hanging issues. I've filed bug 1315197 to look into improving topsites, since that's a bit more tricky and I don't have any good solutions there yet.

Issues I'll tackle here:
- Menu buttons are non-accessible (no description)
- "Highlights" title comes directly before the topsites list (i.e. after you swipe through the top sites / history / bookmarks, Talkback proceeds to the highlights title, and then continues with the individual topsites)

More evaluation required:
- Talkback can walk through topsites, however the topsites pager doesn't automatically scroll. I.e. it once you have walked through the topsites on screen, the off-screen topsites will be described (but you can't see them).
-- Option 1: force the ViewPager to automatically scroll: I've been trying to do this, but it doesn't work satisfactorily.
-- Option 2: switch to something different. (RecyclerView has good auto-scrolling behaviour, as visible when going through highlights - but we'd need to use RecyclerView + LinearSnapHelper or similar to keep the paging behaviour, and that requires support library >= 24.2).
-- Option 3: make the paging behaviour more explicit?

I feel like it would be good to get an accessibility expert look at topsites to determine what good behaviour would be.
I also added another bug to look at the menus: Bug 1315201.
Comment on attachment 8807480 [details]
Bug 1312434 - Post: cleanup obsolete layout params

https://reviewboard.mozilla.org/r/90624/#review90814
Attachment #8807480 - Flags: review?(s.kaspari) → review+
Comment on attachment 8807481 [details]
Bug 1312434 - add ContentDescription to Activity Stream menus and topsites

https://reviewboard.mozilla.org/r/90626/#review90816
Attachment #8807481 - Flags: review?(s.kaspari) → review+
Pushed by ahunt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e56f56c09a1
Move Highlights title into separate RV item for better accessibility traversal r=sebastian
https://hg.mozilla.org/integration/autoland/rev/9af814b282fa
add ContentDescription to Activity Stream menus and topsites r=sebastian
Attachment #8807481 - Attachment is obsolete: true
Comment on attachment 8807480 [details]
Bug 1312434 - Post: cleanup obsolete layout params

https://reviewboard.mozilla.org/r/90624/#review91242
Pushed by ahunt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/39feb13d7962
Post: cleanup obsolete layout params r=sebastian
Blocks: 1317631
No longer blocks: 1317631
Depends on: 1317631
You need to log in before you can comment on or make changes to this bug.