The default bug view has changed. See this FAQ.

Enable SharedArrayBuffer and Atomics in Firefox 52 Beta and Release

RESOLVED FIXED in Firefox 52

Status

()

Core
JavaScript Engine
P1
normal
RESOLVED FIXED
5 months ago
a month ago

People

(Reporter: lth, Assigned: lth)

Tracking

({dev-doc-complete})

52 Branch
mozilla53
dev-doc-complete
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox52 fixed, firefox53 fixed)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

5 months ago
Tentatively this feature is scheduled to ship with FF51.  We're awaiting final security review.

Shared memory and atomics are currently on by default on Nightly and (since bug 1309861) FF51 Developer Edition.  The feature is available, but disabled by default, in Beta and Release.
(Assignee)

Comment 1

5 months ago
Created attachment 8803906 [details] [diff] [review]
bug1312446-sab-atomics-all-channels.patch
We're still working through some final details on how and when to ship this, please hold.
(Assignee)

Comment 3

5 months ago
Created attachment 8804253 [details] [diff] [review]
bug1312446-sab-atomics-all-channels-v2.patch

Updated patch.  (Still holding: Not reviewed, and additional requested functionality still not ready.)
Attachment #8803906 - Attachment is obsolete: true
Keywords: dev-doc-needed
(Assignee)

Comment 4

5 months ago
Note, some Xrays support is about to land on trunk, see bug 1130988.  This containts tests for specific channels.  When landing this patch on central, those tests must additionally be adapted.
(Assignee)

Comment 5

5 months ago
Created attachment 8808169 [details] [diff] [review]
bug1312446-sab-atomics-ff52.patch

Patch appropriate for FF52 and later (current mozilla-central).
(Assignee)

Comment 6

2 months ago
When landing this also remember to update js/src/shell/js.cpp, which has a RELEASE_OR_BETA guard on enabling SAB+Atomics by default in the shell.
(Assignee)

Updated

2 months ago
Summary: Enable SharedArrayBuffer and Atomics in Firefox 51 Beta and Release → Enable SharedArrayBuffer and Atomics in Firefox 52 Beta and Release
(Assignee)

Updated

2 months ago
Version: 51 Branch → 52 Branch
(Assignee)

Comment 7

2 months ago
Created attachment 8828381 [details] [diff] [review]
bug1312446-enable-sab-and-atomics.patch

We want to enable SAB+Atomics on beta for a while to ensure greater exposure to the web -- the feature has been enabled only on Nightly and Aurora so far.  If the ship criteria are not met by February 20 I will back the patch out again.

(This patch for m-c, uplift request and maybe aurora patch to follow.)
Attachment #8828381 - Flags: review?(shu)
(Assignee)

Comment 8

2 months ago
Created attachment 8828383 [details] [diff] [review]
bug1312446-enable-sab-and-atomics-AURORA.patch

Ditto patch for aurora.

Comment 9

2 months ago
Comment on attachment 8828381 [details] [diff] [review]
bug1312446-enable-sab-and-atomics.patch

Review of attachment 8828381 [details] [diff] [review]:
-----------------------------------------------------------------

Changes themselves look good to me. The commit message says "on beta", so just confirming, this is done by not backporting this patch to release?
Attachment #8828381 - Flags: review?(shu) → review+
(Assignee)

Comment 10

2 months ago
(In reply to Shu-yu Guo [:shu] from comment #9)
> Comment on attachment 8828381 [details] [diff] [review]
> bug1312446-enable-sab-and-atomics.patch
> 
> Review of attachment 8828381 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Changes themselves look good to me. The commit message says "on beta", so
> just confirming, this is done by not backporting this patch to release?

The commit message does not mention "beta" but the comment submitted with the patch above does.  The thing is, there's no difference between release and beta in the code - features are enabled for both or neither.  So what's happening here (cf my comment above) is that I'm enabling for beta by landing this patch on central and aurora now (aurora becomes beta next week) but not enabling for release by promising (again cf comment) to back it out before beta becomes release, if the release criteria are not met.
(Assignee)

Comment 11

2 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=308016a38200
(Assignee)

Comment 12

2 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d870873f2b76157d57bcff8447140f7c0f7f877
Bug 1312446 - Enable SharedArrayBuffer and Atomics by default. r=shu
(Assignee)

Comment 13

2 months ago
Comment on attachment 8828383 [details] [diff] [review]
bug1312446-enable-sab-and-atomics-AURORA.patch

Approval Request Comment

[Feature/Bug causing the regression]:
SharedArrayBuffer and Atomics

[User impact if declined]:
Feature will have to be manually enabled on beta, which is the current situation

[Is this code covered by automated tests?]:
Yes

[Has the fix been verified in Nightly?]:
Yes - enabled by default on Nightly (and indeed in Aurora) for months.  Available behind flag on Beta and Release for ditto time.

[Needs manual test from QE? If yes, steps to reproduce]: 
No

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
Not really, and in any case, we want to test web compat, so some risk is required.

[Why is the change risky/not risky?]:
Extremely remote chance that the names of new global JS types clash with names that are used in programs on the web.

[String changes made/needed]:
None
Attachment #8828383 - Flags: approval-mozilla-aurora?

Comment 14

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4d870873f2b7
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment on attachment 8828383 [details] [diff] [review]
bug1312446-enable-sab-and-atomics-AURORA.patch

keep SharedArrayBuffer and Atomics enabled in beta, aurora52+
Attachment #8828383 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 16

2 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/3a090ab6da4a
status-firefox52: --- → fixed
Flags: in-testsuite+
Backed out for sharedtypedarray.js failures.
https://treeherder.mozilla.org/logviewer.html#?job_id=70852563&repo=mozilla-aurora

https://hg.mozilla.org/releases/mozilla-aurora/rev/b9613014ba65c40a78227be03c69e993c70f96ad
status-firefox52: fixed → affected
Flags: needinfo?(lhansen)

Comment 18

2 months ago
bugherderuplift
Went a little better with bug 1332576 included.
https://hg.mozilla.org/releases/mozilla-aurora/rev/3209927fdbf9
status-firefox52: affected → fixed
Flags: needinfo?(lhansen)
Added release notes announcement
https://developer.mozilla.org/en-US/Firefox/Releases/52#JavaScript

Updated SharedArrayBuffer and Atomics compat info (also on the sub pages)
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Atomics#Browser_compatibility
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.