Enable SharedArrayBuffer and Atomics in Firefox 52 Beta and Release

RESOLVED FIXED in Firefox 52

Status

()

defect
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: lth, Assigned: lth)

Tracking

({dev-doc-complete})

52 Branch
mozilla53
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox52 fixed, firefox53 fixed)

Details

Attachments

(4 attachments, 1 obsolete attachment)

Tentatively this feature is scheduled to ship with FF51.  We're awaiting final security review.

Shared memory and atomics are currently on by default on Nightly and (since bug 1309861) FF51 Developer Edition.  The feature is available, but disabled by default, in Beta and Release.
We're still working through some final details on how and when to ship this, please hold.
Updated patch.  (Still holding: Not reviewed, and additional requested functionality still not ready.)
Attachment #8803906 - Attachment is obsolete: true
Note, some Xrays support is about to land on trunk, see bug 1130988.  This containts tests for specific channels.  When landing this patch on central, those tests must additionally be adapted.
Patch appropriate for FF52 and later (current mozilla-central).
When landing this also remember to update js/src/shell/js.cpp, which has a RELEASE_OR_BETA guard on enabling SAB+Atomics by default in the shell.
Summary: Enable SharedArrayBuffer and Atomics in Firefox 51 Beta and Release → Enable SharedArrayBuffer and Atomics in Firefox 52 Beta and Release
Version: 51 Branch → 52 Branch
We want to enable SAB+Atomics on beta for a while to ensure greater exposure to the web -- the feature has been enabled only on Nightly and Aurora so far.  If the ship criteria are not met by February 20 I will back the patch out again.

(This patch for m-c, uplift request and maybe aurora patch to follow.)
Attachment #8828381 - Flags: review?(shu)
Ditto patch for aurora.
Comment on attachment 8828381 [details] [diff] [review]
bug1312446-enable-sab-and-atomics.patch

Review of attachment 8828381 [details] [diff] [review]:
-----------------------------------------------------------------

Changes themselves look good to me. The commit message says "on beta", so just confirming, this is done by not backporting this patch to release?
Attachment #8828381 - Flags: review?(shu) → review+
(In reply to Shu-yu Guo [:shu] from comment #9)
> Comment on attachment 8828381 [details] [diff] [review]
> bug1312446-enable-sab-and-atomics.patch
> 
> Review of attachment 8828381 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Changes themselves look good to me. The commit message says "on beta", so
> just confirming, this is done by not backporting this patch to release?

The commit message does not mention "beta" but the comment submitted with the patch above does.  The thing is, there's no difference between release and beta in the code - features are enabled for both or neither.  So what's happening here (cf my comment above) is that I'm enabling for beta by landing this patch on central and aurora now (aurora becomes beta next week) but not enabling for release by promising (again cf comment) to back it out before beta becomes release, if the release criteria are not met.
Comment on attachment 8828383 [details] [diff] [review]
bug1312446-enable-sab-and-atomics-AURORA.patch

Approval Request Comment

[Feature/Bug causing the regression]:
SharedArrayBuffer and Atomics

[User impact if declined]:
Feature will have to be manually enabled on beta, which is the current situation

[Is this code covered by automated tests?]:
Yes

[Has the fix been verified in Nightly?]:
Yes - enabled by default on Nightly (and indeed in Aurora) for months.  Available behind flag on Beta and Release for ditto time.

[Needs manual test from QE? If yes, steps to reproduce]: 
No

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
Not really, and in any case, we want to test web compat, so some risk is required.

[Why is the change risky/not risky?]:
Extremely remote chance that the names of new global JS types clash with names that are used in programs on the web.

[String changes made/needed]:
None
Attachment #8828383 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/4d870873f2b7
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment on attachment 8828383 [details] [diff] [review]
bug1312446-enable-sab-and-atomics-AURORA.patch

keep SharedArrayBuffer and Atomics enabled in beta, aurora52+
Attachment #8828383 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: needinfo?(lhansen)
You need to log in before you can comment on or make changes to this bug.