The default bug view has changed. See this FAQ.

Disable async rendering by default on 49.0.2 using a system addon

RESOLVED FIXED

Status

()

Core
Plug-ins
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: bsmedberg, Assigned: bytesized)

Tracking

(Depends on: 1 bug)

unspecified
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49blocking fixed)

Details

(Whiteboard: [fce-active][go-faster-system-addon])

Attachments

(4 attachments)

(Reporter)

Description

5 months ago
+++ This bug was initially created as a clone of Bug #1307108 +++

Async/direct plugin rendering has many regressions, and we need to turn it off in 49.0.2 (sorry!). 

Please implement the same pref flip as bug 1307108 but in reverse to disable.

This addon should be deployed to windows 32-bit only. We do *not* intend to deploy this to windows 64-bit, because it would cause more serious regressions in scrolling and IME support.
(Reporter)

Updated

5 months ago
Summary: Enable async rendering by default on 49 using a system addon → Enable async rendering by default on 49.0.2 using a system addon
(Reporter)

Updated

5 months ago
Summary: Enable async rendering by default on 49.0.2 using a system addon → Disable async rendering by default on 49.0.2 using a system addon
status-firefox49: --- → affected
tracking-firefox49: --- → blocking

Comment 1

5 months ago
Please do keep the gofaster@mozilla.org mailing list updated with progress on intention to implement/ship[0].

[0] https://wiki.mozilla.org/Firefox/Go_Faster/Process#Process_to_Push_updates_to_release_channel
(Assignee)

Comment 2

5 months ago
Created attachment 8804090 [details] [diff] [review]
async_pref.patch
Attachment #8804090 - Flags: review?(felipc)
(Assignee)

Comment 3

5 months ago
Created attachment 8804091 [details] [diff] [review]
async_addon.patch
Attachment #8804091 - Flags: review?(felipc)
(Assignee)

Comment 4

5 months ago
Created attachment 8804092 [details]
async_rendering.xpi
Attachment #8804092 - Flags: review?(felipc)

Comment 5

5 months ago
QA Update: I will be running some test to ensure the addon works - currenlty I cannot install the addon "Firefox has prevented this site from installing and unverified addon" - Will there be a signed XPI?
Flags: needinfo?(ksteuber)
Flags: needinfo?(felipc)
(Assignee)

Comment 6

5 months ago
I will get the addon signed after it has passed review.
Flags: needinfo?(ksteuber)
Flags: needinfo?(felipc)
Attachment #8804091 - Flags: review?(felipc) → review+
Attachment #8804090 - Flags: review?(felipc) → review+

Comment 7

5 months ago
Fix this on Win10x64 too!

Comment 8

5 months ago
The worry is that right now these performance issues render so many popular games and sites unplayable. It's a big deal as millions access these games daily. The experience of users at http://www.friv.com for example is affected the point where even clicking on a game is near impossible owing to the lag. Friv is a world top 500 site. I'd echo Dexter above "Fix this on Win10x64 too!" Thanks guys.
(Assignee)

Comment 9

5 months ago
My understanding is that the other regressions are serious enough that we consider this necessary despite performance regressions. @bsmedberg Can you confirm?
Flags: needinfo?(benjamin)
We definitely want to fix the issues for win64 too, but that fix will land in the Firefox 50 release which will happen Nov. 8th.  Since that happens in just a couple of weeks, it is best to wait for Firefox 50 to come out. The Firefox beta 50 that is planned to release later this week (Friday) should also work for win64 users. 

For win32, we can disable async rendering with this system add-on/hotfix; For win64 there are bigger code changes, so we'd need to ship a full release to fix async rendering/plugin drawing.

Comment 11

5 months ago
All affected devs from flash games: changing the wmode to "gpu" helps so far very good, and accellerates the game.
Comment on attachment 8804092 [details]
async_rendering.xpi

(no need to review the xpi)
Attachment #8804092 - Flags: review?(felipc)
(Assignee)

Comment 13

5 months ago
Comment on attachment 8804092 [details]
async_rendering.xpi

@jason Could I get this XPI signed please?
Flags: needinfo?(jthomas)

Comment 14

5 months ago
Created attachment 8804461 [details]
async_rendering.signed.xpi

The file is signed.
(Assignee)

Updated

5 months ago
Flags: needinfo?(jthomas)
QA Update: The system addon to revert does what it is supposed to do. 
Test: Windows 7, Windows 8.1, Windows 10 with Firefox 32bit
The release-sysaddon channel has been updated as follows and is ready for testing.

The rule shipping to 49.0.2 has been modified to ship the following add-on (there were previously no system add-ons shipping to this version).

- asyncrendering-2.0 (bug 1312528)

Comment 17

5 months ago
Hi.

I installed async_rendering.signed.xpi and default value for dom.ipc.plugins.asyncdrawing.enabled changed to false. But  I still have issue with game performance on non debug version of Flash player version 23.0.0.205.

After restarting browser and computer I have the same result.

You can check by yourself - https://apps.facebook.com/slotomania

Best regards,
Slototmania TL 
Andrew Gurskiy
(Assignee)

Comment 18

5 months ago
Andrew - If your problems are independent of the |dom.ipc.plugins.asyncdrawing.enabled| pref, they are likely unrelated to this bug. You should file a separate bug for your issue.
(Reporter)

Updated

5 months ago
Flags: needinfo?(benjamin)
The following has been moved to the *release* channel

- 49.0/49.0.1 will now receive asyncrendering-2.0 instead of 1.0. No other changes.
- 49.0.2 will receive asyncrendering-2.0.

Updated

5 months ago
Whiteboard: [fce-active] → [fce-active][go-faster-system-addon]

Comment 20

5 months ago
Is the addon shipped already?
How I can confirm?
(Reporter)

Comment 21

5 months ago
It should be shipped to 49.0.2 per comment 19. Check about:support to see if the addon is present and then the pref values.

Comment 22

5 months ago
(In reply to Benjamin Smedberg [:bsmedberg] from comment #21)
> It should be shipped to 49.0.2 per comment 19. Check about:support to see if
> the addon is present and then the pref values.

I open Firefox49.0.2 for a day. But it is not present in about:support.
The prefs is still true.

Why do not 49.0.3 release?
(Assignee)

Comment 23

5 months ago
Alice0775 - I believe that the changes do not show up until the browser is restarted.

Comment 24

5 months ago
(In reply to Kirk Steuber [:bytesized] from comment #23)
> Alice0775 - I believe that the changes do not show up until the browser is
> restarted.

Just now, I restart the browser. But nothing is changed.
Alice, do you have automatic Firefox updates disabled?

Comment 26

5 months ago
Yes, I set "Never check for updates (not recommended: security risk)"

Comment 27

5 months ago
Start Firefox49.0.2 with new profile and restart. But, the addon is not present. And the rpef is still true. Why?

So, User cannot control to get system addon. Anyway, I think hotfix system is not good solution.
Ok, so that's the reason. This is being tracked by bug 1307563 but there's no clear solution yet.

Comment 29

5 months ago
(In reply to :Felipe Gomes (needinfo me!) from comment #28)
> Ok, so that's the reason. This is being tracked by bug 1307563 but there's
> no clear solution yet.

Yes. That is.

How about comment#27?
(In reply to Alice0775 White from comment #29)
> (In reply to :Felipe Gomes (needinfo me!) from comment #28)
> > Ok, so that's the reason. This is being tracked by bug 1307563 but there's
> > no clear solution yet.
> 
> Yes. That is.
> 
> How about comment#27?

And that point is tracked by bug 1307553

Comment 31

5 months ago
Thanks
This was shipped last week, marking fixed for 49 and fixed overall. 

Please note that this is for win32 only.  If you are waiting on a fix for win64, please try the latest beta 50 version, currently beta 11: https://www.mozilla.org/en-US/firefox/channel/desktop/. 
The fix for win64 on the release channel should be available Nov. 15th.
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.