1312716 - `firefox --preferences` no longer works (ReferenceError: sa is not defined nsBrowserContentHandler.js)

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Mark Banner (:standard8)]

This is a regression from bug 1311223, I happened to spot whilst looking at eslint output to enable some more rules.

STR:

1) Start firefox with `firefox --preferences`

Expected Results:

- Opens Firefox with about:preferences showing.

Actual Results:

- Opens Firefox with the normal homepage. In the console it shows "ReferenceError: sa is not defined  nsBrowserContentHandler.js:234:3"

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1312716 - '-preferences' on the command line no longer works due to an undefined variable.

Review commit: https://reviewboard.mozilla.org/r/88312/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88312/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8804222 [details]
Bug 1312716 - '-preferences' on the command line no longer works due to an undefined variable.

https://reviewboard.mozilla.org/r/88312/#review87316

::: browser/components/nsBrowserContentHandler.js:5
(Diff revision 1)
>  /* This Source Code Form is subject to the terms of the Mozilla Public
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
> +/* eslint no-undef:2 */

Note: bug 1311312 is enabling no-undef globally.

We can't put no-undef in the .eslintrc as the rest of the directory isn't ready for that, but this file is clean after this change, so lets keep it that way.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8804222 [details]
Bug 1312716 - '-preferences' on the command line no longer works due to an undefined variable.

https://reviewboard.mozilla.org/r/88312/#review87346

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/301d2126dd45
'-preferences' on the command line no longer works due to an undefined variable. r=jaws

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/301d2126dd45