1312745 - New API to mark network loads as 'throttle-able' and 'urgent-start'

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Honza Bambas (:mayhemer)]

Seems like modifying (extending) the existing nsISupportsPriority interface is not the best way, its a general thing.  Keeping flags in the priority value is also not a good idea, since priority can be added/subtracted or completely replaced.

Hence, let's add a new interface, nsINetworkLoadPriority (: nsISupportsPriority) with:

attribute boolean throttleable
attribute boolean urgentStart

implementer: HttpChannelBase

The first attr annotates the channel as allowed to be throttled on page load pressure.  Applies to downloads and updates.

The second attr annotates the channel as slot "A" type (see the URL).  It means to go out as soon as possible with priority as the very first among all other channels, regardless any other priorities.  Applies to video play, image zoom, and maybe downloads.

Comment 1

[Honza Bambas (:mayhemer)]

I think this reduces to just add new flags to the existing nsIClassOfService interface.  Like 'Throttleable = 1 << 5' and 'UrgentStart = 1 << 6'.

Amy, would you be willing to take this bug?

Comment 2

[Amy Chung [:Amy]]

Ok, I will take a look at this big.

Comment 3

[Amy Chung [:Amy]]

Hi Honza,
Do I only need to add the 'Throttleable = 1 << 5' and 'UrgentStart = 1 << 6' in nsIClassOfService interface?
If we decide to implement all functions including to set class flags and priority, do we have to open new bug for implement?

Thanks!

Comment 4

[Honza Bambas (:mayhemer)]

(In reply to Amy Chung [:Amy] from comment #3)
> Hi Honza,
> Do I only need to add the 'Throttleable = 1 << 5' and 'UrgentStart = 1 << 6'
> in nsIClassOfService interface?

Yes, I think this bug is eventually that trivial.

> If we decide to implement all functions including to set class flags and
> priority, do we have to open new bug for implement?

Not sure what you mean exactly, but I think no.  These flags will be used in other bugs, listed in the "Blocks" list.  I originally though this bug would be more complicated, but it really is reduced to just add the flags.  I don't thing more changes are needed.  Only make sure it builds.

> 
> Thanks!

Me too :)

Comment 5

[Amy Chung [:Amy]]

Attachment: Added class flags in nsIClassOfService interface.

Hi Honza,
I have added Throttleable & UrgentStart in nsIClassOfService interface.
Please help me to review my patch.

Thanks!

Comment 6

[Honza Bambas (:mayhemer)]

Comment on attachment 8808962 [details] [diff] [review]
Added class flags in nsIClassOfService interface.

Review of attachment 8808962 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!  Yes, this is it.

Comment 7

[Amy Chung [:Amy]]

(In reply to Honza Bambas (:mayhemer) from comment #6)
> Comment on attachment 8808962 [details] [diff] [review]
> Added class flags in nsIClassOfService interface.
> 
> Review of attachment 8808962 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks!  Yes, this is it.

Thanks your help!

Comment 8

[Amy Chung [:Amy]]

Attachment: Added class flags in nsIClassOfService interface.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=04dc132519a59d8edc567761d2210bbe7b39defb

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9fff773417e1
Add class flags in nsIClassOfService interface. r=mayhemer

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9fff773417e1