Closed
Bug 1312771
Opened 8 years ago
Closed 8 years ago
Change priority of image loads when their position in the viewport changes by scrolling
Categories
(Core :: Layout: Images, Video, and HTML Frames, defect, P4)
Core
Layout: Images, Video, and HTML Frames
Tracking
()
RESOLVED
INCOMPLETE
mozilla55
People
(Reporter: mayhemer, Assigned: schien)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
960 bytes,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
Stage 2 for bug 1312770
Summary: Change priority of image loads when their position in the view port changes by scrolling → Change priority of image loads when their position in the viewport changes by scrolling
Comment 1•8 years ago
|
||
Too late for firefox 52, mass-wontfix.
Reporter | ||
Updated•8 years ago
|
Priority: -- → P1
Reporter | ||
Updated•8 years ago
|
Priority: P1 → P4
Assignee | ||
Comment 2•8 years ago
|
||
This patch can boost priority for images that are in viewport initially and after scrolling.
Assignee: nobody → schien
Attachment #8859146 -
Flags: review?(tnikkel)
Assignee | ||
Updated•8 years ago
|
Comment 3•8 years ago
|
||
Comment on attachment 8859146 [details] [diff] [review]
bug1312771.patch
This will work but we can get basically the same information earlier after the frame has been reflowed. Similar to how nsImageFrame::ReflowFinished is used now to update the approximate visibility, we'd just need to check actual visibility instead of approximate (which includes things that are just scrolled out of view). I mentioned this in another comment in the other bug. That can be done later if you want to improve on this.
Attachment #8859146 -
Flags: review?(tnikkel) → review+
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Timothy Nikkel (:tnikkel) from comment #3)
> Comment on attachment 8859146 [details] [diff] [review]
> bug1312771.patch
>
> This will work but we can get basically the same information earlier after
> the frame has been reflowed. Similar to how nsImageFrame::ReflowFinished is
> used now to update the approximate visibility, we'd just need to check
> actual visibility instead of approximate (which includes things that are
> just scrolled out of view). I mentioned this in another comment in the other
> bug. That can be done later if you want to improve on this.
Tried writing patch for the optimization but not feeling confident about my patch. Filed bug 1359351 to keep track the corresponding modification.
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b77aaea5f6c9
increase loading priority for images that are visible in viewport. r=tnikkel
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Reporter | ||
Comment 7•7 years ago
|
||
This patch doesn't work at all when I disable html parser image preload.
Resolution: FIXED → INCOMPLETE
Updated•6 years ago
|
Product: Core → Core Graveyard
Updated•6 years ago
|
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•