1312771 - Change priority of image loads when their position in the viewport changes by scrolling

Status: RESOLVED INCOMPLETE

(Core :: Layout: Images, Video, and HTML Frames, defect, P4)

Description

[Honza Bambas (:mayhemer)]

Stage 2 for bug 1312770

Comment 1

[Julien Cristau [:jcristau] (back April 22)]

Too late for firefox 52, mass-wontfix.

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: bug1312771.patch

This patch can boost priority for images that are in viewport initially and after scrolling.

Comment 3

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8859146 [details] [diff] [review]
bug1312771.patch

This will work but we can get basically the same information earlier after the frame has been reflowed. Similar to how nsImageFrame::ReflowFinished is used now to update the approximate visibility, we'd just need to check actual visibility instead of approximate (which includes things that are just scrolled out of view). I mentioned this in another comment in the other bug. That can be done later if you want to improve on this.

Comment 4

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

(In reply to Timothy Nikkel (:tnikkel) from comment #3)
> Comment on attachment 8859146 [details] [diff] [review]
> bug1312771.patch
> 
> This will work but we can get basically the same information earlier after
> the frame has been reflowed. Similar to how nsImageFrame::ReflowFinished is
> used now to update the approximate visibility, we'd just need to check
> actual visibility instead of approximate (which includes things that are
> just scrolled out of view). I mentioned this in another comment in the other
> bug. That can be done later if you want to improve on this.

Tried writing patch for the optimization but not feeling confident about my patch. Filed bug 1359351 to keep track the corresponding modification.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b77aaea5f6c9
increase loading priority for images that are visible in viewport. r=tnikkel

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b77aaea5f6c9

Comment 7

[Honza Bambas (:mayhemer)]

This patch doesn't work at all when I disable html parser image preload.