Closed Bug 1312771 Opened 4 years ago Closed 4 years ago

Change priority of image loads when their position in the viewport changes by scrolling

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect, P4)

defect

Tracking

()

RESOLVED INCOMPLETE
mozilla55
Tracking Status
firefox52 --- wontfix
firefox55 --- fixed

People

(Reporter: mayhemer, Assigned: schien)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Stage 2 for bug 1312770
Summary: Change priority of image loads when their position in the view port changes by scrolling → Change priority of image loads when their position in the viewport changes by scrolling
Too late for firefox 52, mass-wontfix.
Priority: -- → P1
Priority: P1 → P4
Attached patch bug1312771.patchSplinter Review
This patch can boost priority for images that are in viewport initially and after scrolling.
Assignee: nobody → schien
Attachment #8859146 - Flags: review?(tnikkel)
Depends on: 1357318
No longer depends on: 1312770
Comment on attachment 8859146 [details] [diff] [review]
bug1312771.patch

This will work but we can get basically the same information earlier after the frame has been reflowed. Similar to how nsImageFrame::ReflowFinished is used now to update the approximate visibility, we'd just need to check actual visibility instead of approximate (which includes things that are just scrolled out of view). I mentioned this in another comment in the other bug. That can be done later if you want to improve on this.
Attachment #8859146 - Flags: review?(tnikkel) → review+
(In reply to Timothy Nikkel (:tnikkel) from comment #3)
> Comment on attachment 8859146 [details] [diff] [review]
> bug1312771.patch
> 
> This will work but we can get basically the same information earlier after
> the frame has been reflowed. Similar to how nsImageFrame::ReflowFinished is
> used now to update the approximate visibility, we'd just need to check
> actual visibility instead of approximate (which includes things that are
> just scrolled out of view). I mentioned this in another comment in the other
> bug. That can be done later if you want to improve on this.

Tried writing patch for the optimization but not feeling confident about my patch. Filed bug 1359351 to keep track the corresponding modification.
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b77aaea5f6c9
increase loading priority for images that are visible in viewport. r=tnikkel
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b77aaea5f6c9
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Depends on: 1381084
This patch doesn't work at all when I disable html parser image preload.
Resolution: FIXED → INCOMPLETE
Product: Core → Core Graveyard
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.