Closed Bug 1357318 Opened 3 years ago Closed 3 years ago

provide infrastructure to boost image loading priority by category

Categories

(Core :: Layout: Images, Video, and HTML Frames, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: schien, Assigned: schien)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8859057 [details]
Bug 1357318 - remember previous priority boost request in imgRequest.

https://reviewboard.mozilla.org/r/131088/#review134732

::: image/imgIRequest.idl:212
(Diff revision 1)
>     * @see Image::DecrementAnimationConsumers for documentation of the
>     * underlying call.
>     */
>    void decrementAnimationConsumers();
> +
> +  const uint32_t CATEGORY_FRAME_INIT = 1 << 0;

Please add a comment describing what each category name means.

::: image/imgRequest.h:282
(Diff revision 1)
>    // The Referrer Policy (defined in ReferrerPolicy.h) used for this image.
>    ReferrerPolicy mReferrerPolicy;
>  
>    nsresult mImageErrorCode;
>  
> +  uint32_t mRequestedBoostCategory = 0;

mBoostCategoriesRequested?
Attachment #8859057 - Flags: review?(tnikkel) → review+
Pushed by schien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7f1f1559cd8d
remember previous priority boost request in imgRequest. r=tnikkel
https://hg.mozilla.org/mozilla-central/rev/7f1f1559cd8d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Core → Core Graveyard
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.