1357318 - provide infrastructure to boost image loading priority by category

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, enhancement)

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: Bug 1357318 - remember previous priority boost request in imgRequest.

Review commit: https://reviewboard.mozilla.org/r/131088/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131088/

Comment 2

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8859057 [details]
Bug 1357318 - remember previous priority boost request in imgRequest.

https://reviewboard.mozilla.org/r/131088/#review134732

::: image/imgIRequest.idl:212
(Diff revision 1)
>     * @see Image::DecrementAnimationConsumers for documentation of the
>     * underlying call.
>     */
>    void decrementAnimationConsumers();
> +
> +  const uint32_t CATEGORY_FRAME_INIT = 1 << 0;

Please add a comment describing what each category name means.

::: image/imgRequest.h:282
(Diff revision 1)
>    // The Referrer Policy (defined in ReferrerPolicy.h) used for this image.
>    ReferrerPolicy mReferrerPolicy;
>  
>    nsresult mImageErrorCode;
>  
> +  uint32_t mRequestedBoostCategory = 0;

mBoostCategoriesRequested?

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8859057 [details]
Bug 1357318 - remember previous priority boost request in imgRequest.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131088/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f1f1559cd8d
remember previous priority boost request in imgRequest. r=tnikkel

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7f1f1559cd8d