provide infrastructure to boost image loading priority by category

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: schien, Assigned: schien)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8859057 [details]
Bug 1357318 - remember previous priority boost request in imgRequest.

https://reviewboard.mozilla.org/r/131088/#review134732

::: image/imgIRequest.idl:212
(Diff revision 1)
>     * @see Image::DecrementAnimationConsumers for documentation of the
>     * underlying call.
>     */
>    void decrementAnimationConsumers();
> +
> +  const uint32_t CATEGORY_FRAME_INIT = 1 << 0;

Please add a comment describing what each category name means.

::: image/imgRequest.h:282
(Diff revision 1)
>    // The Referrer Policy (defined in ReferrerPolicy.h) used for this image.
>    ReferrerPolicy mReferrerPolicy;
>  
>    nsresult mImageErrorCode;
>  
> +  uint32_t mRequestedBoostCategory = 0;

mBoostCategoriesRequested?
Attachment #8859057 - Flags: review?(tnikkel) → review+
Comment hidden (mozreview-request)

Comment 4

a year ago
Pushed by schien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7f1f1559cd8d
remember previous priority boost request in imgRequest. r=tnikkel

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7f1f1559cd8d
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.