1312779 - Continue the Beta 50 add-ons e10s targeting criteria into 50 release

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[:shell escalante]

Despite not having the 2 uplifts - we want to continue the experiment into 50 release.  This is based on the metrics we saw from Beta being good.  

We are looking now to see if there are other measurements we should be looking at for start up time - but do not see a reason not to continue to release with the beta targets.

specific add-ons can be disabled if they cause problems - though Felipe noted that only 55% of users get over the air system updates.

so this is all MPC=true, all webextensions, the few specified in bug (for test pilot, etc) that are neither MPC=true or webextensions, & blocking tab-mix-plus (which is MPC=true but has issues still)

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1312779 - Enable e10s with all mpc=true addons.

Review commit: https://reviewboard.mozilla.org/r/89350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89350/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8805594 [details]
Bug 1312779 - Enable e10s with all mpc=true addons.

https://reviewboard.mozilla.org/r/89350/#review88582

\o/

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8805594 [details]
Bug 1312779 - Enable e10s with all mpc=true addons.

https://reviewboard.mozilla.org/r/89350/#review88584

Oh - don't forget to bump the install.rdf version!

Comment 4

[:Felipe Gomes (needinfo for replies!)]

(In reply to Mike Conley (:mconley) - (digging out of review / needinfo backlog) from comment #3)
> Comment on attachment 8805594 [details]
> Bug 1312779 - Enable e10s with all mpc=true addons.
> 
> https://reviewboard.mozilla.org/r/89350/#review88584
> 
> Oh - don't forget to bump the install.rdf version!

* sigh *
every time!

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8805594 [details]
Bug 1312779 - Enable e10s with all mpc=true addons.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/89350/diff/1-2/

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8805594 [details]
Bug 1312779 - Enable e10s with all mpc=true addons.

Approval Request Comment
[Feature/regressing bug #]: Configure firefox release to use the same e10s-addons policy as what was tested during beta.
[User impact if declined]:  Firefox 50 will continue to use the same list of whitelisted add-ons for e10s as Firefox 49.  The current goal is to enable all add-ons which have explicitly marked themselves as multiprocessCompatible, which will bump the number of e10s-addons users from 3% to 6% on release.
[Describe test coverage new/current, TreeHerder]: Tested during the entire beta cycle on the beta channel
[Risks and why]: The risk inherent from allowing more add-ons to run with e10s
[String/UUID change made/needed]: none

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Heads up that it looks like this didn't autoland properly.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f069d69f1a18
Enable e10s with all mpc=true addons. r=mconley

Comment 9

[:Felipe Gomes (needinfo for replies!)]

Thanks for the heads up, Mike. This was due to a merge conflict with bug 1301131, which had been backed out from beta (where I wrote my patch), but not on central/aurora. I backed it out from everything to facilitate merging this one tomorrow.

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 8805594 [details]
Bug 1312779 - Enable e10s with all mpc=true addons.

e10s enablement for mpc addons on 50 release, this should be in the first rc build

Comment 11

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/961a6a6ec790771e5d2c372d34817ebda3e0ca81
https://hg.mozilla.org/releases/mozilla-beta/rev/d7598ee90bc6085d430b2e9e75c13358ef00a5f4

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f069d69f1a18