1313169 - Remove dom/inputmethod/ and related code

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

B2G-related code gets removed from mozilla-central, see bug 1306391.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 5/2-5/10)]

mds:

Are you working on this? If no, I'd like to do this because fixing this bug makes patches for my P1 bug simpler. So, if you need more time to remove it, I'd like to do this.

Comment 2

[Michelangelo De Simone [Offline] [:mds]]

(In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #1)

> Are you working on this? If no, I'd like to do this because fixing this bug
> makes patches for my P1 bug simpler. So, if you need more time to remove it,
> I'd like to do this.

I'm waiting for another couple of patches to land then I'll move to this (probably a couple of days).
Of course, if it's urgent I'm totally in for you to take it off my table.:-)

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 5/2-5/10)]

Okay, no problem. My bug 1322736 will remove before/after keyboard events. So, it may conflict with your patch at PresShell, be careful.

Comment 4

[Michelangelo De Simone [Offline] [:mds]]

Attachment: Bug 1313169 - Remove dom/inputmethod/ and related code.

Review commit: https://reviewboard.mozilla.org/r/100332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100332/

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 5/2-5/10)]

You should remove following code too:
PresShell::IsTargetIframe()
PresShell::HandleKeyboardEvent() (needs to change the caller, PresShell::DispatchEventToDOM())
PresShell::ForwardKeyToInputMethodApp()
PresShell::ForwardKeyToInputMethodAppOrDispatch()
nsIPresShell::mHardwareKeyHandler
nsIHardwareKeyHandler related code in nsLayoutModule.cpp

Comment 6

[(no longer active)]

Comment on attachment 8820941 [details]
Bug 1313169 - Remove dom/inputmethod/ and related code.

https://reviewboard.mozilla.org/r/100332/#review101116

Thanks, looks good!  But please file a follow-up for comment 5 too.

Comment 7

[Michelangelo De Simone [Offline] [:mds]]

Comment on attachment 8820941 [details]
Bug 1313169 - Remove dom/inputmethod/ and related code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/100332/diff/1-2/

Comment 8

[Michelangelo De Simone [Offline] [:mds]]

(In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #5)

> You should remove following code too:
> ...snip...

Thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d116e76778e6
Remove dom/inputmethod/ and related code. r=Ehsan

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d116e76778e6

Comment 11

[Chris Mills [:cmills]]

Adding ddn, just to check the docs for this.

Comment 12

[Chris Mills [:cmills]]

I've checked this out; we never documented InputMethod, and I've deleted the setInputMethodActive() method page and added a note to the Fx53 rel notes:

https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement
https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement/setInputMethodActive
https://developer.mozilla.org/en-US/Firefox/Releases/53

Let me know if that looks OK. Thanks!