Closed Bug 1313169 Opened 3 years ago Closed 3 years ago

Remove dom/inputmethod/ and related code

Categories

(Core :: DOM: Core & HTML, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: aryx, Assigned: mds)

References

(Blocks 2 open bugs)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

B2G-related code gets removed from mozilla-central, see bug 1306391.
Priority: -- → P3
Assignee: nobody → mdesimone
See Also: → 983015
mds:

Are you working on this? If no, I'd like to do this because fixing this bug makes patches for my P1 bug simpler. So, if you need more time to remove it, I'd like to do this.
Depends on: 1322736
Flags: needinfo?(mdesimone)
(In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #1)

> Are you working on this? If no, I'd like to do this because fixing this bug
> makes patches for my P1 bug simpler. So, if you need more time to remove it,
> I'd like to do this.

I'm waiting for another couple of patches to land then I'll move to this (probably a couple of days).
Of course, if it's urgent I'm totally in for you to take it off my table.:-)
Flags: needinfo?(mdesimone)
Okay, no problem. My bug 1322736 will remove before/after keyboard events. So, it may conflict with your patch at PresShell, be careful.
You should remove following code too:
PresShell::IsTargetIframe()
PresShell::HandleKeyboardEvent() (needs to change the caller, PresShell::DispatchEventToDOM())
PresShell::ForwardKeyToInputMethodApp()
PresShell::ForwardKeyToInputMethodAppOrDispatch()
nsIPresShell::mHardwareKeyHandler
nsIHardwareKeyHandler related code in nsLayoutModule.cpp
Comment on attachment 8820941 [details]
Bug 1313169 - Remove dom/inputmethod/ and related code.

https://reviewboard.mozilla.org/r/100332/#review101116

Thanks, looks good!  But please file a follow-up for comment 5 too.
Attachment #8820941 - Flags: review?(ehsan) → review+
(In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #5)

> You should remove following code too:
> ...snip...

Thanks!
Pushed by mdesimone@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d116e76778e6
Remove dom/inputmethod/ and related code. r=Ehsan
https://hg.mozilla.org/mozilla-central/rev/d116e76778e6
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
No longer blocks: 1369194
Adding ddn, just to check the docs for this.
Keywords: dev-doc-needed
I've checked this out; we never documented InputMethod, and I've deleted the setInputMethodActive() method page and added a note to the Fx53 rel notes:

https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement
https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement/setInputMethodActive
https://developer.mozilla.org/en-US/Firefox/Releases/53

Let me know if that looks OK. Thanks!
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.