Drop before and after keydown, keyup events

RESOLVED FIXED in Firefox 53

Status

()

defect
RESOLVED FIXED
2 years ago
a month ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

(Blocks 2 bugs)

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(4 attachments)

For supporting physical keyboard with IME apps on B2G, we implemented before/after keydown/keyup events for supporting embedding web apps. However, according to gfx guys, they've already removed the code for B2G. So, we don't need to keep this very complicated feature which never runs our product actually.

Note that when I fix bug 1257617, keyboard events will be fired in remote process first. So, some of this feature will be reimplemented for e10s.
Comment hidden (mozreview-request)
I wonder, probably, we can drop IME support of B2G completely and also dom/inputmehtod itself.

Comment 10

2 years ago
mozreview-review
Comment on attachment 8820135 [details]
Bug 1322736 part.1 Remove "before keydown" and "before keyup" events

https://reviewboard.mozilla.org/r/99678/#review100132
Attachment #8820135 - Flags: review?(bugs) → review+

Comment 11

2 years ago
mozreview-review
Comment on attachment 8820136 [details]
Bug 1322736 part.2 Remove "after keydown" and "after keyup" events

https://reviewboard.mozilla.org/r/99680/#review100136
Attachment #8820136 - Flags: review?(bugs) → review+

Comment 12

2 years ago
mozreview-review
Comment on attachment 8820137 [details]
Bug 1322736 part.3 Remove dom::BeforeAfterKeyboardEvent and InternalBeforeAfterKeyboardEvent

https://reviewboard.mozilla.org/r/99682/#review100138
Attachment #8820137 - Flags: review?(bugs) → review+

Comment 13

2 years ago
mozreview-review
Comment on attachment 8820138 [details]
Bug 1322736 part.4 Remove pref to enable BeforeAfterKeyboardEvent and permission to allow to handle the event

https://reviewboard.mozilla.org/r/99684/#review100140
Attachment #8820138 - Flags: review?(bugs) → review+

Comment 14

2 years ago
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/c7e1c554e15f
part.1 Remove "before keydown" and "before keyup" events r=smaug
https://hg.mozilla.org/integration/autoland/rev/5506b339ec9c
part.2 Remove "after keydown" and "after keyup" events r=smaug
https://hg.mozilla.org/integration/autoland/rev/7b39662d8bc1
part.3 Remove dom::BeforeAfterKeyboardEvent and InternalBeforeAfterKeyboardEvent r=smaug
https://hg.mozilla.org/integration/autoland/rev/91e4d7e9bcf2
part.4 Remove pref to enable BeforeAfterKeyboardEvent and permission to allow to handle the event r=smaug
Component: Event Handling → User events and focus handling
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.