Closed
Bug 1322736
Opened 7 years ago
Closed 7 years ago
Drop before and after keydown, keyup events
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Core
DOM: UI Events & Focus Handling
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
For supporting physical keyboard with IME apps on B2G, we implemented before/after keydown/keyup events for supporting embedding web apps. However, according to gfx guys, they've already removed the code for B2G. So, we don't need to keep this very complicated feature which never runs our product actually. Note that when I fix bug 1257617, keyboard events will be fired in remote process first. So, some of this feature will be reimplemented for e10s.
|
Assignee | |
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dfc2e6ee34d7
|
|
Assignee | |
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=319af9b20139
|
|
Assignee | |
Comment 3•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=42cbf8901e87
|
|
Assignee | |
Comment 4•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d33b1b1ffa1
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 9•7 years ago
|
||
I wonder, probably, we can drop IME support of B2G completely and also dom/inputmehtod itself.
|
||
Comment 10•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8820135 [details] Bug 1322736 part.1 Remove "before keydown" and "before keyup" events https://reviewboard.mozilla.org/r/99678/#review100132
Attachment #8820135 -
Flags: review?(bugs) → review+
|
|
||
Comment 11•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8820136 [details] Bug 1322736 part.2 Remove "after keydown" and "after keyup" events https://reviewboard.mozilla.org/r/99680/#review100136
Attachment #8820136 -
Flags: review?(bugs) → review+
|
|
||
Comment 12•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8820137 [details] Bug 1322736 part.3 Remove dom::BeforeAfterKeyboardEvent and InternalBeforeAfterKeyboardEvent https://reviewboard.mozilla.org/r/99682/#review100138
Attachment #8820137 -
Flags: review?(bugs) → review+
|
|
||
Comment 13•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8820138 [details] Bug 1322736 part.4 Remove pref to enable BeforeAfterKeyboardEvent and permission to allow to handle the event https://reviewboard.mozilla.org/r/99684/#review100140
Attachment #8820138 -
Flags: review?(bugs) → review+
|
||
Comment 14•7 years ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/c7e1c554e15f part.1 Remove "before keydown" and "before keyup" events r=smaug https://hg.mozilla.org/integration/autoland/rev/5506b339ec9c part.2 Remove "after keydown" and "after keyup" events r=smaug https://hg.mozilla.org/integration/autoland/rev/7b39662d8bc1 part.3 Remove dom::BeforeAfterKeyboardEvent and InternalBeforeAfterKeyboardEvent r=smaug https://hg.mozilla.org/integration/autoland/rev/91e4d7e9bcf2 part.4 Remove pref to enable BeforeAfterKeyboardEvent and permission to allow to handle the event r=smaug
|
||
Comment 15•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c7e1c554e15f https://hg.mozilla.org/mozilla-central/rev/5506b339ec9c https://hg.mozilla.org/mozilla-central/rev/7b39662d8bc1 https://hg.mozilla.org/mozilla-central/rev/91e4d7e9bcf2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
||
Updated•4 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•