|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
58 bytes, text/x-review-board-request
|Details | Review|
I noticed that `SocialShare.sharePage` sends several messages to a specific tab's browser with `gBrowser.selectedBrowser.messageManager`, but then waits for a reply using the browser window message manager. As far as I can tell, it would be safe to listen for a reply on the same message manager used to send. Also, the current version happens to fail to collect page content when the Responsive Design Mode that I am working on for DevTools is used. Switching to the browser specific MM for replies resolves this issue.
Comment on attachment 8804995 [details] Bug 1313290 - Use tab specific MM in SocialShare.sharePage. https://reviewboard.mozilla.org/r/88800/#review87972 LGTM, assuming tests pass ship it!
Attachment #8804995 - Flags: review?(mixedpuppy) → review+
Thanks for the quick review!
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/6ca6314d95c2 Use tab specific MM in SocialShare.sharePage. r=mixedpuppy
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.