Closed Bug 1313322 Opened 5 years ago Closed 5 years ago

Allow mp3 sound files for OS X notifications

Categories

(Thunderbird :: OS Integration, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 52.0

People

(Reporter: aleth, Assigned: aleth)

References

Details

Attachments

(1 file)

In the process of bug 947776, it was noticed that TB doesn't allow selecting mp3 files on this platform, but playing a mp3 file seems to be supported by the underlying code.
This seems to work. Unfortunately I couldn't find a list of supported file formats - maybe I was looking in the wrong place?
Attachment #8805072 - Flags: review?(richard.marti)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment on attachment 8805072 [details] [diff] [review]
Allow mp3 sound files for OS X notifications

I suppose you tested it. rs=me
Attachment #8805072 - Flags: review?(richard.marti) → review+
Comment on attachment 8805072 [details] [diff] [review]
Allow mp3 sound files for OS X notifications

Review of attachment 8805072 [details] [diff] [review]:
-----------------------------------------------------------------

From the documentation on Apple, there doesn't seem to be any kind of restriction on the file formats supported by the NSUserNotification API. Right now we are still not using it to customize the sound played along the alert. However, as have been tested with an .mp3 and it worked, there seems to be no problem for the operating system to play .MP3 files when Mozilla toolkit asks it.
Attachment #8805072 - Flags: feedback+
(In reply to aleth [:aleth] from comment #1)
> Created attachment 8805072 [details] [diff] [review]
> Allow mp3 sound files for OS X notifications
> 
> This seems to work. Unfortunately I couldn't find a list of supported file
> formats - maybe I was looking in the wrong place?

Those file formats would be https://developer.apple.com/library/content/documentation/MusicAudio/Conceptual/CoreAudioOverview/SupportedAudioFormatsMacOSX/SupportedAudioFormatsMacOSX.html, I suppose, as they are the natively supported sound file formats by macOS. I haven't tested them.
https://hg.mozilla.org/comm-central/rev/da656d21e8701d1040ee392c290259fbded49bdc
Bug 1313322 - Allow mp3 sound files for OS X notifications. r=paenglab
(In reply to Javi Rueda from comment #4)
> Those file formats would be
> https://developer.apple.com/library/content/documentation/MusicAudio/
> Conceptual/CoreAudioOverview/SupportedAudioFormatsMacOSX/
> SupportedAudioFormatsMacOSX.html, I suppose, as they are the natively
> supported sound file formats by macOS. I haven't tested them.

Good to know, thanks! I only tested mp3 though.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
You need to log in before you can comment on or make changes to this bug.