1313451 - Intermittent testGeckoRequest | application crashed [@ Zip::GetStream]

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Treeherder Bug Filer]

Filed by: rvandermeulen [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=3989587&repo=mozilla-aurora

https://archive.mozilla.org/pub/mobile/tinderbox-builds/mozilla-aurora-android-api-15/1477580794/mozilla-aurora_ubuntu64_vm_armv7_mobile_test-robocop-4-bm51-tests1-linux64-build44.txt.gz

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Eugen, is this something you'd have cycles to look at?

Comment 2

[Eugen Sawin [:esawin]]

This is interesting and it seems to have a useful stack.
Will take a look.

Comment 3

[Eugen Sawin [:esawin]]

This might be related to bug 849589, bug 881564 and others which all seem to hit the "impossible" case which produces the following log:

11-03 15:22:45.581 28221 28238 E GeckoLinker: Not a seekable zstream
11-03 15:22:45.581 28221 28238 E GeckoLinker: Couldn't initialize SeekableZStream for libxul.so
11-03 15:22:45.581 28221 28238 E GeckoLinker: Not a seekable zstream
11-03 15:22:45.581 28221 28238 E GeckoLibLoad: Couldn't get a handle to libxul!
11-03 15:22:45.581 28221 28238 E GeckoLibLoad: Throw
11-03 15:22:45.583 28221 28221 D GeckoNetworkManager: New network state: UP, CELLULAR, CELL_2G
11-03 15:22:45.583 28221 28236 E GeckoJarReader: !!! BUG 849589 !!! origUrl=jar:jar:file:/data/app/org.mozilla.fennec-1/base.apk!/assets/omni.ja!/chrome/de-DE/locale/de-DE/browser/searchplugins/list.txt
11-03 15:22:45.583 28221 28236 E GeckoJarReader: java.lang.IllegalArgumentException: Got class java.util.zip.InflaterInputStream, but expected ByteBufferInputStream!

Comment 4

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1313451-1.0-Make-Zip-thread-safe.-r-glandium.patch

Since we can rule out a build issue (we would see this error more consistently in this case) something about the way we iterate through a zip directory must be broken.

For one, Zip::GetStream isn't thread safe although zips are "cached" and shared across threads now.

With this patch, we make Zip thread-safe by locking all access to nextFile, nextDir and entries members.

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8809486 [details] [diff] [review]
0001-Bug-1313451-1.0-Make-Zip-thread-safe.-r-glandium.patch

Review of attachment 8809486 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozglue/linker/Zip.cpp
@@ +65,4 @@
>  , nextDir(nullptr)
>  , entries(nullptr)
>  {
> +  pthread_mutex_init(&mutex, 0);

Please use nullptr.

Comment 6

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1313451-1.1-Make-Zip-thread-safe.-r-glandium.patch

Addressed comment.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bfd5335fa635
[1.1] Make Zip thread-safe. r=glandium

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bfd5335fa635

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 10

[Eugen Sawin [:esawin]]

Comment on attachment 8809781 [details] [diff] [review]
0001-Bug-1313451-1.1-Make-Zip-thread-safe.-r-glandium.patch

Approval Request Comment
[Feature/regressing bug #]: Native linker/zip reader.
[User impact if declined]: Crash on startup.
[Describe test coverage new/current, TreeHerder]: Nightly.
[Risks and why]: Minimal, it just adds mutex guards around some variable access.
[String/UUID change made/needed]: None.

Comment 11

[Gerry Chang [:gchang]]

Comment on attachment 8809781 [details] [diff] [review]
0001-Bug-1313451-1.1-Make-Zip-thread-safe.-r-glandium.patch

Fix an intermittent-failure. Beta51+ and Aurora52+. Should be in 51 beta 2.

Comment 12

[Gerry Chang [:gchang]]

Comment on attachment 8809781 [details] [diff] [review]
0001-Bug-1313451-1.1-Make-Zip-thread-safe.-r-glandium.patch

It's already fixed in 52. No need to uplift to Aurora52.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/115cc4b13d7e