Closed Bug 1313518 Opened 3 years ago Closed 3 years ago

Distorted video (wrong stride?) on Apples Macbook Pro website / when video width is not aligned to 32 with BasicCompositor

Categories

(Core :: Graphics: Layers, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox49 --- unaffected
firefox50 --- unaffected
firefox51 + fixed
firefox52 + fixed

People

(Reporter: mstange, Assigned: sotaro)

References

Details

(Keywords: regression)

Attachments

(3 files, 3 obsolete files)

On Nightly, the contents of the first Macbook Pro screen on http://www.apple.com/macbook-pro/ are distorted. They're applying a mask image / clip path to the video, which means that it's going to be rendered on the main thread in Firefox.
Attached video video file
Attached file testcase
[Tracking Requested - why for this release]: regression

This is a regression from bug 1273823.
Blocks: 1273823
Flags: needinfo?(sotaro.ikeda.g)
Assignee: nobody → sotaro.ikeda.g
Yea, I confirmed the problem on my mac book pro. Stride calculation seems wrong with the video.
Flags: needinfo?(sotaro.ikeda.g)
Attached patch patch - Handle alignment of 32 (obsolete) — Splinter Review
attachment 8805477 [details] [diff] [review] addressed the problem on my mac book pro. Before bug 1273823 fix, data source's stride was handled as aligned to 32.
Attachment #8805477 - Flags: review?(nical.bugzilla)
Attachment #8805477 - Flags: review?(nical.bugzilla) → review+
Component: Audio/Video → Audio/Video: Playback
Tracking 52+ for this regression so we can correct stride circulation.
Flags: in-testsuite?
Summary: Distorted video (wrong stride?) on Apples Macbook Pro website / when drawing video on the main thread → Distorted video (wrong stride?) on Apples Macbook Pro website / when video width is not aligned to 32 with BasicCompositor
Component: Audio/Video: Playback → Graphics: Layers
Backed out for failing gl tests test_conformance__textures__misc__texture-npot-video.html and test_2_conformance__textures__video__tex-2d-rgb-rgb-unsigned_byte.html, and dom/media/test/test_bug879717.html:

https://hg.mozilla.org/integration/mozilla-inbound/rev/15bfa2b75e1bada9920d9d7dfe0522c845d1d057

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=9b5b04d1a15a7c238fe40093f5167dcab34e5ef2
Please check the gl and mda logs on OS X. There might be more failing tests than in the commit message.
Flags: needinfo?(sotaro.ikeda.g)
Duplicate of this bug: 1313444
Track 51+ as regression.
Hmm, we might need to limit optimization path only when width is aligned to 32.
Flags: needinfo?(sotaro.ikeda.g)
(In reply to Sotaro Ikeda [:sotaro] from comment #12)
> Hmm, we might need to limit optimization path only when width is aligned to
> 32.

Data is aligned to 32, but the data might not be mapped correctly.
Attachment #8805477 - Attachment is obsolete: true
(In reply to Sotaro Ikeda [:sotaro] from comment #13)
> (In reply to Sotaro Ikeda [:sotaro] from comment #12)
> > Hmm, we might need to limit optimization path only when width is aligned to
> > 32.
> 
> Data is aligned to 32, but the data might not be mapped correctly.

And current libyuv seems to have a problem around crop handling. attachment 8806586 [details] [diff] [review] is going to bypass it for now.
Attachment #8806586 - Flags: review?(nical.bugzilla)
Attachment #8806586 - Flags: review?(nical.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/93515fab001d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Hi :sotaro,
Since this is a regression in 51, do you think the patch is worth uplifting to 51?
Flags: needinfo?(sotaro.ikeda.g)
Comment on attachment 8806586 [details] [diff] [review]
patch - Revert Bug 1273823 if width is not aligned to 32

Approval Request Comment
[Feature/regressing bug #]: bug 1273823
[User impact if declined]: Some h264 video is not rendered correctly when BasicCompsitor is used.
[Describe test coverage new/current, TreeHerder]: locally tested.
[Risks and why]: Low. The patch just partially back-out bug 1273823 fix.
[String/UUID change made/needed]: none.
Flags: needinfo?(sotaro.ikeda.g)
Attachment #8806586 - Flags: approval-mozilla-aurora?
Comment on attachment 8806586 [details] [diff] [review]
patch - Revert Bug 1273823 if width is not aligned to 32

Fix a regression related to video rendering. This will affect user experiences. Take it in 51 aurora.
Attachment #8806586 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attached file xss.html (obsolete) —
Attached file xss.html (obsolete) —
Comment on attachment 8866270 [details]
xss.html

(marking unrelated xss.html files as obsolete)
Attachment #8866270 - Attachment is obsolete: true
Attachment #8866272 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.