Closed Bug 1313626 Opened 3 years ago Closed 3 years ago

Clean up more issues found by eslint no-undef rule


(Firefox :: General, defect)

Not set



Firefox 52
Tracking Status
firefox52 --- fixed


(Reporter: standard8, Assigned: standard8)




(1 file)

Scanning through the current browser/ errors raised when no-undef is enabled, there's a few obvious things that we can do:

- Add .eslintrc.js to some more test directories.
- Fix various minor errors raised by the no-undef rule. Only one of these would have been an actual issue (in translation.js) however that code is not enabled by default at the moment.
Additional note: domplate_test.js seemed to be for domplate.jsm which has been removed from the tree (not sure when).

Also the two "global sinon" additions in the head.js files for syncedtabs mean that sinon gets defined - we don't currently handle loader.loadSubScript so this seems a resonable work around for now.
I've just added a couple more global definitions from the testing/xpcshell/head.js.

Overall this patch resolves about 2740 undef errors out of 7779 in browser/. I think that's mainly due to the addition of the .eslintrc.js files.
Comment on attachment 8805519 [details]
Bug 1313626 - Clean up more issues found by eslint no-undef rule.

Straightforward enough. Some nice catches in here.
Attachment #8805519 - Flags: review?(dtownsend) → review+
Pushed by
Clean up more issues found by eslint no-undef rule. r=mossop
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.