Clean up more issues found by eslint no-undef rule

RESOLVED FIXED in Firefox 52

Status

()

Firefox
General
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
Firefox 52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Scanning through the current browser/ errors raised when no-undef is enabled, there's a few obvious things that we can do:

- Add .eslintrc.js to some more test directories.
- Fix various minor errors raised by the no-undef rule. Only one of these would have been an actual issue (in translation.js) however that code is not enabled by default at the moment.
(Assignee)

Comment 1

a year ago
Additional note: domplate_test.js seemed to be for domplate.jsm which has been removed from the tree (not sure when).

Also the two "global sinon" additions in the head.js files for syncedtabs mean that sinon gets defined - we don't currently handle loader.loadSubScript so this seems a resonable work around for now.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 4

a year ago
I've just added a couple more global definitions from the testing/xpcshell/head.js.

Overall this patch resolves about 2740 undef errors out of 7779 in browser/. I think that's mainly due to the addition of the .eslintrc.js files.

Comment 5

a year ago
mozreview-review
Comment on attachment 8805519 [details]
Bug 1313626 - Clean up more issues found by eslint no-undef rule.

https://reviewboard.mozilla.org/r/89268/#review88536

Straightforward enough. Some nice catches in here.
Attachment #8805519 - Flags: review?(dtownsend) → review+

Comment 6

a year ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a3937bf608bc
Clean up more issues found by eslint no-undef rule. r=mossop

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a3937bf608bc
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.