1313626 - Clean up more issues found by eslint no-undef rule

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mark Banner (:standard8)]

Scanning through the current browser/ errors raised when no-undef is enabled, there's a few obvious things that we can do:

- Add .eslintrc.js to some more test directories.
- Fix various minor errors raised by the no-undef rule. Only one of these would have been an actual issue (in translation.js) however that code is not enabled by default at the moment.

Comment 1

[Mark Banner (:standard8)]

Additional note: domplate_test.js seemed to be for domplate.jsm which has been removed from the tree (not sure when).

Also the two "global sinon" additions in the head.js files for syncedtabs mean that sinon gets defined - we don't currently handle loader.loadSubScript so this seems a resonable work around for now.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1313626 - Clean up more issues found by eslint no-undef rule.

Review commit: https://reviewboard.mozilla.org/r/89268/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89268/

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8805519 [details]
Bug 1313626 - Clean up more issues found by eslint no-undef rule.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/89268/diff/1-2/

Comment 4

[Mark Banner (:standard8)]

I've just added a couple more global definitions from the testing/xpcshell/head.js.

Overall this patch resolves about 2740 undef errors out of 7779 in browser/. I think that's mainly due to the addition of the .eslintrc.js files.

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8805519 [details]
Bug 1313626 - Clean up more issues found by eslint no-undef rule.

https://reviewboard.mozilla.org/r/89268/#review88536

Straightforward enough. Some nice catches in here.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3937bf608bc
Clean up more issues found by eslint no-undef rule. r=mossop

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a3937bf608bc