Closed Bug 1313634 Opened 3 years ago Closed 3 years ago

Fix undefined variables issues in cookies.js that lead to the cookies window not updating properly when open

Categories

(Firefox :: Preferences, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 52
Tracking Status
firefox49 --- unaffected
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Keywords: regression)

Attachments

(1 file)

STR (latest nightly)

- Open preferences, go to privacy, and select "Remove individual cookies"

=> Cookies panel opens

- Expand a cookie from a site.

- Open a new window.
- Load a page for the cookie's site to update the cookie.

Actual Results

=> Page loads fine, error on the console, cookie list doesn't update. Console error is:

TypeError: this._hostsOrder is undefined cookies.js:132:1

Expected Results

=> Page loads fine, no errors on console. Cookie list updates.

Regression from bug 1295000. Unfortunately I didn't spot breakage in how the loops were working.
Comment on attachment 8805518 [details]
Bug 1313634 - Fix undefined variables issues in cookies.js that lead to the cookies window not updating properly when open.

https://reviewboard.mozilla.org/r/89264/#review88576

::: browser/components/preferences/cookies.js:132
(Diff revision 1)
> -      for (let host of this._hostsOrder) { // (var host in this._hosts) {
> +      for (let host of this._hostOrder) { // (var host in this._hosts) {
>          ++rowIndex;
>          var hostItem = this._hosts[host];
> -        if (this._hostOrder[i] == strippedHost) { // host == strippedHost) {
> +        if (host == strippedHost) { // host == strippedHost) {

Can you remove the commented out code here? It's just carryover at this point and is confusing on editors that don't do syntax higlighting.
Attachment #8805518 - Flags: review?(jaws) → review+
Comment on attachment 8805518 [details]
Bug 1313634 - Fix undefined variables issues in cookies.js that lead to the cookies window not updating properly when open.

https://reviewboard.mozilla.org/r/89264/#review88576

> Can you remove the commented out code here? It's just carryover at this point and is confusing on editors that don't do syntax higlighting.

Yes, dropped.
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/65d125cdc91a
Fix undefined variables issues in cookies.js that lead to the cookies window not updating properly when open. r=jaws
https://hg.mozilla.org/mozilla-central/rev/65d125cdc91a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.