Closed Bug 1313772 Opened 8 years ago Closed 7 years ago

Intermittent /reftests/w3c-css/submitted/ui3/box-sizing-replaced-002.xht == /reftest/tests/layout/reftests/w3c-css/submitted/ui3/box-sizing-replaced-002-ref.xht

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox52 --- fixed
firefox-esr52 --- fixed
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: neerja, Assigned: neerja)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed])

Attachments

(3 files)

Bug 1313772 - Part1:Create a copy of test box-sizing-relaced-002 to isolate successive changes from W3C reftests.
58 bytes, text/x-review-board-request
dholbert
: review+
Details
Bug 1313772 - Part2:Use non-standard MozReftestInvalidate event to avoid test failure when paint delay is reduced.
59 bytes, text/x-review-board-request
dholbert
: review+
Details
Bug 1313772 - Part3:Add extremely permissive fuzzy annotation for box-sizing-replaced-002.xht to prevent failures due to paint delay reduction.
59 bytes, text/x-review-board-request
dholbert
: review+
Details 
      No description provided.
Assignee: nobody → npancholi
Keywords: intermittent-failure
Summary: Intermittent file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/ui3/box-sizing-replaced-002.xht == file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/ui3/box-sizing-replaced-002-ref.xht → Intermittent /reftests/w3c-css/submitted/ui3/box-sizing-replaced-002.xht == /reftest/tests/layout/reftests/w3c-css/submitted/ui3/box-sizing-replaced-002-ref.xht
Depends on: 1283302
No longer depends on: 1283302
Blocks: 1283302
Comment on attachment 8805693 [details]
Bug 1313772 - Part1:Create a copy of test box-sizing-relaced-002 to isolate successive changes from W3C reftests.

https://reviewboard.mozilla.org/r/89404/#review88994
Attachment #8805693 - Flags: review?(mstange) → review+
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e52673f0abd
Add fuzzy annotation for box-sizing-replaced-002.xht in reftest.list. r=mstange
Assignee: npancholi → administration
https://hg.mozilla.org/mozilla-central/rev/9e52673f0abd
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
No longer blocks: 1283302
:jet, this bug really spiked in frequency last week (47 failures on linux), can you find someone to fix this bug this week?  With that frequency of failures this is a high frequency bug that we want to get resolved (fixed/disabled) within 2 weeks (i.e. end of the month)
Flags: needinfo?(bugs)
Neerja's having a look...
Flags: needinfo?(bugs) → needinfo?(npancholi)
(Looking at the reftest snapshot, this looks a lot like bug 1295466 -- the right half of one of the scaled images is just missing.  That means this is likely an artifact of the reftest harness forcing the page to paint before it's ready, IIRC.  So, I think we should use the same strategy we did there, and punt to bug 1316772 on potentially fixing this in general.)
Assignee: administration → npancholi
Flags: needinfo?(npancholi)
(In reply to Daniel Holbert [:dholbert] from comment #9)
> (Looking at the reftest snapshot, this looks a lot like bug 1295466 -- the
> right half of one of the scaled images is just missing.  That means this is
> likely an artifact of the reftest harness forcing the page to paint before
> it's ready, IIRC.  So, I think we should use the same strategy we did there,
> and punt to bug 1316772 on potentially fixing this in general.)

Thanks for taking a look at this Daniel! :)
Comment on attachment 8805693 [details]
Bug 1313772 - Part1:Create a copy of test box-sizing-relaced-002 to isolate successive changes from W3C reftests.

https://reviewboard.mozilla.org/r/89404/#review114326
Attachment #8805693 - Flags: review?(dholbert) → review+
Comment on attachment 8837773 [details]
Bug 1313772 - Part2:Use non-standard MozReftestInvalidate event to avoid test failure when paint delay is reduced.

https://reviewboard.mozilla.org/r/112784/#review114324

::: layout/reftests/bugs/reftest.list:1982
(Diff revision 1)
>  # different, but they should use the same button style and the background color
>  # should be same.  |fuzzy()| here allows the difference in border, but not
>  # background color.
>  fuzzy(255,1000) skip-if(!cocoaWidget) == 1294102-1.html 1294102-1-ref.html
>  random-if(Android) fuzzy-if(skiaContent,15,50) == 1295466-1.xhtml 1295466-1-ref.xhtml #bug 982547
> +fuzzy-if(Android,27,874) fuzzy-if(gtkWidget,14,29) == 1313772.xhtml 1313772-ref.xht # Bug 1128229

Pedantic nit:
This reftest.list addition probably really belongs in "part 1".

(Generally, when you create a new reftest, you should add it to reftest.list atomically in the same commit [perhaps with a temporary 'fails' or 'random' annotation, if the test doesn't pass until a later commit -- and then the later commit can remove that annotation as part of atomically fixing the test].  That way, it's less likely to accidentally end up in a state where the files exist but are not tracked in any manifest files.)

Anyway, probably not worth fixing here unless you'd like to, so feel free to leave this as-is.  Mostly mentioning for future reference.
Attachment #8837773 - Flags: review?(dholbert) → review+
Comment on attachment 8837774 [details]
Bug 1313772 - Part3:Add extremely permissive fuzzy annotation for box-sizing-replaced-002.xht to prevent failures due to paint delay reduction.

https://reviewboard.mozilla.org/r/112786/#review114328

One nit for commit message:
> Bug 1313772 - Part3:Add extremely permissible fuzzy annotation

s/permissible/permissive/

("permissible" sounds like "an annotation which is justified/allowed".  But I really think you mean "an annotation which *does allow all kinds of mismatch*", and "permissive" covers that concept a bit better than "permissible")
Attachment #8837774 - Flags: review?(dholbert) → review+
Try run for these patches looks good (except for linux64-stylo debug which seems to be unrelated):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ad838aa9f022c0434a08836239ad61c0af8908b
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/daffdceaf24f
Part1:Create a copy of test box-sizing-relaced-002 to isolate successive changes from W3C reftests. r=dholbert,mstange
https://hg.mozilla.org/integration/autoland/rev/f7a3830239f4
Part2:Use non-standard MozReftestInvalidate event to avoid test failure when paint delay is reduced. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/6a075aed2afb
Part3:Add extremely permissive fuzzy annotation for box-sizing-replaced-002.xht to prevent failures due to paint delay reduction. r=dholbert
status-firefox52: fixed → affected
status-firefox53: --- → affected
Target Milestone: mozilla52 → mozilla54
Whiteboard: [stockwell fixed]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: