1313921 - Opening a source in a view-source: tab still selects the debugger

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Tooru Fujisawa [:arai]]

Attachment: testcase that throws SyntaxError

(hit this while testing bug 1283712)

Steps to reproduce:
  1. Open Nightly 52.0a1 (2016-10-27) (64-bit) with clean profile, on OSX
  2. Open attached HTML file
  3. Open Web Console
  4. Click "a.html:10:2" link for "SyntaxError: missing name after . operator" log

Actual result:
  Debugger tab is opened but no source is shown

Expected result:
  Debugger bah is opened and source file is opened and line 10 is selected.

Looks like, this issue happens only with SyntaxError and some other errors while parsing.

Comment 1

[Tooru Fujisawa [:arai]]

(In reply to Tooru Fujisawa [:arai] from comment #0)
> Expected result:
>   Debugger bah is opened and source file is opened and line 10 is selected.

horrible typo :P
"Debugger *tab is ..."

Comment 2

[Tooru Fujisawa [:arai]]

looks like the Debugger tab doesn't show a source that hit an error while parsing.

Comment 3

[Lin Clark [:linclark]]

Thanks for filing this. I'm going to block turning on new console in Developer Edition on this, so it should be fixed in the next couple of weeks.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Hey Brian, this bug appears with the old frontend as weel, it's more a debugger issue.
I think it's safe to remove it from the blocker list of Bug 1308219, don't you think ?

Comment 5

[Brian Grinstead [:bgrins]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #4)
> Hey Brian, this bug appears with the old frontend as weel, it's more a
> debugger issue.
> I think it's safe to remove it from the blocker list of Bug 1308219, don't
> you think ?

Yes, I see the same behavior in the old and new frontends.  We should definitely fix it but I agree we don't need to block the new frontend specifically on it.

Comment 6

[Tooru Fujisawa [:arai]]

Can we just open view-source page in new tab with the line selected?
just like Firefox 49 does.

Comment 7

[Brian Grinstead [:bgrins]]

(In reply to Tooru Fujisawa [:arai] from comment #6)
> Can we just open view-source page in new tab with the line selected?
> just like Firefox 49 does.

In my local testing on trunk, it does open the view source window.  It also tries to navigate to the debugger unsuccessfully.  In fact, I think this is indeed related to the new debugger frontend since with the old frontend it seems to only open the view source window.

Comment 8

[Brian Grinstead [:bgrins]]

As far as I can tell this is an issue specifically introduced by the new UI.  How do you want to track work related to the new debugger UI and integrations with shared components (in this case source links)?

Comment 9

[Tooru Fujisawa [:arai]]

(In reply to Brian Grinstead [:bgrins] from comment #7)
> (In reply to Tooru Fujisawa [:arai] from comment #6)
> > Can we just open view-source page in new tab with the line selected?
> > just like Firefox 49 does.
> 
> In my local testing on trunk, it does open the view source window.

indeed, thank you for the info :)
So the remaining issue is that it opens debugger tab unnecessarily.

Comment 10

[James Long (:jlongster)]

(In reply to Brian Grinstead [:bgrins] from comment #8)
> As far as I can tell this is an issue specifically introduced by the new UI.
> How do you want to track work related to the new debugger UI and
> integrations with shared components (in this case source links)?

Right now we're using github, so let's move this issue over there. When we move more of our code over we'll need to figure out issue management.

Comment 11

[James Long (:jlongster)]

Actually, this bug might only be part of the mozilla-central integration. If so, this should stay on bugzilla as it only requires an m-c patch. I will look into this now.

Comment 12

[James Long (:jlongster)]

Attachment: 1313921.patch

Turns out this was a silly mistake, and an easy fix.

Comment 13

[Brian Grinstead [:bgrins]]

Comment on attachment 8815473 [details] [diff] [review]
1313921.patch

Review of attachment 8815473 [details] [diff] [review]:
-----------------------------------------------------------------

Nice

Comment 14

[Tooru Fujisawa [:arai]]

what's the state of this bug?
just needs someone who lands it?

Comment 15

[Nicolas Chevobbe [:nchevobbe]]

Let's see if https://bugzilla.mozilla.org/attachment.cgi?id=8815473 can be landed as is.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/95a48b58f7f8
Don't select the debugger if it can't open a source. r=bgrins

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/95a48b58f7f8

Comment 18

[Saheda Reza [:Antora]]

I have reproduced this bug on Firefox Nightly according to(2016-10-30)

Fixing bug is verified on Latest Nightly --- Build ID: (20170224030232),User Agent: Mozilla/5.0 (Windows NT 10.0; rv:54.0) Gecko/20100101 Firefox/54.0


Tested OS-- Windows10 32bit

Comment 19

[Julien Cristau [:jcristau]]

AIUI from comment 8 this bug only shows up with the new debugger which isn't enabled in 52 or 53, so setting status to disabled.