Closed Bug 1313991 Opened 3 years ago Closed 3 years ago

On emulator, JellyBeanAsyncCodec failed to dequeue input buffer.

Categories

(Core :: Audio/Video: Playback, defect, P3)

Unspecified
Android
defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: jhlin, Assigned: jhlin)

References

Details

Attachments

(1 file)

Current implementation uses 10ms timeout when dequeuing input buffer, but on ARM emulator (and potentially on slow devices) that's too short. To make sure all available buffers are dequeued, we should track number of dequeued buffers and keep trying when it's less than allocated buffers.
Blocks: 1311960
(In reply to John Lin [:jolin][:jhlin] from comment #0)
> Current implementation uses 10ms timeout when dequeuing input buffer, but on
> ARM emulator (and potentially on slow devices) that's too short. To make
> sure all available buffers are dequeued, we should track number of dequeued
> buffers and keep trying when it's less than allocated buffers.

 Turns out tracking number of buffers is not necessary. By polling all input buffers when possible and reorder some polling tasks, the issue went away on emulator.
Comment on attachment 8813531 [details]
Bug 1313991 - Rewrite input buffer polling logic.

https://reviewboard.mozilla.org/r/94982/#review95242
Attachment #8813531 - Flags: review?(esawin) → review+
Pushed by jolin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/82701190b854
Rewrite input buffer polling logic. r=esawin
https://hg.mozilla.org/mozilla-central/rev/82701190b854
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Assignee: nobody → jolin
You need to log in before you can comment on or make changes to this bug.