1313991 - On emulator, JellyBeanAsyncCodec failed to dequeue input buffer.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[John Lin [:jhlin][:jolin]]

Current implementation uses 10ms timeout when dequeuing input buffer, but on ARM emulator (and potentially on slow devices) that's too short. To make sure all available buffers are dequeued, we should track number of dequeued buffers and keep trying when it's less than allocated buffers.

Comment 1

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1313991 - Rewrite input buffer polling logic.

- poll all buffers when started or flushed.
- retry only for timed out.
- remove unnecessary polling

Review commit: https://reviewboard.mozilla.org/r/94982/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94982/

Comment 2

[John Lin [:jhlin][:jolin]]

(In reply to John Lin [:jolin][:jhlin] from comment #0)
> Current implementation uses 10ms timeout when dequeuing input buffer, but on
> ARM emulator (and potentially on slow devices) that's too short. To make
> sure all available buffers are dequeued, we should track number of dequeued
> buffers and keep trying when it's less than allocated buffers.

 Turns out tracking number of buffers is not necessary. By polling all input buffers when possible and reorder some polling tasks, the issue went away on emulator.

Comment 3

[Eugen Sawin [:esawin]]

Comment on attachment 8813531 [details]
Bug 1313991 - Rewrite input buffer polling logic.

https://reviewboard.mozilla.org/r/94982/#review95242

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82701190b854
Rewrite input buffer polling logic. r=esawin

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/82701190b854