1314145 - Setting theme.colors.toolbar to any value just applies white

Status: RESOLVED INVALID

(WebExtensions :: Frontend, defect, P3)

Description

[Tim Nguyen :ntim]

- Install https://github.com/nt1m/vivaldi-fox/tree/webextension on cedar
- Go to http://material.google.com
- The navbar should be light blue (same color as the web page header)


Seems like --tab-background-color is set to the value I want, but the Firefox toolbars just remain white.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Mike de Boer says that this will probably get fixed by the devedition theme bug, bug 1311352.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Hey Tim, now that bug 1311352 has landed can you see if this was fixed for you?

Comment 3

[Tim Nguyen :ntim]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> Hey Tim, now that bug 1311352 has landed can you see if this was fixed for
> you?

theme.colors.toolbar still does not work, but theme.colors.frame does work though.

Comment 4

[Mike de Boer [:mikedeboer]]

(In reply to Tim Nguyen :ntim (use needinfo?) from comment #3)
> theme.colors.toolbar still does not work, but theme.colors.frame does work
> though.

That's the idea, though. 'tab_text' is the magic property in the 'colors' section that will set the global text color in chrome. 'frame' sets the color of, well, the entire frame and 'toolbar_button' in the 'gradients' section of the manifest may be used to set the background color of the navbar, separately. Note that these colors need to be in the `[h, s, l]` format, with values 0 <= x <= 1.

Comment 5

[Mike de Boer [:mikedeboer]]

When in doubt, or looking for a good example, you can always check out the unit test that are in browser/components/extensions/test/browser/browser_ext_theme*.js.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Why did this get resolved invalid? Is it no longer reproducible? When closing bugs, please include some reasoning (a short one-sentence reasoning is often all that is necessary).

Comment 7

[Tim Nguyen :ntim]

theme.colors.toolbars now works properly in mozilla-central