Closed Bug 1314206 Opened 3 years ago Closed 3 years ago

[css-grid] Stretching the inline size of <button> grid items doesn't work

Categories

(Core :: Layout, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: mats, Assigned: mats)

References

Details

(Keywords: testcase)

Attachments

(4 files, 1 obsolete file)

Attached file Testcase
STR: load attached the testcase

EXPECTED RESULT: the blue and tan items should have stretched their width to 100px
(Similar to the block-axis stretch a little later in the same method if you want to compare them, only I skipped checking for unconstrained CB size since that never happens in the inline-axis.)
Attachment #8806557 - Flags: review?(dholbert)
s/StyleContext()->GetParent()/GetParent()->StyleContext()/
Attachment #8806557 - Attachment is obsolete: true
Attachment #8806557 - Flags: review?(dholbert)
Attachment #8806568 - Flags: review?(dholbert)
Comment on attachment 8806568 [details] [diff] [review]
part 1 - [css-grid] Stretch the inline size when requested, unless we're measuring the shrink-wrap size.

Review of attachment 8806568 [details] [diff] [review]:
-----------------------------------------------------------------

I was initially going to ask why this patch is only adding this for inline-axis sizes -- but now I see we *already have* an analogous chunk in this function for block-axis stretching. :)

r=me
Attachment #8806568 - Flags: review?(dholbert) → review+
(oh, you mentioned that in comment 1, too; I just didn't notice)
Comment on attachment 8806558 [details] [diff] [review]
part 2 - [css-grid] Don't check for unconstrained inline size since it never occurs (other than by accident).

Review of attachment 8806558 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8806558 - Flags: review?(dholbert) → review+
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1354f15ccab5
part 1 - [css-grid] Stretch the inline size when requested, unless we're measuring the shrink-wrap size.  r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/5eed1210b69a
part 2 - [css-grid] Don't check for unconstrained inline size since it never occurs (other than by accident).  r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/253395be59f6
part 3 - [css-grid] Reftests for <button> grid items.
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.