1314206 - [css-grid] Stretching the inline size of <button> grid items doesn't work

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Mats Palmgren (inactive)]

Attachment: Testcase

STR: load attached the testcase

EXPECTED RESULT: the blue and tan items should have stretched their width to 100px

Comment 1

[Mats Palmgren (inactive)]

Attachment: part 1 - [css-grid] Stretch the inline size when requested, unless we're measuring the shrink-wrap size.

(Similar to the block-axis stretch a little later in the same method if you want to compare them, only I skipped checking for unconstrained CB size since that never happens in the inline-axis.)

Comment 2

[Mats Palmgren (inactive)]

Attachment: part 2 - [css-grid] Don't check for unconstrained inline size since it never occurs (other than by accident).

Comment 3

[Mats Palmgren (inactive)]

Attachment: part 3 - [css-grid] Reftests for <button> grid items.

Comment 4

[Mats Palmgren (inactive)]

Attachment: part 1 - [css-grid] Stretch the inline size when requested, unless we're measuring the shrink-wrap size.

s/StyleContext()->GetParent()/GetParent()->StyleContext()/

Comment 5

[Daniel Holbert [:dholbert]]

Comment on attachment 8806568 [details] [diff] [review]
part 1 - [css-grid] Stretch the inline size when requested, unless we're measuring the shrink-wrap size.

Review of attachment 8806568 [details] [diff] [review]:
-----------------------------------------------------------------

I was initially going to ask why this patch is only adding this for inline-axis sizes -- but now I see we *already have* an analogous chunk in this function for block-axis stretching. :)

r=me

Comment 6

[Daniel Holbert [:dholbert]]

(oh, you mentioned that in comment 1, too; I just didn't notice)

Comment 7

[Daniel Holbert [:dholbert]]

Comment on attachment 8806558 [details] [diff] [review]
part 2 - [css-grid] Don't check for unconstrained inline size since it never occurs (other than by accident).

Review of attachment 8806558 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1354f15ccab5
part 1 - [css-grid] Stretch the inline size when requested, unless we're measuring the shrink-wrap size.  r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/5eed1210b69a
part 2 - [css-grid] Don't check for unconstrained inline size since it never occurs (other than by accident).  r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/253395be59f6
part 3 - [css-grid] Reftests for <button> grid items.

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1354f15ccab5
https://hg.mozilla.org/mozilla-central/rev/5eed1210b69a
https://hg.mozilla.org/mozilla-central/rev/253395be59f6