131430 - Issues with the version information resource of softokn3.dll

Status: RESOLVED FIXED

(NSS :: Build, defect, P1)

Description

[Wan-Teh Chang]

The good news is that softokn3.dll does have the proper
Windows version information resource, unlike its Unix
counterpart libsoftokn3.so (bug 131427).

The bad news is that I found two issues with its version
information.

1. The InternalName is "softoken3" and the OriginalFilename
is "softoken3.dll".  These should be "softokn3" and
"softokn3.dll".

2. The softokn3.dll in the mozilla0.9.9 build has the
FileDescription "NSS Builtin Crypto PKCS #11 Library for
Clients".  I found that this is because of the following
code in lib/softoken/softokn.rc:

#ifdef MOZ_CLIENT
#define MY_FILEDESCRIPTION "NSS Builtin Crypto PKCS #11 Library for Clients"
#else
#define MY_FILEDESCRIPTION "NSS Builtin Crypto PKCS #11 Library"
#endif

Bob, is this because we use different compile-time configuration
parameters for softoken when building for the Mozilla client (and
presumably for the other client applications)?  (See bug 123753.)

I am wondering if we should go one step further and use a
different file name for the clients' version of the softoken.
This will allow the installation of both versions of the
softoken in the same (system) directory.  On the other hand,
this will force us to continue to use that file name even
when we can use the same softoken for both servers and clients.

Comment 1

[Wan-Teh Chang]

Attachment: Patch to change "softoken" to "softokn" in internal name and original filename

Comment 2

[Robert Relyea]

if -DMOZ_CLIENT is defined, softoken has defines different hash table sizes. It
seemed prudent to have a different name show up in the strings for the shared
library.

There isn't a functional difference between the two versions, only a performance
issue.

If we rename it, we would end up propogating that change into nss3 proper,
necessitating different versions of nss3, then that would necessitate changes in
ssl3 and smime3.

I prefer to handle this longer term by having a single softokn3.dll and having a
config option which tell is whether or not too configure for server usage or
client usage.

Comment 3

[Wan-Teh Chang]

Patch checked into the tip of NSS.