Closed Bug 1314420 Opened 3 years ago Closed 3 years ago

Bad ifdef in all.js

Categories

(Core :: Networking, defect)

52 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: kats, Assigned: michal)

References

Details

(Whiteboard: [necko-active])

Attachments

(1 file)

Bug 444328 added this in all.js:

#ifdef XP_UNIX && !defined(XP_MACOSX)
pref("network.tcp.keepalive.probe_count", 4);
#endif

This syntax (#ifdef ... && ...) is bogus. In bug 1314133 comment 5 dvander found that it effectively evaluates to #if 0, so this code is probably not doing what it's supposed to.
Attached patch fixSplinter Review
Assignee: nobody → michal.novotny
Attachment #8806709 - Flags: review?(mcmanus)
Whiteboard: [necko-active]
Attachment #8806709 - Flags: review?(mcmanus) → review+
https://hg.mozilla.org/mozilla-central/rev/64451484e137
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.