Bad ifdef in all.js

RESOLVED FIXED in Firefox 52

Status

()

Core
Networking
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: kats, Assigned: michal)

Tracking

52 Branch
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [necko-active])

Attachments

(1 attachment)

Bug 444328 added this in all.js:

#ifdef XP_UNIX && !defined(XP_MACOSX)
pref("network.tcp.keepalive.probe_count", 4);
#endif

This syntax (#ifdef ... && ...) is bogus. In bug 1314133 comment 5 dvander found that it effectively evaluates to #if 0, so this code is probably not doing what it's supposed to.
(Assignee)

Comment 1

a year ago
Created attachment 8806709 [details] [diff] [review]
fix
Assignee: nobody → michal.novotny
Attachment #8806709 - Flags: review?(mcmanus)
(Assignee)

Updated

a year ago
Whiteboard: [necko-active]
Attachment #8806709 - Flags: review?(mcmanus) → review+

Comment 3

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/64451484e137
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.