Closed
Bug 1314420
Opened 9 years ago
Closed 9 years ago
Bad ifdef in all.js
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: kats, Assigned: michal)
References
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
|
1.13 KB,
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
Bug 444328 added this in all.js:
#ifdef XP_UNIX && !defined(XP_MACOSX)
pref("network.tcp.keepalive.probe_count", 4);
#endif
This syntax (#ifdef ... && ...) is bogus. In bug 1314133 comment 5 dvander found that it effectively evaluates to #if 0, so this code is probably not doing what it's supposed to.
|
Assignee | |
Comment 1•9 years ago
|
||
Assignee: nobody → michal.novotny
Attachment #8806709 -
Flags: review?(mcmanus)
|
|
Assignee | |
Updated•9 years ago
|
Whiteboard: [necko-active]
|
||
Updated•9 years ago
|
Attachment #8806709 -
Flags: review?(mcmanus) → review+
Pushed by mnovotny@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/64451484e137
Bad ifdef in all.js, r=mcmanus
|
||
Comment 3•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•