1314133 - Enable the GPU process in nightly, on Windows

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

This will just be for Nightly, and only for Windows users.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch

Enables out-of-process compositing for Nightly users that meet the following conditions:
 (1) Use Windows 7 with the Platform Update, or higher, and
 (2) Are able to use Direct3D 11 compositing.

Intent is not to check this in until blocking bugs are fixed.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8806109 [details] [diff] [review]
patch

Review of attachment 8806109 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpref/init/all.js
@@ +4533,5 @@
>  // Preference that when switched at runtime will run a series of benchmarks
>  // and output the result to stderr.
>  pref("layers.bench.enabled", false);
>  
> +#ifdef XP_WIN && defined(NIGHTLY_BUILD)

Drive-by: this syntax seems wrong. shouldn't be it #if defined(XP_WIN) && defined(NIGHTLY_BUILD) ?

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

It looks weird, but I literally copied it from elsewhere in the file. I can change it though.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Might be broken in the other place too, who knows. Or maybe our in-house preprocessor accidentally does the right thing on this syntax?

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #4)
> Might be broken in the other place too, who knows. Or maybe our in-house
> preprocessor accidentally does the right thing on this syntax?

It parses fine but seems to evaluate to #if 0. Hah. Thanks, I'll put a new patch up.

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8806109 [details] [diff] [review]
patch

Review of attachment 8806109 [details] [diff] [review]:
-----------------------------------------------------------------

\o/ Kats' comment non-withstanding.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/59d33178b0cd
Enable out-of-process D3D11 compositing for Nightly Windows users. (bug 1314133, r=milan)

Comment 8

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/28ed60ea7e1117144e10ed931df1dfc9437dacbf for https://treeherder.mozilla.org/logviewer.html#?job_id=38536570&repo=mozilla-inbound

Comment 9

[David Anderson [:dvander] - inactive, e-mail if emergency]

I can reproduce this, investigating.

Comment 10

[Gary [:streetwolf52]]

When I manually add "layers.gpu-process.dev.enabled = true" I get this in about:support graphics section:

Hardware H264 Decoding	Yes; Failed to create D3D11 device for decoder; Using D3D9 API

Comment 11

[Matt Woodrow (:mattwoodrow)]

(In reply to Gary [:streetwolf] from comment #10)
> When I manually add "layers.gpu-process.dev.enabled = true" I get this in
> about:support graphics section:
> 
> Hardware H264 Decoding	Yes; Failed to create D3D11 device for decoder; Using
> D3D9 API

Can you please attach your full about:support from when this happens?

Comment 12

[Gary [:streetwolf52]]

Attachment: Support.zip

The zip files contains:

support_false.txt = about:support with "layers.gpu-process.dev.enabled = false"
support_true.txt = about:support with "layers.gpu-process.dev.enabled = true"

Comment 13

[Matt Woodrow (:mattwoodrow)]

(In reply to Gary [:streetwolf] from comment #12)
> Created attachment 8806898 [details]
> Support.zip
> 
> The zip files contains:
> 
> support_false.txt = about:support with "layers.gpu-process.dev.enabled =
> false"
> support_true.txt = about:support with "layers.gpu-process.dev.enabled = true"

Thanks!

Looks like this is a mainly a reporting problem, you should still be getting D3D11 DXVA for your videos.

I've filed bug 1314803 and bug 1314804 to track fixing this.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4ade2b0841c
Enable the GPU process for Nightly Windows users. (bug 1314133, r=milan)

Comment 15

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b4ade2b0841c

Comment 16

[Xidorn Quan [:xidorn] UTC+10]

Although I have no idea why, and I personally cannot reproduce it, there are reports from Japanese people that this causes issue with printing.