[e10s] <select> dropdown list should handle Full/Text Zoom on Windows10, Text Zoom on Linux.

RESOLVED FIXED in Firefox 52

Status

()

RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: alice0775, Assigned: enndeakin)

Tracking

(Blocks: 2 bugs, 4 keywords)

Trunk
mozilla52
Unspecified
All
multiprocess, platform-parity, qawanted, regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [qawanted for Full/Text Zoom on Windows10])

Attachments

(5 attachments)

(Reporter)

Description

2 years ago
<select> dropdown list is not respect browser zoom level, So It is too hard to read/distinguish them.

Steps To Reproduce:
1. Open attached
2. Expand drop down
3. Zoom up

Actual Results:
Emoji font size is too small for me. So It is too hard to read/distinguish them.

Expected Results:
<select> dropdown list is not respect browser zoom level.
(Reporter)

Comment 1

2 years ago
Created attachment 8806921 [details]
select dropdown emoji.html (charset unicode)
(Assignee)

Comment 2

2 years ago
It does respect the zoom level for me.

Do you mean that the shortcut doesn't work while the popup is open?
(Reporter)

Comment 3

2 years ago
Created attachment 8806934 [details]
screenshot when zoom up
(Reporter)

Comment 4

2 years ago
(In reply to Neil Deakin from comment #2)
> It does respect the zoom level for me.

See screenshot

> Do you mean that the shortcut doesn't work while the popup is open?

No.
(Reporter)

Comment 5

2 years ago
On windows10  : Both Full Zoom and Text Zoom does not work
On Ubuntu16.04: Full Zoom works as expected. However, Text Zoom does not work
(Reporter)

Updated

2 years ago
Keywords: pp
OS: Windows 10 → All
(Assignee)

Comment 6

2 years ago
Looks like full zoom works for me on all platforms, but text zoom needs to be fixed.

Also, I don't get any images in the testcase; just the characters that appear in the source.
(Assignee)

Updated

2 years ago
Summary: [e10s] <select> dropdown list is not respect browser zoom level, So It is too hard to read it. → [e10s] <select> dropdown list should handle text only zoom
(Reporter)

Comment 7

2 years ago
(In reply to Neil Deakin from comment #6)
> Looks like full zoom works for me on all platforms, but text zoom needs to
> be fixed.
> 
> Also, I don't get any images in the testcase; just the characters that
> appear in the source.

No, 
The problem is not only Text Zoom but also Full zoom on windows10.

On Linux, The problem is Text Zoom only.
Summary: [e10s] <select> dropdown list should handle text only zoom → [e10s] <select> dropdown list should handle Full/Text Zoom on Windows10, Text Zoom on Linux.
(Reporter)

Updated

2 years ago
Keywords: qawanted
Whiteboard: [qawanted for Full/Text Zoom on Windows10]
(Reporter)

Comment 8

2 years ago
Created attachment 8807117 [details]
Textcase ordinary Latin text
(Reporter)

Comment 9

2 years ago
Created attachment 8807119 [details]
screenshot about Textcase ordinary Latin text
(Assignee)

Comment 10

2 years ago
Created attachment 8807120 [details] [diff] [review]
Update using either full zoom or text zoom

This patch handles the full vs text zoom setting.
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
(Reporter)

Updated

2 years ago
Attachment #8806921 - Attachment description: select dropdown emoji.html → select dropdown emoji.html (charset unicode)
(Reporter)

Comment 12

2 years ago
(In reply to Neil Deakin from comment #11)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=8621c19d073a

On Ubuntu16.04: The try build fixed Text Zoom. So, Full Zoom and Text Zoom works as expected.

However,
On windows10  : It seems nothing changed from regular Nightly52.0a1. Both Full Zoom and Text Zoom *does not* work.
(Reporter)

Comment 14

2 years ago
(In reply to Neil Deakin from comment #13)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=0662eda97663

Same results as before...

On Ubuntu16.04: The try build fixed Text Zoom. So, Full Zoom and Text Zoom works as expected.

On windows10  : It seems nothing changed from regular Nightly52.0a1. Both Full Zoom and Text Zoom *does not* work.
(Assignee)

Comment 15

2 years ago
I see this patch working for on all platforms (Windows 7, Ubuntu, Mac).

This doesn't seem like something that would depend on the specific operating system version or settings.

Anyway, even so, this patch is better that what existed before, so I think we can use it for now.
(Assignee)

Updated

2 years ago
Attachment #8807120 - Flags: review?(felipc)
(Reporter)

Comment 16

2 years ago
BTW,
This is a regression for Full Zoom on Windows10.


Regression window:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=f03e2740d604d339ed553dad62a3fc54c317f8fa&tochange=83461556cda59e8bcd54f09b9263e3202ce01dc2

Regressed by: 83461556cda5	Mark Golbeck — Bug 1091592 - Improve style of select dropdowns, including adding more padding for touch-enabled devices. r=jaws



@Neil Deakin
I think that it need to enabling accessibility device such as IME or something.
Blocks: 1091592
Flags: needinfo?(markgolbeck08)
Keywords: regression
Could it be that the patch is using 'px' instead of a relative font-size unit such as 'rem'? Mark, please try changing your patch to use '.688rem', which is the equivalent of 11px for me on my Windows10 machine.
Attachment #8807120 - Flags: review?(felipc) → review+
(Assignee)

Comment 18

2 years ago
I think the text zoom not working is one bug (fixed by the patch), and the Windows regression is another bug.
(Reporter)

Updated

2 years ago
Blocks: 1316722
(Reporter)

Comment 19

2 years ago
(In reply to Neil Deakin from comment #18)
> I think the text zoom not working is one bug (fixed by the patch), and the
> Windows regression is another bug.

Okay, I have filed Bug 1316722.

Comment 23

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e976fd4936e3
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
(Reporter)

Updated

a year ago
Flags: needinfo?(markgolbeck08)
You need to log in before you can comment on or make changes to this bug.