1314802 - [e10s] <select> dropdown list should handle Full/Text Zoom on Windows10, Text Zoom on Linux.

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Alice0775 White]

<select> dropdown list is not respect browser zoom level, So It is too hard to read/distinguish them.

Steps To Reproduce:
1. Open attached
2. Expand drop down
3. Zoom up

Actual Results:
Emoji font size is too small for me. So It is too hard to read/distinguish them.

Expected Results:
<select> dropdown list is not respect browser zoom level.

Comment 1

[Alice0775 White]

Attachment: select dropdown emoji.html (charset unicode)

Comment 2

[Neil Deakin]

It does respect the zoom level for me.

Do you mean that the shortcut doesn't work while the popup is open?

Comment 3

[Alice0775 White]

Attachment: screenshot when zoom up

Comment 4

[Alice0775 White]

(In reply to Neil Deakin from comment #2)
> It does respect the zoom level for me.

See screenshot

> Do you mean that the shortcut doesn't work while the popup is open?

No.

Comment 5

[Alice0775 White]

On windows10  : Both Full Zoom and Text Zoom does not work
On Ubuntu16.04: Full Zoom works as expected. However, Text Zoom does not work

Comment 6

[Neil Deakin]

Looks like full zoom works for me on all platforms, but text zoom needs to be fixed.

Also, I don't get any images in the testcase; just the characters that appear in the source.

Comment 7

[Alice0775 White]

(In reply to Neil Deakin from comment #6)
> Looks like full zoom works for me on all platforms, but text zoom needs to
> be fixed.
> 
> Also, I don't get any images in the testcase; just the characters that
> appear in the source.

No, 
The problem is not only Text Zoom but also Full zoom on windows10.

On Linux, The problem is Text Zoom only.

Comment 8

[Alice0775 White]

Attachment: Textcase ordinary Latin text

Comment 9

[Alice0775 White]

Attachment: screenshot about Textcase ordinary Latin text

Comment 10

[Neil Deakin]

Attachment: Update using either full zoom or text zoom

This patch handles the full vs text zoom setting.

Comment 11

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8621c19d073a

Comment 12

[Alice0775 White]

(In reply to Neil Deakin from comment #11)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=8621c19d073a

On Ubuntu16.04: The try build fixed Text Zoom. So, Full Zoom and Text Zoom works as expected.

However,
On windows10  : It seems nothing changed from regular Nightly52.0a1. Both Full Zoom and Text Zoom *does not* work.

Comment 13

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0662eda97663

Comment 14

[Alice0775 White]

(In reply to Neil Deakin from comment #13)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=0662eda97663

Same results as before...

On Ubuntu16.04: The try build fixed Text Zoom. So, Full Zoom and Text Zoom works as expected.

On windows10  : It seems nothing changed from regular Nightly52.0a1. Both Full Zoom and Text Zoom *does not* work.

Comment 15

[Neil Deakin]

I see this patch working for on all platforms (Windows 7, Ubuntu, Mac).

This doesn't seem like something that would depend on the specific operating system version or settings.

Anyway, even so, this patch is better that what existed before, so I think we can use it for now.

Comment 16

[Alice0775 White]

BTW,
This is a regression for Full Zoom on Windows10.


Regression window:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=f03e2740d604d339ed553dad62a3fc54c317f8fa&tochange=83461556cda59e8bcd54f09b9263e3202ce01dc2

Regressed by: 83461556cda5	Mark Golbeck — Bug 1091592 - Improve style of select dropdowns, including adding more padding for touch-enabled devices. r=jaws



@Neil Deakin
I think that it need to enabling accessibility device such as IME or something.

Comment 17

[Jared Wein [:jaws] (please needinfo? me)]

Could it be that the patch is using 'px' instead of a relative font-size unit such as 'rem'? Mark, please try changing your patch to use '.688rem', which is the equivalent of 11px for me on my Windows10 machine.

Comment 18

[Neil Deakin]

I think the text zoom not working is one bug (fixed by the patch), and the Windows regression is another bug.

Comment 19

[Alice0775 White]

(In reply to Neil Deakin from comment #18)
> I think the text zoom not working is one bug (fixed by the patch), and the
> Windows regression is another bug.

Okay, I have filed Bug 1316722.

Comment 20

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0baa46cbe531

Comment 21

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=31370d478861

Comment 22

[Neil Deakin]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e976fd4936e3e686719230b04a7e57ba19888f17
Bug 1314802, handle text zoom for select popups, r=felipe

Comment 23

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e976fd4936e3