1314902 - Remove duplicated vector icons

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Activity Stream, defect, P5)

Description

[Andrzej Hunt :ahunt]

The ActivityStream context menu (landed in Bug 1300144) added a bunch of VectorDrawable icons, some of which are near-duplicates of existing icons.

Most icons cannot be swapped directly, we need to adapt each existing icon/replacement on a case by case basis, including UX evaluation e.g.:

- bookmark star: requires a filled blue version, the vector version has a slightly fatter edge.
- private / tab icons: different design for private "mask", tab icon is hollow in the VectorDrawable version
etc.
- new "copy" icon is styled differently (our old copy icon is used in the old text selection action bar, i.e. matches the android system text selection actionbar)
- share icon: slightly different proportions, but might be the easiest icon to replace.

A full list of the icons that were added can be found in:
https://hg.mozilla.org/mozilla-central/rev/08a6186c2842

Bug 1312114 was a first attempt at doing this: in that bug we are landing code that allows us to use VectorDrawable's in various parts of the codebase (unfortunately Android doesn't support them everywhere by default, hence some code changes are needed).

We have a more generic bug to investigate replacing other icons in bug 1310143, this bug is focused on using the already added VectorDrawables to replace some png's.

Comment 1

[Andrzej Hunt :ahunt]

I'm not quite sure what the priority on this is, setting P2 to keep it visible at least.

It might be best to use this as a metabug, and have a bug per icon replacement. In any case, I'll pushed my WIP patches to ReviewBoard as part of this bug, these should be a useful starting point for actually completing the icon upgrades.

Comment 2

[Andrzej Hunt :ahunt]

Attachment: WIP: Bug 1314902 - Replace ic_menu_share with (VectorDrawable) as_share

The icons look slightly different, this will need some UX review.

Review commit: https://reviewboard.mozilla.org/r/90382/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90382/

Comment 3

[Andrzej Hunt :ahunt]

Attachment: WIP: Bug 1314902 - Replace ic_menu_bookmark with as_bookmark

The vector icon is slightly fatter, we also need to tint it for the
main menu. It would also be good to replace the filled star with a
VectorDrawable.

Review commit: https://reviewboard.mozilla.org/r/90384/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90384/

Comment 4

[Andrzej Hunt :ahunt]

Attachment: WIP: Bug 1314902 - Replace tabs/private tabs icon with VectorDrawable

TODO:
- Verify that we want to use a different private mask than before?
- Create filled tab icon, verify that we want a taller icon?

Review commit: https://reviewboard.mozilla.org/r/90386/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90386/

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

All open Activity Stream bugs are moving from the whiteboard tag, "[mobileAS]", to the Firefox for Android component, "Activity Stream", so that I can keep better track of these bugs as the new triage owner; I will send out an email shortly with additional details, caveats, etc.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

P5: there are many more UX issues to prioritize over APK size now but we'll take a patch for it.

Comment 7

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.