Closed
Bug 1315458
Opened 8 years ago
Closed 7 years ago
"Remove" and "Preferences" buttons in container preferences are not localized
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
VERIFIED
FIXED
Firefox 53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | verified |
People
(Reporter: flod, Assigned: aryx, Mentored)
References
Details
Attachments
(3 files)
screenshot.png
I'm on a localized build 52.0a1 (2016-11-05) (64 bit) Firefox should be fully localized. Most of the new Containers tab is localized, but the Remove and Preferences buttons are not.
|
Reporter | |
Comment 1•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/diff/964223d37a2e/browser/components/preferences/handlers.xml#l1.23 Both labels are hard-coded. We have the strings on file https://hg.mozilla.org/mozilla-central/file/964223d37a2e/browser/locales/en-US/chrome/browser/preferences/containers.properties#l5
|
|
Reporter | |
Comment 2•8 years ago
|
||
Let's keep this as a good first bug for Nightly, CCing Pascal for it.
Mentor: pascalc
|
||
Comment 3•8 years ago
|
||
Happy to be another mentor on this for anyone willing to pick it up.
Mentor: jkt
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 6•7 years ago
|
||
Please ignore the xargs patch, it's just needed for building until it lands in the tree (bug 1324473).
Assignee: nobody → aryx.bugmail
Status: NEW → ASSIGNED
|
|
||
Comment 7•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8822185 [details] Bug 1315458 - Container management: Make "Preferences" and "Remove" buttons localizable. https://reviewboard.mozilla.org/r/101170/#review101828
Attachment #8822185 -
Flags: review?(jkt) → review+
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/df6ef96fc616 Container management: Make "Preferences" and "Remove" buttons localizable. r=jkt
|
||
Comment 9•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/df6ef96fc616
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
|
||
Comment 10•7 years ago
|
||
[bugday-131548] bug verified
|
||
Comment 11•7 years ago
|
||
[bugday-20170105] Bug verified
|
||
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•