Closed
Bug 1315480
Opened 8 years ago
Closed 8 years ago
LibreOffice/MS Office integration: Convert image data referencing MIME parts via imap/mailbox URLs to data URLs (for viewed messages)
Categories
(Thunderbird :: Message Reader UI, defect)
Thunderbird
Message Reader UI
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 52.0
People
(Reporter: jorgk-bmo, Assigned: mkmelin)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
7.40 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
Since we're talking to TDF/LibreOffice as a new home for Thunderbird, let's keep everybody happy by improving the interoperability.
Currently pictures copied from TB to *Office end up as ugly placeholders, in MS Office pasting invisibly and in LibreOffice showing some funny imap/mailbox URL.
We can improve this by placing the images as data URLs onto the clipboard.
Assignee | ||
Comment 1•8 years ago
|
||
Covers the copy/drag of a part of content + the context menu "Copy Image" case.
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #8809368 -
Flags: review?(jorgk)
Reporter | ||
Comment 2•8 years ago
|
||
Comment on attachment 8809368 [details] [diff] [review]
bug1315480_copy_data_urls.patch
Review of attachment 8809368 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. I haven't tested it yet. I'll get to this in the next 24 hours.
Nice effort that will keep our *Office users happy ;-)
::: mail/base/content/mailWindow.js
@@ +68,5 @@
> + let sourceDoc = getBrowser().contentDocument;
> + let selection = sourceDoc.getSelection();
> + let draggedImg = null; // Will be set to the img for single image drag.
> + for (let img of sourceDoc.images) {
> + if (/^(http|data):/.test(img.src)) {
Further down you do:
if (/^(https?|data):/i.test(img.src)) {
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8809368 [details] [diff] [review]
bug1315480_copy_data_urls.patch
Ain't workin' ;-(
Test case: HTML message with two embedded images. Select all in the original message, drag onto a composition. Result: Only one image dragged over.
Attachment #8809368 -
Flags: review?(jorgk)
Assignee | ||
Comment 4•8 years ago
|
||
Now all the dragged material should be copied
Attachment #8809368 -
Attachment is obsolete: true
Attachment #8809525 -
Flags: review?(jorgk)
Reporter | ||
Comment 5•8 years ago
|
||
Sorry, now the test case from comment #3 works, but the single image drag doesn't. It inserts a imap: URL.
Assignee | ||
Updated•8 years ago
|
Attachment #8809525 -
Attachment is obsolete: true
Attachment #8809525 -
Flags: review?(jorgk)
Reporter | ||
Comment 7•8 years ago
|
||
Comment on attachment 8809538 [details] [diff] [review]
bug1315480_copy_data_urls.patch
(In reply to Magnus Melin from comment #6)
> Third time's a charm?
Yep. r=jorgk.
This will keep our *Office friends happy.
Attachment #8809538 -
Flags: review?(jorgk) → review+
Assignee | ||
Comment 8•8 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
Reporter | ||
Comment 9•8 years ago
|
||
I noticed that this doesn't work when dragging embedded images from other compose windows.
Or would you like a new bug for that?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 10•8 years ago
|
||
Yes, let's limit this bug to viewed messages.
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Summary: LibreOffice/MS Office integration: Convert image data referencing MIME parts via imap/mailbox URLs to data URLs → LibreOffice/MS Office integration: Convert image data referencing MIME parts via imap/mailbox URLs to data URLs (for viewed messages)
Reporter | ||
Comment 11•8 years ago
|
||
OK, to be continued in bug 1317049.
Updated•8 years ago
|
Blocks: attach-paradigm-fail
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(rsx11m.pub)
You need to log in
before you can comment on or make changes to this bug.
Description
•