1315527 - [GTK 3.20] borders and separators are now black, rather than shades of gray

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[vummiess]

Attachment: Firefox 49 (good)

this may have been introduced in bug 1266914 ...

starting in 50, borders around e.g. the location bar and menu have been switched from a nice shade of gray to a rather jarring black; starting in 51, the separators in the location bar are also switched to black (along with remaining separators in menu), and the background in the menu is switched to white. see attached screen captures comparing 49 (good), 50 (worse), 51 (worst).

Comment 1

[vummiess]

Attachment: Firefox 50 (borders switched to black)

Comment 2

[vummiess]

Attachment: Firefox 51 (separators all black, background in menu switched to white)

Comment 3

[vummiess]

Attachment: Firefox 50 (menu background highlight color missing (causes hovered text to be unreadable))

this may be related -- starting in Firefox 50, the menu highlight background color is missing in some themes (e.g. BlueMenta).

Comment 4

[Karl Tomlinson (:karlt)]

(In reply to vummiess from comment #0)
> starting in 50, borders around e.g. the location bar and menu have been
> switched from a nice shade of gray to a rather jarring black;

What is the libgtk-3 version installed?

Do you see this with Adwaita?
If not, what is the GTK theme in the first three screenshots.?

> starting in
> 51, the separators in the location bar are also switched to black (along
> with remaining separators in menu), and the background in the menu is
> switched to white.

The background may be intentional from bug 1293018 (and I guess that also changed separators to use the same color as the other borders).

(In reply to vummiess from comment #3)
> this may be related -- starting in Firefox 50, the menu highlight background
> color is missing in some themes (e.g. BlueMenta).

It may be related in that it is specific to a GTK version, but it would need quite a different fix in Firefox.  Can you file a separate bug for this, please?
If you can attach a screenshot of the highlighted menuitem in another GTK app, perhaps page 2 of gtk3-widget-factory, then that might help find the CSS source for the highlight, which would provide some clues on how to fix this.

Comment 5

[vummiess]

(In reply to Karl Tomlinson (:karlt) from comment #4)
> What is the libgtk-3 version installed?

gtk3 version 3.20.9

> Do you see this with Adwaita?

Fedora doesn't have the full Adwaita theme for gtk3.

> If not, what is the GTK theme in the first three screenshots.?

"TraditionalOk". Other similar-colored themes are similarly affected.

> (In reply to vummiess from comment #3)
> > this may be related -- starting in Firefox 50, the menu highlight background
> > color is missing in some themes (e.g. BlueMenta).
> 
> It may be related in that it is specific to a GTK version, but it would need
> quite a different fix in Firefox.  Can you file a separate bug for this,
> please?

filed as bug 1315668

Comment 6

[Karl Tomlinson (:karlt)]

Yes, this would be fallout from changes for bug 1266914.

The bug does not demonstrate in Adwaita because that theme renders the frame border on the border node.  TraditionalOk renders the border on the frame's root node.

The following CSS in ~/.config/gtk-3.0/gtk.css demonstrates which is used:

frame border { border-color: green; }
frame { border-color: red;  }

It should be possible to try these in turn.

Comment 7

[Bill Gianopoulos [:WG9s]]

How odd I use Adwaita on fedora24 fedora25 and fedora26 and see no issue here..

Comment 8

[Bob Farmer]

(In reply to Bill Gianopoulos [:WG9s] from comment #7)
> How odd I use Adwaita on fedora24 fedora25 and fedora26 and see no issue
> here..

Yes, Adwaita works fine but TraditionalOk (and many/most other Fedora 24 themes) have the problem.

I downloaded Clearlooks-Phenix v7 (which looks identical to TraditionalOk but is more up-to-date) and switched to that as my theme.  Good work-around for now.

Comment 9

[Bill Gianopoulos [:WG9s]]

(In reply to Bob Farmer from comment #8)
> (In reply to Bill Gianopoulos [:WG9s] from comment #7)
> > How odd I use Adwaita on fedora24 fedora25 and fedora26 and see no issue
> > here..
> 
> Yes, Adwaita works fine but TraditionalOk (and many/most other Fedora 24
> themes) have the problem.
> 
> I downloaded Clearlooks-Phenix v7 (which looks identical to TraditionalOk
> but is more up-to-date) and switched to that as my theme.  Good work-around
> for now.

fedora24 fonts were designed to work with gtk 3.18 and might require changes to be completely 3.20 compatible.

Comment 10

[Bill Gianopoulos [:WG9s]]

Sorry I obviously meant themes and not fonts.

Comment 11

[Karl Tomlinson (:karlt)]

Attachment: bug 1315527 check root node of frame for border color if no border on the "border" subnode

Some themes do not draw the "border" subnode, but instead draw a border on the
frame root node.

Review commit: https://reviewboard.mozilla.org/r/94314/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94314/

Comment 12

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8812653 [details]
bug 1315527 check root node of frame for border color if no border on the "border" subnode

https://reviewboard.mozilla.org/r/94314/#review94516

Fine.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7fff8cc2988
check root node of frame for border color if no border on the "border" subnode r=stransky+263117

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a7fff8cc2988

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Should we consider backporting this to Aurora/Beta?

Comment 16

[Karl Tomlinson (:karlt)]

Comment on attachment 8812653 [details]
bug 1315527 check root node of frame for border color if no border on the "border" subnode

Approval Request Comment
[Feature/Bug causing the regression]: bug 1266914
[User impact if declined]:
Polish issue affecting users with Mate desktop or themes, but only only with GTK 3.20 or newer.
Mate is popular enough to have its own flavor of Ubuntu.
https://distrowatch.com/table.php?distribution=ubuntumate
http://popcon.ubuntu.com/ would indicate it is installed in only about 0.5% of Ubuntu installations.  I wonder whether that includes Ubuntu MATE installations.
http://popcon.debian.org/ indicates 6-7%.
Still GTK 3.20 users will be only a fraction of that.

Really this is a minor bug, but before changes for bug 1266914 the border colors happened to be good, mostly by good luck, and so this is a regression.

[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]:  no
Needs installation of GTK themes, and so non-trivial to reproduce.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]:
Some risk, contained to similar polish issues.
[Why is the change risky/not risky?]:
There is chance of another GTK theme being affected adversely in a similar manner to this regression from bug 1266914.  The additional code is better at detecting the colors used by the themes, but some themes may use gradient colors that are not handled here, and so the color picked may still differ from what the theme is using.
[String changes made/needed]: none

Comment 17

[Karl Tomlinson (:karlt)]

Although the long phase of the release cycle permits consideration of uplift for 52, I don't think this is worth the risk on 51.

Comment 18

[Julien Cristau [:jcristau]]

Comment on attachment 8812653 [details]
bug 1315527 check root node of frame for border color if no border on the "border" subnode

fix for some gtk themes, take in aurora52

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/21c5d924faf6