Closed Bug 1315911 Opened 5 years ago Closed 5 years ago

[DateTimePicker] Disable time picker UI by making it pref-off by default

Categories

(Toolkit :: XUL Widgets, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: scottwu, Assigned: scottwu)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The date picker UI is considered more essential than the time picker UI. Thus we are re-prioritizing our work to focus on the date picker instead. The time picker UI will be disabled by default and can be turned on via pref.
Assignee: nobody → scwwu
Attachment #8808880 - Flags: review?(mconley)
Based on the input from product and UX, it seems that the date picker should be prioritized over the time picker. I will pref off the time picker for now and focus on the date picker instead. Mike, wonder if you could review this small patch?

I created a “dom.forms.datetime.timepicker” pref that defaults to false. When datetimebox is clicked, it checks if type is "time", and if the pref is true or false.

Thanks!
Flags: needinfo?(mconley)
Comment on attachment 8808880 [details]
Bug 1315911 - Disable time picker UI by making it pref-off by default;

https://reviewboard.mozilla.org/r/91602/#review91586

::: toolkit/content/browser-content.js:1678
(Diff revision 2)
>     * DOM events.
>     */
>    handleEvent: function(aEvent) {
>      switch (aEvent.type) {
>        case "MozOpenDateTimePicker": {
> -        if (!(aEvent.originalTarget instanceof content.HTMLInputElement)) {
> +        // Time picker is disabled when pref off

"pref" -> "preffed"
Attachment #8808880 - Flags: review?(mconley) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/69fd9d1c09c5
Disable time picker UI by making it pref-off by default; r=mconley
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/69fd9d1c09c5
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.