1315911 - [DateTimePicker] Disable time picker UI by making it pref-off by default

Status: RESOLVED FIXED

(Toolkit :: XUL Widgets, defect)

Description

[Scott Wu [:scottwu]]

The date picker UI is considered more essential than the time picker UI. Thus we are re-prioritizing our work to focus on the date picker instead. The time picker UI will be disabled by default and can be turned on via pref.

Comment 1

[Scott Wu [:scottwu]]

Attachment: Bug 1315911 - Disable time picker UI by making it pref-off by default;

Review commit: https://reviewboard.mozilla.org/r/91602/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91602/

Comment 2

[Scott Wu [:scottwu]]

Comment on attachment 8808880 [details]
Bug 1315911 - Disable time picker UI by making it pref-off by default;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/91602/diff/1-2/

Comment 3

[Scott Wu [:scottwu]]

Based on the input from product and UX, it seems that the date picker should be prioritized over the time picker. I will pref off the time picker for now and focus on the date picker instead. Mike, wonder if you could review this small patch?

I created a “dom.forms.datetime.timepicker” pref that defaults to false. When datetimebox is clicked, it checks if type is "time", and if the pref is true or false.

Thanks!

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8808880 [details]
Bug 1315911 - Disable time picker UI by making it pref-off by default;

https://reviewboard.mozilla.org/r/91602/#review91586

::: toolkit/content/browser-content.js:1678
(Diff revision 2)
>     * DOM events.
>     */
>    handleEvent: function(aEvent) {
>      switch (aEvent.type) {
>        case "MozOpenDateTimePicker": {
> -        if (!(aEvent.originalTarget instanceof content.HTMLInputElement)) {
> +        // Time picker is disabled when pref off

"pref" -> "preffed"

Comment 5

[Scott Wu [:scottwu]]

Comment on attachment 8808880 [details]
Bug 1315911 - Disable time picker UI by making it pref-off by default;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/91602/diff/2-3/

Comment 6

[Scott Wu [:scottwu]]

Thanks Mike!

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d55d7d48f92cf9a7f15b0ff9e98dd29a23affa00

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69fd9d1c09c5
Disable time picker UI by making it pref-off by default; r=mconley

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/69fd9d1c09c5