[DateTimePicker] Disable time picker UI by making it pref-off by default

RESOLVED FIXED in Firefox 52

Status

()

Toolkit
XUL Widgets
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: scottwu, Assigned: scottwu)

Tracking

(Blocks: 1 bug)

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The date picker UI is considered more essential than the time picker UI. Thus we are re-prioritizing our work to focus on the date picker instead. The time picker UI will be disabled by default and can be turned on via pref.
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Assignee: nobody → scwwu
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8808880 - Flags: review?(mconley)
(Assignee)

Comment 3

2 years ago
Based on the input from product and UX, it seems that the date picker should be prioritized over the time picker. I will pref off the time picker for now and focus on the date picker instead. Mike, wonder if you could review this small patch?

I created a “dom.forms.datetime.timepicker” pref that defaults to false. When datetimebox is clicked, it checks if type is "time", and if the pref is true or false.

Thanks!
Flags: needinfo?(mconley)
Comment on attachment 8808880 [details]
Bug 1315911 - Disable time picker UI by making it pref-off by default;

https://reviewboard.mozilla.org/r/91602/#review91586

::: toolkit/content/browser-content.js:1678
(Diff revision 2)
>     * DOM events.
>     */
>    handleEvent: function(aEvent) {
>      switch (aEvent.type) {
>        case "MozOpenDateTimePicker": {
> -        if (!(aEvent.originalTarget instanceof content.HTMLInputElement)) {
> +        // Time picker is disabled when pref off

"pref" -> "preffed"
Attachment #8808880 - Flags: review?(mconley) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 6

2 years ago
Thanks Mike!

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d55d7d48f92cf9a7f15b0ff9e98dd29a23affa00
Flags: needinfo?(mconley)
Keywords: checkin-needed

Comment 7

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/69fd9d1c09c5
Disable time picker UI by making it pref-off by default; r=mconley
Keywords: checkin-needed

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/69fd9d1c09c5
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.