1726107 - Fix and re-enable the time picker UI

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

It was disabled in bug 1315911, presumably needs more work to be enabled by default.

Comment 1

[❌ Anna Yeddi [:ayeddi] ❌ On leave until 2027-01-04]

Accessibility-wise, the datepicker a11y bug 1676068 drastically improves the accessibility of spinner widgets that are included on the timepicker panel, thus it appears to be beneficial to show the timepicker that would, among other pros, communicate to a screen reader user what are the minimum and maximum allowed values for each spin button, etc. (the remaining a11y enhancements for the timepicker panel are tracked in the bug 1802201).

This change (showing the time picker) could increase the adoption of a default time inputs vs custom, rarely accessible ones.

Other browsers like Edge and Chrome (on both macOS and Win) have a timepicker showing by default.

When implemented, the MDN time appearance example may need an updated screenshot as well.

Comment 2

[software]

Can we enable it per attribut? How is the status?

Comment 3

[Sam Johnson]

Hi Emilio! Now that all of the referenced bugs are fixed, did you have anything else in mind that needs to be taken care of before this can be enabled in Nightly? If not, I can put up a patch that flips the pref and fixes up the tests.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

I'm not aware of any other blocker, so yes please, feel free to do so!

And also feel free to send an intent to ship if you want (or if you don't have the cycles lmk and I can do it on your behalf).

Thanks a lot Sam! :)

Comment 5

[Sam Johnson]

Attachment: Bug 1726107 - Enable time picker UI for time and datetime-local inputs. r?#layout-reviewers,#recomp-reviewers

Flips the time picker pref now that all known blockers are resolved, and updates existing tests as needed.

Comment 6

[Sam Johnson]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #4)

And also feel free to send an intent to ship if you want (or if you don't have the cycles lmk and I can do it on your behalf).

No problem, I can send one! I have a few questions though after reading through the guidelines. I don't see an existing intent-to-prototype for this, does that mean I should use the intent-to-prototype-and-ship template? Since WHATWG only specifies that input pickers are implementation-defined, what information needs to be provided within the fields for standards and web-platform-tests?

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Yeah, probably worth merging them. And saying that the UI part of this isn't tested by WPT because of that implementation defined stuff is fair enough. The web-exposed details which are already tested by WPT.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/28d25a211df6
https://hg.mozilla.org/integration/autoland/rev/dd723726b90f
Enable time picker UI for time and datetime-local inputs. r=layout-reviewers,emilio

Comment 9

[Sam Johnson]

Release Note Request (optional, but appreciated)
[Why is this notable]: Adds a time picker UI for <input type="time"> and <input type="datetime-local">, which Blink has had for quite a while, and complements the existing date picker UI.
[Affects Firefox for Android]: No, Android already has a time picker UI.
[Suggested wording]: Added a time picker to <input type="time"> and <input type="datetime-local">, making selecting a time more accessible and intuitive.
[Links (documentation, blog post, etc)]:

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d085731b6b88
https://hg.mozilla.org/integration/autoland/rev/9c710513ae62
Revert "Bug 1726107 - Enable time picker UI for time and datetime-local inputs. r=layout-reviewers,emilio" for causing failures at test_HTMLSpec.html

Comment 11

[Atila Butkovits]

Backed out for causing failures at test_HTMLSpec.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/9c710513ae62

Push with failure: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=dd723726b90f0eb5ebbb3227c44d536bd5432d2a&selectedTaskRun=BPTJLb7DTAWqjMQFLWUNQQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=573938150&repo=autoland&task=BPTJLb7DTAWqjMQFLWUNQQ.0&lineNumber=3631

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/efefd28c9628
https://hg.mozilla.org/integration/autoland/rev/1f1295b03552
Enable time picker UI for time and datetime-local inputs. r=layout-reviewers,emilio

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/76937e1189de
https://hg.mozilla.org/integration/autoland/rev/9231a7692196
Revert "Bug 1726107 - Enable time picker UI for time and datetime-local inputs. r=layout-reviewers,emilio" for causing wr failures @ transform-input-012.html

Comment 14

[amarc]

Backed out for causing wr failures

• Backout link
• Push with failures
• Failure Log

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f3a818c5118e
https://hg.mozilla.org/integration/autoland/rev/53d3ec9a04d9
Enable time picker UI for time and datetime-local inputs. r=layout-reviewers,emilio

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c83ec12ea222
https://hg.mozilla.org/integration/autoland/rev/652396274a99
Revert "Bug 1726107 - Enable time picker UI for time and datetime-local inputs. r=layout-reviewers,emilio" for causing wr failures @transform-input-012.html.

Comment 17

[agoloman]

Backed out for causing wr failures @transform-input-012.html.

• Backout link
• Push with failures
• Failure Log

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5574ad5c693c
https://hg.mozilla.org/integration/autoland/rev/05cac4efca00
Enable time picker UI for time and datetime-local inputs. r=layout-reviewers,emilio

Comment 19

[rperta]

https://hg.mozilla.org/mozilla-central/rev/05cac4efca00