1316002 - [findbugs] [DE] Comparison of String objects using == or != in org.mozilla.gecko.home.HomeAdapter$PanelInfo.getClassName(Context)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Comparison of String objects using == or != in org.mozilla.gecko.home.HomeAdapter$PanelInfo.getClassName(Context) 

"This code compares java.lang.String objects for reference equality using the == or != operators. Unless both strings are either constants in a source file, or have been interned using the String.intern() method, the same string value may be represented by two different String objects. Consider using the equals(Object) method instead."

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

To start, set up a build environment - you can see the instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

Then, you'll need to upload a patch - see:
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "sebastian" and you can find me and other helpful folks in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Comment 2

[swaroop.rao]

Attachment: Bug 1316002: Fixed '==' comparison of strings;

Review commit: https://reviewboard.mozilla.org/r/92404/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92404/

Comment 3

[swaroop.rao]

I have submitted a patch for this using MozReview. Is there anything else I need to do for this?

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8809925 [details]
Bug 1316002: Fixed '==' comparison of strings;

https://reviewboard.mozilla.org/r/92404/#review92940

That's perfect. Thanks!

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

I triggered a try run. If our tests pass then you can add the "checkin-needed" keyword to the bug and someone will land the patch for you!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1f54f33a628

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d444cb9e676d
Fixed '==' comparison of strings; r=sebastian

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d444cb9e676d

Comment 8

[areya]

https://hg.mozilla.org/mozilla-central/rev/d444cb9e676d