1315942 - (findbugs-android) Run code analyzer in automation to avoid common errors (FindBugs, PMD, error-prone)

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, task, P5)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

We recently fixed a crash caused by simply forgetting a "break" in a switch statement. That's something most (static) code analyzers warn about. Right now we do not run such a tool in automation and therefore miss such problems if the reviewer doesn't see it.

There are gradle plugins for findbugs or PMD. Integration should be easy and more or less the same as our "checkstyle" task.

Running findbugs locally reports 650 warnings (77 high priority / 573 medium priority). If we fix the high priority warnings then we could run those checks in automation.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

I don't really have a preference for one of the tools. FindBugs seems to be very easy to integrate and widely used.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

I filed bugs for all the "high priority" warnings from find bugs. After fixing those bugs we can run those checks in automation. They are all marked as "good first bugs".

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c70f14a433e
redisable browser_referrer_middle_click_in_container.js for failures a=me

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Oops, wrong bug number in that commit message.

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/563c2a63a5e6
Backed out changeset 6c70f14a433e for landing with the wrong bug number

Comment 7

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 8

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.