1316006 - [findbugs] [USELESS_STRING] Invocation of toString on selectionArgs

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Invocation of toString on selectionArgs in org.mozilla.gecko.db.AbstractTransactionalProvider.delete(Uri, String, String[])

Invocation of toString on selectionArgs in org.mozilla.gecko.db.AbstractTransactionalProvider.update(Uri, ContentValues, String, String[])

Invocation of toString on columns in org.mozilla.gecko.db.BaseTable.query(SQLiteDatabase, Uri, int, String[], String, String[], String, String, String)

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

To start, set up a build environment - you can see the instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

Then, you'll need to upload a patch - see:
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "sebastian" and you can find me and other helpful folks in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Comment 2

[Shan[:Shan11812]]

(In reply to Sebastian Kaspari (:sebastian) from comment #0)
> Invocation of toString on selectionArgs in
> org.mozilla.gecko.db.AbstractTransactionalProvider.delete(Uri, String,
> String[])
> 
> Invocation of toString on selectionArgs in
> org.mozilla.gecko.db.AbstractTransactionalProvider.update(Uri,
> ContentValues, String, String[])
> 
> Invocation of toString on columns in
> org.mozilla.gecko.db.BaseTable.query(SQLiteDatabase, Uri, int, String[],
> String, String[], String, String, String)

Hi Sebastian,
The implicit calling of toString() returns just the Object datatype info.
Should I change it to display correct array? Or just remove it?

Comment 3

[Toby]

Hi Sebastian, first time bug fixer here. I am wondering if this bug is still available and if so may I work on it.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Shan from comment #2)
> The implicit calling of toString() returns just the Object datatype info.
> Should I change it to display correct array? Or just remove it?

Yeah, I think in this case we want to log the contents of the array. So we should wrap it in Arrays.toString().

Comment 5

[Shan[:Shan11812]]

Attachment: Bug 1316006 - Change implicit toString() to Arrays.toString();

Review commit: https://reviewboard.mozilla.org/r/95654/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95654/

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8814380 [details]
Bug 1316006 - Change implicit toString() to Arrays.toString();

https://reviewboard.mozilla.org/r/95654/#review95692

LGTM. Thank you!

I pushed the patch to try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=416b48e611de

Comment 7

[Shan[:Shan11812]]

Discarded the patch by mistake!
While pushing got some error and did it twice. Thought I was discarding the second push :|
Sorry!
I've couldn't find a way to undo it. Should I submit it again?

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8814380 [details]
Bug 1316006 - Change implicit toString() to Arrays.toString();

Removed the obsolete flag. :)

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

It's still discarded on mozreview though. Yeah, I think you'll need to submit it again.

Comment 10

[Shan[:Shan11812]]

Attachment: Bug 1316006 - Change implicit toString() to Arrays.toString();

Review commit: https://reviewboard.mozilla.org/r/95980/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95980/

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8814870 [details]
Bug 1316006 - Change implicit toString() to Arrays.toString();

https://reviewboard.mozilla.org/r/95980/#review95964

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c9297cc0e46
Change implicit toString() to Arrays.toString(); r=sebastian

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0c9297cc0e46