Closed Bug 1316012 Opened 6 years ago Closed 6 years ago
[findbugs] [Bx] Boxing/unboxing to parse a primitive org
.mozilla .gecko .push .Fetched .from JSONObject(JSONObject)
Boxing/unboxing to parse a primitive org.mozilla.gecko.push.Fetched.fromJSONObject(JSONObject) "A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method."
To start, set up a build environment - you can see the instructions here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build Then, you'll need to upload a patch - see: http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "sebastian" and you can find me and other helpful folks in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC
Assignee: nobody → 11812r
Status: NEW → ASSIGNED
Comment on attachment 8814535 [details] Bug 1316012 - Remove unnecessary boxing/unboxing; https://reviewboard.mozilla.org/r/95744/#review95960 LGTM. https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb32ff88cf058d514efe8594cdde3480f6858ba3
Attachment #8814535 - Flags: review?(s.kaspari) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/b37f2a4bd333 Remove unnecessary boxing/unboxing; r=sebastian
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.