1316012 - [findbugs] [Bx] Boxing/unboxing to parse a primitive org.mozilla.gecko.push.Fetched.fromJSONObject(JSONObject)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Boxing/unboxing to parse a primitive org.mozilla.gecko.push.Fetched.fromJSONObject(JSONObject)

"A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method."

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

To start, set up a build environment - you can see the instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

Then, you'll need to upload a patch - see:
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "sebastian" and you can find me and other helpful folks in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Comment 2

[Shan[:Shan11812]]

Attachment: Bug 1316012 - Remove unnecessary boxing/unboxing;

Review commit: https://reviewboard.mozilla.org/r/95744/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95744/

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8814535 [details]
Bug 1316012 - Remove unnecessary boxing/unboxing;

https://reviewboard.mozilla.org/r/95744/#review95960

LGTM.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb32ff88cf058d514efe8594cdde3480f6858ba3

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b37f2a4bd333
Remove unnecessary boxing/unboxing; r=sebastian

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b37f2a4bd333