[findbugs] [Bx] Boxing/unboxing to parse a primitive org.mozilla.gecko.push.Fetched.fromJSONObject(JSONObject)

RESOLVED FIXED in Firefox 53

Status

()

Firefox for Android
General
P3
normal
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: sebastian, Assigned: Shan11812, Mentored)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 53
All
Android
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [lang=java][good first bug])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

6 months ago
Boxing/unboxing to parse a primitive org.mozilla.gecko.push.Fetched.fromJSONObject(JSONObject)

"A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method."
(Reporter)

Comment 1

6 months ago
To start, set up a build environment - you can see the instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

Then, you'll need to upload a patch - see:
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "sebastian" and you can find me and other helpful folks in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC
Comment hidden (mozreview-request)
(Reporter)

Updated

5 months ago
Assignee: nobody → 11812r
Status: NEW → ASSIGNED
(Reporter)

Comment 3

5 months ago
mozreview-review
Comment on attachment 8814535 [details]
Bug 1316012 - Remove unnecessary boxing/unboxing;

https://reviewboard.mozilla.org/r/95744/#review95960

LGTM.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb32ff88cf058d514efe8594cdde3480f6858ba3
Attachment #8814535 - Flags: review?(s.kaspari) → review+

Comment 4

5 months ago
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b37f2a4bd333
Remove unnecessary boxing/unboxing; r=sebastian

Comment 5

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b37f2a4bd333
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.