[findbugs] [Bx] Boxing/unboxing to parse a primitive org.mozilla.gecko.push.Fetched.fromJSONObject(JSONObject)

RESOLVED FIXED in Firefox 53

Status

()

P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sebastian, Assigned: Shan11812, Mentored)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 53
All
Android
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [lang=java][good first bug])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Boxing/unboxing to parse a primitive org.mozilla.gecko.push.Fetched.fromJSONObject(JSONObject)

"A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method."
(Reporter)

Comment 1

2 years ago
To start, set up a build environment - you can see the instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

Then, you'll need to upload a patch - see:
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "sebastian" and you can find me and other helpful folks in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC
Comment hidden (mozreview-request)
(Reporter)

Updated

2 years ago
Assignee: nobody → 11812r
Status: NEW → ASSIGNED

Comment 4

2 years ago
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b37f2a4bd333
Remove unnecessary boxing/unboxing; r=sebastian

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b37f2a4bd333
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.