1316154 - allow testing that an async event comes before or after other events

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Trevor Saunders (:tbsaunde)]

There are cases where we want to test for several events, and while several
 may have a correct ordering some of the events can be fired in different
 orders WRT some but not all other events.  The only purpose of the
 orderChecker is to force that all preceeding checkers succeed before allowing
 any following checkers to match.

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: allow testing that an async event comes before or after other events

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8808816 [details] [diff] [review]
allow testing that an async event comes before or after other events

Deferring to Yura.

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8808816 [details] [diff] [review]
allow testing that an async event comes before or after other events

Review of attachment 8808816 [details] [diff] [review]:
-----------------------------------------------------------------

thanks, just 1 question and a couple of nits.

::: accessible/tests/mochitest/events.js
@@ +541,5 @@
> +        if (eventSeq[idx] instanceof orderChecker && haveUnmatchedAsync) {
> +            break;
> +        }
> +
> +        if (!eventSeq[idx].wasCaught) {

Do we not need to ensure that it is indeed an expected async event (and maybe that it's not a todo) to set this flag?

@@ +569,5 @@
> +        } else {
> +          break;
> +        }
> +      }
> +      }

nit: indentation

@@ +614,5 @@
>      while (aEventSeq.idx < aEventSeq.length &&
>             (aEventSeq[aEventSeq.idx].unexpected ||
>              aEventSeq[aEventSeq.idx].todo ||
>              aEventSeq[aEventSeq.idx].async ||
> +               aEventSeq[aEventSeq.idx] instanceof orderChecker ||

nit: indentation

@@ +1702,5 @@
>  /**
> +  * event checker that forces preceeding async events to happen before this
> +  * checker.
> +  */
> +  function orderChecker()

Nit: indentation here and the jsdoc above

@@ +1704,5 @@
> +  * checker.
> +  */
> +  function orderChecker()
> +{
> +  this__proto__ = new invokerChecker(null, null, null, false);

missing '.' between this and __proto__

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb47917f2457
allow testing that an async event comes before or after other events r=yzen

Comment 5

[Trevor Saunders (:tbsaunde)]

> ::: accessible/tests/mochitest/events.js
> @@ +541,5 @@
> > +        if (eventSeq[idx] instanceof orderChecker && haveUnmatchedAsync) {
> > +            break;
> > +        }
> > +
> > +        if (!eventSeq[idx].wasCaught) {
> 
> Do we not need to ensure that it is indeed an expected async event (and
> maybe that it's not a todo) to set this flag?

requiring sync events to happen first too seems reasonable, maybe not todo I'm not sure about that though, and since we don't need it right now I don't see much reason to worry about it.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cb47917f2457

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a9358cf3143
workaround don't actually set the prototype of orderChecker

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7a9358cf3143

Comment 9

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8808816 [details] [diff] [review]
allow testing that an async event comes before or after other events

test only dep of bug 1270916

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8808816 [details] [diff] [review]
allow testing that an async event comes before or after other events

Tests for big old e10s/a11y uplift, along with work from bug 1270916.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3873f6f9aacf
https://hg.mozilla.org/releases/mozilla-aurora/rev/a9fdf64f8f34