1425371 - Fix issues in accessible/tests/mochitest/events.js relating to redeclaring variables

Status: NEW

(Core :: Disability Access APIs, defect)

Description

[Mark Banner (:standard8)]

in bug 1425244 I have been trying to enable no-redeclare on accessible/tests/mochitest/events.js. However, the tests have been failing due to some strange issues. For now, no-redeclare is going to be disabled for that file, this bug should be fixed to resolve the issues.

Example issue:

accessible/tests/mochitest/actions/test_anchors.html
ReferenceError: eventSeq is not defined at eventQueue_handleEvent@chrome://mochitests/content/a11y/accessible/tests/mochitest/events.js:547:19

The diff from bug 1316154 looks a bit strange. This section is trying to parse an eventSeq:

https://searchfox.org/mozilla-central/diff/4dad35bd6005a6a466d026527b564669ccdb4a47/accessible/tests/mochitest/events.js#566

However, that seems to be assumed to come from:

https://searchfox.org/mozilla-central/diff/4dad35bd6005a6a466d026527b564669ccdb4a47/accessible/tests/mochitest/events.js#526

That makes it look like the lower section should be iterating over this.mScenarios, rather than just attempting to use the last item from around the loop.