1316193 - Convert XPCOM test TestThreadPoolListener to a gtest

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Eric Rahm [:erahm]]

Convert xpcom/tests/TestThreadPoolListener.cpp to a gtest and move to xpcom/tests/gtest/.

Comment 1

[Eric Rahm [:erahm]]

Attachment: Convert XPCOM test TestThreadPoolListener to a gtest

MozReview-Commit-ID: JiyYTGGuKJo

Comment 2

[Benjamin Smedberg]

Comment on attachment 8809111 [details] [diff] [review]
Convert XPCOM test TestThreadPoolListener to a gtest

+  EXPECT_TRUE(false) << "Too many threads!";

Should probably be FAIL() << " Too many threads!";

Comment 3

[Eric Rahm [:erahm]]

(In reply to Benjamin Smedberg [:bsmedberg] from comment #2)
> Comment on attachment 8809111 [details] [diff] [review]
> Convert XPCOM test TestThreadPoolListener to a gtest
> 
> +  EXPECT_TRUE(false) << "Too many threads!";
> 
> Should probably be FAIL() << " Too many threads!";

Fail doesn't work here as the function returns an nsresult.

Comment 4

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b10dbdd46d12c4f0d98a6e4c6a6a64adab8dfe22
Bug 1316193 - Convert XPCOM test TestThreadPoolListener to a gtest. r=bsmedberg

Comment 5

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e188cd4b2b72f41845908c93201f776673aef822
Bug 1316193 - Fix unified bustage. r=me ON A CLOSED TREE

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b10dbdd46d12
https://hg.mozilla.org/mozilla-central/rev/e188cd4b2b72