Closed Bug 1316193 Opened 5 years ago Closed 5 years ago

Convert XPCOM test TestThreadPoolListener to a gtest

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(1 file)

Convert xpcom/tests/TestThreadPoolListener.cpp to a gtest and move to xpcom/tests/gtest/.
MozReview-Commit-ID: JiyYTGGuKJo
Attachment #8809111 - Flags: review?(benjamin)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Comment on attachment 8809111 [details] [diff] [review]
Convert XPCOM test TestThreadPoolListener to a gtest

+  EXPECT_TRUE(false) << "Too many threads!";

Should probably be FAIL() << " Too many threads!";
Attachment #8809111 - Flags: review?(benjamin) → review+
(In reply to Benjamin Smedberg [:bsmedberg] from comment #2)
> Comment on attachment 8809111 [details] [diff] [review]
> Convert XPCOM test TestThreadPoolListener to a gtest
> 
> +  EXPECT_TRUE(false) << "Too many threads!";
> 
> Should probably be FAIL() << " Too many threads!";

Fail doesn't work here as the function returns an nsresult.
https://hg.mozilla.org/integration/mozilla-inbound/rev/b10dbdd46d12c4f0d98a6e4c6a6a64adab8dfe22
Bug 1316193 - Convert XPCOM test TestThreadPoolListener to a gtest. r=bsmedberg
https://hg.mozilla.org/mozilla-central/rev/b10dbdd46d12
https://hg.mozilla.org/mozilla-central/rev/e188cd4b2b72
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.