Closed Bug 1316195 Opened 3 years ago Closed 3 years ago

Convert XPCOM test TestRegistrationOrder to something other than a GeckoSimpleProgram

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(1 file)

Convert xpcom/tests/TestRegistrationOrder.cpp to something other than a GeckoSimpleProgram..

It's possible this could be converted to an xpcshell test. I'm not sure if it'll work as a gtest. Currently it's invoked by |make check| in xpcom/tests.
(In reply to Eric Rahm [:erahm] from comment #0)
> Convert xpcom/tests/TestRegistrationOrder.cpp to something other than a
> GeckoSimpleProgram..
> 
> It's possible this could be converted to an xpcshell test. I'm not sure if
> it'll work as a gtest. Currently it's invoked by |make check| in xpcom/tests.

I can't see a good way to convert this, I'm going to suggest removal.
Ben, this one is a bit more controversial. The test is currently run via
'make check' in xpcom/tests. I can't see a way to convert to another test
format, but if you have suggestions I'm happy to go that route.

MozReview-Commit-ID: 2CLSKxNukVj
Attachment #8809132 - Flags: review?(benjamin)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Attachment #8809132 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/3b77e4081775
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.