1316250 - Relax the rules for --help dependencies some more

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1316250 - Don't pretend imported modules in templates are inherited by functions they contain.

The current state of python configure sandbox execution is that if a
template imports a module, and a function defined in the template tries
to use the module, it doesn't work. Ideally, it would, but rather than
try to fix this corner case, we remove the unit tests that assume it
works (and consequently pass for half bad reasons), and add a unit test
so that the behavior doesn't change unwillingly.

Review commit: https://reviewboard.mozilla.org/r/91646/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91646/

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1316250 - Allow functions using the fake os module to not depend on --help.

Review commit: https://reviewboard.mozilla.org/r/91648/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91648/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8808925 [details]
Bug 1316250 - Don't pretend imported modules in templates are inherited by functions they contain.

https://reviewboard.mozilla.org/r/91646/#review91772

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8808926 [details]
Bug 1316250 - Allow functions using the fake os module to not depend on --help.

https://reviewboard.mozilla.org/r/91648/#review91774

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53f988e1c1fd
Don't pretend imported modules in templates are inherited by functions they contain. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/fb579bc49c2f
Allow functions using the fake os module to not depend on --help. r=chmanchester

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/53f988e1c1fd
https://hg.mozilla.org/mozilla-central/rev/fb579bc49c2f