Closed Bug 1316250 Opened 3 years ago Closed 3 years ago

Relax the rules for --help dependencies some more

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files)

No description provided.
Comment on attachment 8808925 [details]
Bug 1316250 - Don't pretend imported modules in templates are inherited by functions they contain.

https://reviewboard.mozilla.org/r/91646/#review91772
Attachment #8808925 - Flags: review?(cmanchester) → review+
Comment on attachment 8808926 [details]
Bug 1316250 - Allow functions using the fake os module to not depend on --help.

https://reviewboard.mozilla.org/r/91648/#review91774
Attachment #8808926 - Flags: review?(cmanchester) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/53f988e1c1fd
Don't pretend imported modules in templates are inherited by functions they contain. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/fb579bc49c2f
Allow functions using the fake os module to not depend on --help. r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/53f988e1c1fd
https://hg.mozilla.org/mozilla-central/rev/fb579bc49c2f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.