Closed
Bug 1313306
Opened 6 years ago
Closed 6 years ago
Relax the rules for --help dependencies
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox52 fixed)
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
(Blocks 2 open bugs)
Details
Attachments
(6 files)
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
Before my cleaned-up patch queue grows too deep, let's get what is ready to land landed. The patch series I'm going to push ends up removing many dummy invisible --help dependencies: down from 215 to 33.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 19•6 years ago
|
||
mozreview-review |
Comment on attachment 8805024 [details] Bug 1313306 - Add a placeholder python configure linter. https://reviewboard.mozilla.org/r/88846/#review88610 ::: python/mozbuild/mozbuild/configure/lint.py:7 (Diff revision 3) > +import inspect > +from StringIO import StringIO > +from collections import defaultdict > +from contextlib import contextmanager Some of these imports seem to belong in a later commit. ::: python/mozbuild/mozbuild/test/configure/lint.py:9 (Diff revision 3) > + > +from __future__ import absolute_import, print_function, unicode_literals > + > +import os > +import unittest > +from StringIO import StringIO This import isn't used in this commit.
Comment 20•6 years ago
|
||
mozreview-review |
Comment on attachment 8805024 [details] Bug 1313306 - Add a placeholder python configure linter. https://reviewboard.mozilla.org/r/88846/#review88614
Attachment #8805024 -
Flags: review?(cmanchester) → review+
Comment 21•6 years ago
|
||
mozreview-review |
Comment on attachment 8805025 [details] Bug 1313306 - Move --help dependency checks to the linter. https://reviewboard.mozilla.org/r/88848/#review88620
Attachment #8805025 -
Flags: review?(cmanchester) → review+
Comment 22•6 years ago
|
||
mozreview-review |
Comment on attachment 8805026 [details] Bug 1313306 - Don't expose os.path.{exists,isdir,isfile} to python configure without an @imports. https://reviewboard.mozilla.org/r/88850/#review88622 ::: python/mozbuild/mozbuild/test/configure/common.py:91 (Diff revision 3) > > vfs = ConfigureTestVFS(paths) > > - self.OS = ReadOnlyNamespace(path=ReadOnlyNamespace(**{ > - k: v if k not in ('exists', 'isfile') > - else getattr(vfs, k) > + os_path = { > + k: getattr(vfs, k) > + for k in dir(vfs) This could probably fit on the line above.
Attachment #8805026 -
Flags: review?(cmanchester) → review+
Comment 23•6 years ago
|
||
mozreview-review |
Comment on attachment 8805027 [details] Bug 1313306 - Relax the rules for --help dependencies. https://reviewboard.mozilla.org/r/88852/#review88634
Attachment #8805027 -
Flags: review?(cmanchester) → review+
Comment 24•6 years ago
|
||
mozreview-review |
Comment on attachment 8805028 [details] Bug 1313306 - Allow @depends(when=something) without additional dependencies. https://reviewboard.mozilla.org/r/88854/#review88636 ::: python/mozbuild/mozbuild/configure/__init__.py:288 (Diff revision 3) > + self._always = DependsFunction(self, lambda: True, []) > + self._never = DependsFunction(self, lambda: False, []) > + The prior commit seems to mentions these attributes... does this commit actually go first?
Attachment #8805028 -
Flags: review?(cmanchester) → review+
Comment 25•6 years ago
|
||
mozreview-review |
Comment on attachment 8805029 [details] Bug 1313306 - Remove --help dependencies from @dependable and delayed_getattr. https://reviewboard.mozilla.org/r/88856/#review88638
Attachment #8805029 -
Flags: review?(cmanchester) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 45•6 years ago
|
||
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/caf5e078e7ef Add a placeholder python configure linter. r=chmanchester https://hg.mozilla.org/integration/autoland/rev/0e64d3d27520 Move --help dependency checks to the linter. r=chmanchester https://hg.mozilla.org/integration/autoland/rev/b6be0e9e3e1e Don't expose os.path.{exists,isdir,isfile} to python configure without an @imports. r=chmanchester https://hg.mozilla.org/integration/autoland/rev/a801ef597f1f Relax the rules for --help dependencies. r=chmanchester https://hg.mozilla.org/integration/autoland/rev/0ac9e88ff47b Allow @depends(when=something) without additional dependencies. r=chmanchester https://hg.mozilla.org/integration/autoland/rev/8158226d06a0 Remove --help dependencies from @dependable and delayed_getattr. r=chmanchester
Comment 46•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/caf5e078e7ef https://hg.mozilla.org/mozilla-central/rev/0e64d3d27520 https://hg.mozilla.org/mozilla-central/rev/b6be0e9e3e1e https://hg.mozilla.org/mozilla-central/rev/a801ef597f1f https://hg.mozilla.org/mozilla-central/rev/0ac9e88ff47b https://hg.mozilla.org/mozilla-central/rev/8158226d06a0
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment 47•6 years ago
|
||
Seems odd that a relaxing rules bug results in build failures.
Updated•5 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•