Relax the rules for --help dependencies

RESOLVED FIXED in Firefox 52

Status

()

Core
Build Config
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(6 attachments)

(Assignee)

Description

a year ago
Before my cleaned-up patch queue grows too deep, let's get what is ready to land landed. The patch series I'm going to push ends up removing many dummy invisible --help dependencies: down from 215 to 33.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 19

a year ago
mozreview-review
Comment on attachment 8805024 [details]
Bug 1313306 - Add a placeholder python configure linter.

https://reviewboard.mozilla.org/r/88846/#review88610

::: python/mozbuild/mozbuild/configure/lint.py:7
(Diff revision 3)
> +import inspect
> +from StringIO import StringIO
> +from collections import defaultdict
> +from contextlib import contextmanager

Some of these imports seem to belong in a later commit.

::: python/mozbuild/mozbuild/test/configure/lint.py:9
(Diff revision 3)
> +
> +from __future__ import absolute_import, print_function, unicode_literals
> +
> +import os
> +import unittest
> +from StringIO import StringIO

This import isn't used in this commit.

Comment 20

a year ago
mozreview-review
Comment on attachment 8805024 [details]
Bug 1313306 - Add a placeholder python configure linter.

https://reviewboard.mozilla.org/r/88846/#review88614
Attachment #8805024 - Flags: review?(cmanchester) → review+

Comment 21

a year ago
mozreview-review
Comment on attachment 8805025 [details]
Bug 1313306 - Move --help dependency checks to the linter.

https://reviewboard.mozilla.org/r/88848/#review88620
Attachment #8805025 - Flags: review?(cmanchester) → review+

Comment 22

a year ago
mozreview-review
Comment on attachment 8805026 [details]
Bug 1313306 - Don't expose os.path.{exists,isdir,isfile} to python configure without an @imports.

https://reviewboard.mozilla.org/r/88850/#review88622

::: python/mozbuild/mozbuild/test/configure/common.py:91
(Diff revision 3)
>  
>          vfs = ConfigureTestVFS(paths)
>  
> -        self.OS = ReadOnlyNamespace(path=ReadOnlyNamespace(**{
> -            k: v if k not in ('exists', 'isfile')
> -            else getattr(vfs, k)
> +        os_path = {
> +            k: getattr(vfs, k)
> +            for k in dir(vfs)

This could probably fit on the line above.
Attachment #8805026 - Flags: review?(cmanchester) → review+

Comment 23

a year ago
mozreview-review
Comment on attachment 8805027 [details]
Bug 1313306 - Relax the rules for --help dependencies.

https://reviewboard.mozilla.org/r/88852/#review88634
Attachment #8805027 - Flags: review?(cmanchester) → review+

Comment 24

a year ago
mozreview-review
Comment on attachment 8805028 [details]
Bug 1313306 - Allow @depends(when=something) without additional dependencies.

https://reviewboard.mozilla.org/r/88854/#review88636

::: python/mozbuild/mozbuild/configure/__init__.py:288
(Diff revision 3)
> +        self._always = DependsFunction(self, lambda: True, [])
> +        self._never = DependsFunction(self, lambda: False, [])
> +

The prior commit seems to mentions these attributes... does this commit actually go first?
Attachment #8805028 - Flags: review?(cmanchester) → review+

Comment 25

a year ago
mozreview-review
Comment on attachment 8805029 [details]
Bug 1313306 - Remove --help dependencies from @dependable and delayed_getattr.

https://reviewboard.mozilla.org/r/88856/#review88638
Attachment #8805029 - Flags: review?(cmanchester) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 45

a year ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/caf5e078e7ef
Add a placeholder python configure linter. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/0e64d3d27520
Move --help dependency checks to the linter. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/b6be0e9e3e1e
Don't expose os.path.{exists,isdir,isfile} to python configure without an @imports. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/a801ef597f1f
Relax the rules for --help dependencies. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/0ac9e88ff47b
Allow @depends(when=something) without additional dependencies. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/8158226d06a0
Remove --help dependencies from @dependable and delayed_getattr. r=chmanchester
Depends on: 1314934
Seems odd that a relaxing rules bug results in build failures.

Updated

a year ago
Depends on: 1314894
(Assignee)

Updated

a year ago
Blocks: 1316250
(Assignee)

Updated

a year ago
Blocks: 1316844
You need to log in before you can comment on or make changes to this bug.