Closed Bug 1316267 Opened 7 years ago Closed 7 years ago

Crash in mozilla::layers::ShadowLayerChild::ActorDestroy

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Version:
53 Branch
Platform:
Unspecified
Windows
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1319271
Tracking Flags:
Tracking Status
firefox-esr45 --- unaffected
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 + fixed

People

(Reporter: ting, Assigned: dvander)

References

Details

(Keywords: crash, regression, topcrash, Whiteboard: [gfx-noted])

Crash Data

Attachments

(1 file)

bug1316267.patch
2.80 KB, patch
billm
: review+
Details | Diff | Splinter Review 
This bug was filed from the Socorro interface and is 
report bp-ac18f9de-8b74-4857-9dc6-0f8652161108.
=============================================================
#47 top crash on Windows for Nightly 20161106030203, 4 crashes from 4 installations. There were only 2 crashes with the signature before the build, so it is likely caused by a recent push.
This was almost certainly bug 1314349 - no more crashes after that landed.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Whiteboard: [gfx-noted]
[Tracking Requested - why for this release]:

This has come back. First reappearance is in Nightly 20161208075029, and since then it has occurred 300+ times on 200+ installations, making it the #1 non-shutdown-hang topcrash. The changes in that nightly build are here:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c401d72933641748f3738e90e7bbe539705e2f1c&tochange=d8f63b2935af0915a6a24b3ea8e27d9a09f66416

but I don't see any obvious likely causes.

All the reports I looked at had stack traces involving |AbnormalShutdown| in ActorDestroy().

dvander, can you please investigate?
Status: RESOLVED → REOPENED
tracking-firefox53: --- → ?
Flags: needinfo?(dvander)
Keywords: regression, topcrash
Resolution: DUPLICATE → ---
This is a new bug... as originally filed this was a dupe. bug 1319271 probably caused a regression.

ShadowLayerChild's has a reference back to a ClientLayer. This reference is removed in ClientLayer's destructor [1]. When ShadowLayerChild is destroyed by IPDL, if IPDL is aborting due to an error, we expect that the ClientLayer is still valid [2].

This worked before bug 1319271 because if we failed to send a delete message, the actor would be immediately destroyed with |why==Deletion|, and we would never attempt to touch mLayer. After bug 1319271, the actor is left in the actor map, so ClientLayer is destroyed and ShadowLayer's reference is never cleared. Later we'll get a why==AbnormalShutdown and crash.

This is easy to fix in layers (we should disconnect the reference unconditionally, instead of in ActorDestroy). On the other hand, this is a pretty significant change to IPDL semantics. Kan-Ru is on PTO, so Bill: should we audit other __delete__ users?

[1] http://searchfox.org/mozilla-central/rev/5ee2bd8800b007d6c120d9521d5bf01131885afb/gfx/layers/client/ClientLayerManager.cpp#900
[2] http://searchfox.org/mozilla-central/rev/5ee2bd8800b007d6c120d9521d5bf01131885afb/gfx/layers/ipc/ShadowLayerChild.cpp#35
Assignee: nobody → dvander
Status: REOPENED → ASSIGNED
Depends on: 1319271
Flags: needinfo?(dvander) → needinfo?(wmccloskey)
Ugh. I think the best thing to do is to land Kan-Ru's original patch in bug 1319271 ("Use actor's manager in case actor is already deleted.") and back out the other patch.

I don't think that the assumption that ActorDestroy runs immediately after Send__delete__ is warranted. But auditing the code would be pretty difficult.
Flags: needinfo?(wmccloskey)
Attached patch bug1316267.patch — — Splinter Review 
I think this should work whether or not the ShadowLayerChild is actually destroyed on Send.
Attachment #8818142 - Flags: review?(wmccloskey)
Comment on attachment 8818142 [details] [diff] [review]
bug1316267.patch

Review of attachment 8818142 [details] [diff] [review]:
-----------------------------------------------------------------

I guess it's good to fix this anyway.
Attachment #8818142 - Flags: review?(wmccloskey) → review+
Tracking 53+ for this regression top crash.
tracking-firefox53: ? → +
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2dbb8f9f082
Unconditionally disconnect PLayerChildren from ClientLayers. (bug 1316267, r=billm)
Backout by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd90710cece4
Backed out changeset f2dbb8f9f082 for mass bustage. r=backout on a CLOSED TREE
Backed out for mass bustage:

https://hg.mozilla.org/integration/mozilla-inbound/rev/dd90710cece47e332fd4e1726954c32db362244a

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=f2dbb8f9f082f0806b428f22bfbfc83638d6aae8
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=40547357&repo=mozilla-inbound

14:04:22  WARNING -  PROCESS-CRASH | remoteautomation.py | application crashed [@ __libc_android_abort]
14:04:22     INFO -  Crash dump filename: /tmp/tmpRuywWU/60dee42b-53a0-d651-6e7cc912-2625f0a1.dmp
14:04:22     INFO -  Operating system: Android
14:04:22     INFO -                    0.0.0 Linux 2.6.29-gea477bb #1 Wed Sep 26 11:04:45 PDT 2012 armv7l
14:04:22     INFO -  CPU: arm
14:04:22     INFO -       ARMv7 ARM Cortex-A8 features: swp,half,thumb,fastmult,vfpv2,edsp,neon,vfpv3
14:04:22     INFO -       1 CPU
14:04:22     INFO -  GPU: UNKNOWN
14:04:22     INFO -  Crash reason:  SIGSEGV
14:04:22     INFO -  Crash address: 0xdeadbaad
14:04:22     INFO -  Process uptime: not available
14:04:22     INFO -  Thread 11 (crashed)
14:04:22     INFO -   0  libc.so!__libc_android_abort [abort.c : 81 + 0x0]
14:04:22     INFO -       r0 = 0x00000027    r1 = 0x00000000    r2 = 0x00000000    r3 = 0xdeadbaad
14:04:22     INFO -       r4 = 0x00000000    r5 = 0x5295e60c    r6 = 0x57632922    r7 = 0x57b81ed0
14:04:22     INFO -       r8 = 0x5295eb37    r9 = 0x5295eb38   r10 = 0x00000000   r12 = 0x57b81ed0
14:04:22     INFO -       fp = 0x5295ea94    sp = 0x5295e608    lr = 0x40047fcb    pc = 0x40045524
14:04:22     INFO -      Found by: given as instruction pointer in context
14:04:22     INFO -   1  libc.so + 0x1c4e6
14:04:22     INFO -       r4 = 0x5295e64c    r5 = 0x0000004a    r6 = 0x57632922    r7 = 0x57b81ed0
14:04:22     INFO -       r8 = 0x5295eb37    r9 = 0x5295eb38   r10 = 0x00000000    fp = 0x5295ea94
14:04:22     INFO -       sp = 0x5295e630    pc = 0x400434e8
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -   2  libc.so!__libc_fatal [libc_logging.cpp : 506 + 0x3]
14:04:22     INFO -       sp = 0x5295e638    pc = 0x400391ad
14:04:22     INFO -      Found by: stack scanning
14:04:22     INFO -   3  libc.so!__assert2 [assert.cpp : 41 + 0xd]
14:04:22     INFO -       r0 = 0x40064eb5    r1 = 0x57632922    r2 = 0x0000004a    r3 = 0x576329cf
14:04:22     INFO -       r4 = 0x576329cf    sp = 0x5295ea68    pc = 0x400386bd
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -   4  libxul.so!abort_message [abort_message.cpp : 74 + 0xe]
14:04:22     INFO -       r0 = 0x5bf82aa0    r1 = 0x0000004a    r2 = 0x576329cf    r4 = 0x576329cf
14:04:22     INFO -       sp = 0x5295ea78    pc = 0x57340af8
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -   5  libxul.so!__cxa_pure_virtual [cxa_virtual.cpp : 21 + 0x12]
14:04:22     INFO -       sp = 0x5295ea9c    pc = 0x57335910
14:04:22     INFO -      Found by: stack scanning
14:04:22     INFO -   6  libxul.so!readEncodedPointer [cxa_personality.cpp : 292 + 0x6]
14:04:22     INFO -       sp = 0x5295eaa8    pc = 0x573358f0
14:04:22     INFO -      Found by: stack scanning
14:04:22     INFO -   7  libxul.so!mozilla::layers::ShadowLayerChild::Disconnect [ShadowLayerChild.cpp:f2dbb8f9f082 : 47 + 0x5]
14:04:22     INFO -       sp = 0x5295eab0    pc = 0x55f45417
14:04:22     INFO -      Found by: stack scanning
14:04:22     INFO -   8  libxul.so!mozilla::layers::ShadowLayerChild::Destroy [ShadowLayerChild.cpp:f2dbb8f9f082 : 56 + 0x3]
14:04:22     INFO -       r4 = 0x5bf82a60    sp = 0x5295eab8    pc = 0x55f45435
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -   9  libxul.so!mozilla::layers::ClientLayer::~ClientLayer [ClientLayerManager.cpp:f2dbb8f9f082 : 900 + 0x3]
14:04:22     INFO -       r4 = 0x5ea10644    sp = 0x5295eac0    pc = 0x55f1dcd5
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  10  libxul.so!mozilla::layers::ClientTiledPaintedLayer::~ClientTiledPaintedLayer [ClientTiledPaintedLayer.cpp:f2dbb8f9f082 : 43 + 0x7]
14:04:22     INFO -       r4 = 0x5ea10400    sp = 0x5295eac8    pc = 0x55f1ec03
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  11  libxul.so!mozilla::layers::ClientTiledPaintedLayer::~ClientTiledPaintedLayer [ClientTiledPaintedLayer.cpp:f2dbb8f9f082 : 46 + 0x3]
14:04:22     INFO -       r4 = 0x5ea10400    sp = 0x5295ead0    pc = 0x55f1ec35
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  12  libxul.so!RefPtr<mozilla::layers::Layer>::~RefPtr [Layers.h:f2dbb8f9f082 : 752 + 0x3]
14:04:22     INFO -       r4 = 0x5eafd5e4    sp = 0x5295ead8    pc = 0x55eec9dd
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  13  libxul.so!nsTArray_Impl<RefPtr<mozilla::layers::Layer>, nsTArrayInfallibleAllocator>::Clear [nsTArray.h:f2dbb8f9f082 : 676 + 0x3]
14:04:22     INFO -       r4 = 0x5eafd5e8    sp = 0x5295eae0    pc = 0x55f1fa51
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  14  libxul.so!mozilla::layers::ClientLayerManager::ForwardTransaction [ClientLayerManager.cpp:f2dbb8f9f082 : 723 + 0x3]
14:04:22     INFO -       r4 = 0x5bbda000    r5 = 0x5295eb50    r6 = 0x00000000    r7 = 0x57b81ed0
14:04:22     INFO -       sp = 0x5295eb00    pc = 0x55f1fda7
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  15  libxul.so!mozilla::layers::ClientLayerManager::EndTransaction [ClientLayerManager.cpp:f2dbb8f9f082 : 380 + 0xd]
14:04:22     INFO -       r4 = 0x5bbda000    r5 = 0x00000000    r6 = 0x5295f0c8    r7 = 0x568e81e1
14:04:22     INFO -       r8 = 0x00000000    r9 = 0x00000000   r10 = 0x00000000    fp = 0x5eafd500
14:04:22     INFO -       sp = 0x5295ed18    pc = 0x55f25aad
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  16  libxul.so!nsDisplayList::PaintRoot [nsDisplayList.cpp:f2dbb8f9f082 : 2069 + 0xf]
14:04:22     INFO -       r3 = 0x00000000    r4 = 0x5295f0c8    r5 = 0x5bd72400    r6 = 0x5295ed88
14:04:22     INFO -       r7 = 0x5295ed8c    r8 = 0x00000000    r9 = 0x00000000   r10 = 0x00000000
14:04:22     INFO -       fp = 0x5eafd500    sp = 0x5295ed30    pc = 0x568ec073
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  17  libxul.so!nsLayoutUtils::PaintFrame [nsLayoutUtils.cpp:f2dbb8f9f082 : 3642 + 0xf]
14:04:22     INFO -       r4 = 0x5bd52758    r5 = 0x0000000d    r6 = 0x5295f038    r7 = 0x5295efc0
14:04:22     INFO -       r8 = 0x5295efb0    r9 = 0x00000000   r10 = 0x00000000    fp = 0x00000184
14:04:22     INFO -       sp = 0x5295ef70    pc = 0x567e0cef
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  18  libxul.so!mozilla::PresShell::Paint [PresShell.cpp:f2dbb8f9f082 : 6368 + 0xf]
14:04:22     INFO -       r4 = 0x5bbda000    r5 = 0x55219d40    r6 = 0x5b85bfa0    r7 = 0x5bd52758
14:04:22     INFO -       r8 = 0x00000001    r9 = 0x00000000   r10 = 0x00000000    fp = 0x00000000
14:04:22     INFO -       sp = 0x5295f5d0    pc = 0x567b6b67
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  19  libxul.so!nsViewManager::ProcessPendingUpdatesPaint [nsViewManager.cpp:f2dbb8f9f082 : 484 + 0x9]
14:04:22     INFO -       r4 = 0x5b85bfa0    r5 = 0x55219d40    r6 = 0x5bd41eb0    r7 = 0x5b9dc640
14:04:22     INFO -       r8 = 0x5295f65c    r9 = 0x567b6a01   r10 = 0x575069cf    fp = 0x00d5a429
14:04:22     INFO -       sp = 0x5295f658    pc = 0x566b6f2f
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  20  libxul.so!nsViewManager::ProcessPendingUpdatesForView [nsViewManager.cpp:f2dbb8f9f082 : 415 + 0x7]
14:04:22     INFO -       r4 = 0x5295f694    r5 = 0x00000000    r6 = 0x5295f690    r7 = 0x5bd41eb0
14:04:22     INFO -       r8 = 0x5b9dc640    r9 = 0x00000001   r10 = 0x575069cf    fp = 0x00d5a429
14:04:22     INFO -       sp = 0x5295f690    pc = 0x566b7045
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  21  libxul.so!nsViewManager::ProcessPendingUpdates [nsViewManager.cpp:f2dbb8f9f082 : 1118 + 0x9]
14:04:22     INFO -       r4 = 0x5bd41eb0    r5 = 0x5295f708    r6 = 0x55245ca0    r7 = 0x5bd41eb0
14:04:22     INFO -       r8 = 0x00000000    r9 = 0x00000000   r10 = 0x575069cf    fp = 0x00d5a429
14:04:22     INFO -       sp = 0x5295f6b8    pc = 0x566b70e3
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  22  libxul.so!nsRefreshDriver::Tick [nsRefreshDriver.cpp:f2dbb8f9f082 : 2018 + 0x5]
14:04:22     INFO -       r4 = 0x5295f768    r5 = 0x5295f708    r6 = 0x55245ca0    r7 = 0x5bd41eb0
14:04:22     INFO -       r8 = 0x00000000    r9 = 0x00000000   r10 = 0x575069cf    fp = 0x00d5a429
14:04:22     INFO -       sp = 0x5295f6c0    pc = 0x567ac597
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  23  libxul.so!mozilla::RefreshDriverTimer::TickRefreshDrivers [nsRefreshDriver.cpp:f2dbb8f9f082 : 295 + 0x11]
14:04:22     INFO -       r4 = 0x00000000    r5 = 0x5295f7f4    r6 = 0x00000001    r7 = 0x55245ca0
14:04:22     INFO -       r8 = 0x66251d70    r9 = 0x00054391   r10 = 0x5bd32bf0    fp = 0x5295fb75
14:04:22     INFO -       sp = 0x5295f7e8    pc = 0x567ac8e5
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  24  libxul.so!mozilla::RefreshDriverTimer::Tick [nsRefreshDriver.cpp:f2dbb8f9f082 : 317 + 0x13]
14:04:22     INFO -       r4 = 0x5bd32bf0    r5 = 0x575c8a14    r6 = 0x337ac506    r7 = 0x00000027
14:04:22     INFO -       r8 = 0x66251d70    r9 = 0x00054391   r10 = 0x00000000    fp = 0x5295fb75
14:04:22     INFO -       sp = 0x5295f818    pc = 0x567ac979
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  25  libxul.so!mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::TickRefreshDriver [nsRefreshDriver.cpp:f2dbb8f9f082 : 669 + 0xd]
14:04:22     INFO -       r4 = 0x5bd32bf0    r5 = 0x5295f860    r6 = 0x5295f868    r7 = 0x00000027
14:04:22     INFO -       r8 = 0x662536c9    r9 = 0x00054391   r10 = 0x00000000    fp = 0x5295fb75
14:04:22     INFO -       sp = 0x5295f848    pc = 0x567aca9d
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  26  libxul.so!mozilla::detail::RunnableMethodImpl<void (mozilla::MediaDecoderStateMachine::*)(double), true, false, double>::Run [nsThreadUtils.h:f2dbb8f9f082 : 791 + 0x1]
14:04:22     INFO -       r4 = 0x52d23020    r5 = 0x00000000    r6 = 0x5295f8b0    r7 = 0x00000001
14:04:22     INFO -       r8 = 0x5295f8ff    r9 = 0x5295f8b4   r10 = 0x00000000    fp = 0x5295fb75
14:04:22     INFO -       sp = 0x5295f898    pc = 0x55b2f1f9
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  27  libxul.so!nsThread::ProcessNextEvent [nsThread.cpp:f2dbb8f9f082 : 1213 + 0x3]
14:04:22     INFO -       r4 = 0x52d23020    r5 = 0x00000000    r6 = 0x5295f8b0    r7 = 0x00000001
14:04:22     INFO -       r8 = 0x5295f8ff    r9 = 0x5295f8b4   r10 = 0x00000000    fp = 0x5295fb75
14:04:22     INFO -       sp = 0x5295f8a0    pc = 0x55a9f4e7
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  28  libxul.so!NS_ProcessNextEvent [nsThreadUtils.cpp:f2dbb8f9f082 : 381 + 0xb]
14:04:22     INFO -       r4 = 0x00000000    r5 = 0x00000001    r6 = 0x52d16060    r7 = 0x52d23020
14:04:22     INFO -       r8 = 0x52d10500    r9 = 0x5295f994   r10 = 0x5295f998    fp = 0x5295fb75
14:04:22     INFO -       sp = 0x5295f8f8    pc = 0x55ab1e41
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  29  libxul.so!mozilla::ipc::MessagePump::Run [MessagePump.cpp:f2dbb8f9f082 : 96 + 0x7]
14:04:22     INFO -       r4 = 0x52d104f0    r5 = 0x00000001    r6 = 0x52d16060    r7 = 0x52d23020
14:04:22     INFO -       r8 = 0x52d10500    r9 = 0x5295f994   r10 = 0x5295f998    fp = 0x5295fb75
14:04:22     INFO -       sp = 0x5295f908    pc = 0x55c0fd9d
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  30  libxul.so!MessageLoop::Run [message_loop.cc:f2dbb8f9f082 : 225 + 0x5]
14:04:22     INFO -       r4 = 0x52d16060    r5 = 0x54f37580    r6 = 0x52d23020    r7 = 0x5295f9a8
14:04:22     INFO -       r8 = 0x5295f99c    r9 = 0x5295f994   r10 = 0x5295f998    fp = 0x5295fb75
14:04:22     INFO -       sp = 0x5295f938    pc = 0x55c00e03
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  31  libxul.so!nsBaseAppShell::Run [nsBaseAppShell.cpp:f2dbb8f9f082 : 156 + 0x3]
14:04:22     INFO -       r4 = 0x00000000    r5 = 0x54f37580    r6 = 0x52d23020    r7 = 0x5295f9a8
14:04:22     INFO -       r8 = 0x5295f99c    r9 = 0x5295f994   r10 = 0x5295f998    fp = 0x5295fb75
14:04:22     INFO -       sp = 0x5295f950    pc = 0x566c6acf
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  32  libxul.so!nsAppStartup::Run [nsAppStartup.cpp:f2dbb8f9f082 : 283 + 0x3]
14:04:22     INFO -       r4 = 0x55020430    r5 = 0x5295f9b4    r6 = 0x5295fa80    r7 = 0x5295f9a8
14:04:22     INFO -       r8 = 0x5295f99c    r9 = 0x5295f994   r10 = 0x5295f998    fp = 0x5295fb75
14:04:22     INFO -       sp = 0x5295f960    pc = 0x56ab3e5b
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  33  libxul.so!XREMain::XRE_mainRun [nsAppRunner.cpp:f2dbb8f9f082 : 4483 + 0x3]
14:04:22     INFO -       r4 = 0x5295f9d4    r5 = 0x5295f9b4    r6 = 0x5295fa80    r7 = 0x5295f9a8
14:04:22     INFO -       r8 = 0x5295f99c    r9 = 0x5295f994   r10 = 0x5295f998    fp = 0x5295fb75
14:04:22     INFO -       sp = 0x5295f968    pc = 0x56ae923b
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  34  libxul.so!XREMain::XRE_main [nsAppRunner.cpp:f2dbb8f9f082 : 4612 + 0x5]
14:04:22     INFO -       r4 = 0x00000000    r5 = 0x5295fa80    r6 = 0x00000000    r7 = 0x5295fa58
14:04:22     INFO -       r8 = 0x00000006    r9 = 0x0000400c   r10 = 0x24d00005    fp = 0x20900009
14:04:22     INFO -       sp = 0x5295fa50    pc = 0x56ae94e1
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  35  libxul.so!XRE_main [nsAppRunner.cpp:f2dbb8f9f082 : 4703 + 0x3]
14:04:22     INFO -       r4 = 0x00000000    r5 = 0x5295fb94    r6 = 0x52d0b8e0    r7 = 0x00000006
14:04:22     INFO -       r8 = 0x52803b08    r9 = 0x52d0b8e0   r10 = 0x24d00005    fp = 0x20900009
14:04:22     INFO -       sp = 0x5295fa80    pc = 0x56ae96d1
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  36  libxul.so!GeckoStart [nsAndroidStartup.cpp:f2dbb8f9f082 : 48 + 0xb]
14:04:22     INFO -       r4 = 0x00000000    r5 = 0x5295fb94    r6 = 0x52d0b8e0    r7 = 0x00000006
14:04:22     INFO -       r8 = 0x52803b08    r9 = 0x52d0b8e0   r10 = 0x24d00005    fp = 0x20900009
14:04:22     INFO -       sp = 0x5295fb90    pc = 0x56aea8bd
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  37  libmozglue.so!Java_org_mozilla_gecko_mozglue_GeckoLoader_nativeRun [APKOpen.cpp:f2dbb8f9f082 : 466 + 0x5]
14:04:22     INFO -       r4 = 0x52d0b8e0    r5 = 0x00000006    r6 = 0x2a1e7b80    r7 = 0x56aea849
14:04:22     INFO -       r8 = 0x528061ac    r9 = 0x52d0b8e0   r10 = 0x24d00005    fp = 0x20900009
14:04:22     INFO -       sp = 0x5295fbe8    pc = 0x5277ab89
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  38  libdvm.so + 0x1dc4e
14:04:22     INFO -       r4 = 0x4c790108    r5 = 0x2a1e6fd8    r6 = 0x00000000    r7 = 0x5285ffbc
14:04:22     INFO -       r8 = 0x5295fc24    r9 = 0x5285ffb0   r10 = 0x2a1e6fe8    fp = 0x5295fc3c
14:04:22     INFO -       sp = 0x5295fc20    pc = 0x4085bc50
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  39  libdvm.so + 0x48dc3
14:04:22     INFO -       sp = 0x5295fc28    pc = 0x40886dc5
14:04:22     INFO -      Found by: stack scanning
14:04:22     INFO -  40  data@app@org.mozilla.fennec-1.apk@classes.dex + 0x544df3
14:04:22     INFO -       sp = 0x5295fc34    pc = 0x5242ddf5
14:04:22     INFO -      Found by: stack scanning
14:04:22     INFO -  41  dalvik-heap (deleted) + 0x2c9a6e
14:04:22     INFO -       sp = 0x5295fc38    pc = 0x4177ea70
14:04:22     INFO -      Found by: stack scanning
14:04:22     INFO -  42  dalvik-heap (deleted) + 0x2d0336
14:04:22     INFO -       sp = 0x5295fc3c    pc = 0x41785338
14:04:22     INFO -      Found by: stack scanning
14:04:22     INFO -  43  libdvm.so + 0x4dcad
14:04:22     INFO -       sp = 0x5295fc40    pc = 0x4088bcaf
14:04:22     INFO -      Found by: stack scanning
14:04:22     INFO -  44  data@app@org.mozilla.fennec-1.apk@classes.dex + 0x544def
14:04:22     INFO -       sp = 0x5295fc48    pc = 0x5242ddf1
14:04:22     INFO -      Found by: stack scanning
14:04:22     INFO -  45  libmozglue.so!Java_org_mozilla_gecko_mozglue_GeckoLoader_loadNSSLibsNative [APKOpen.cpp:f2dbb8f9f082 : 405 + 0x1d]
14:04:22     INFO -       sp = 0x5295fc4c    pc = 0x5277aabd
14:04:22     INFO -      Found by: stack scanning
14:04:22     INFO -  46  0x26ffffff
14:04:22     INFO -       r4 = 0x2a1e6fe8    r5 = 0x2a27dec8    r6 = 0x2a27ded0    sp = 0x5295fc5c
14:04:22     INFO -       pc = 0x27000001
14:04:22     INFO -      Found by: call frame info
14:04:22     INFO -  47  libmozglue.so!Java_org_mozilla_gecko_mozglue_GeckoLoader_loadNSSLibsNative [APKOpen.cpp:f2dbb8f9f082 : 405 + 0x1d]
14:04:22     INFO -       sp = 0x5295fc8c    pc = 0x5277aabd
14:04:22     INFO -      Found by: stack scanning
Flags: needinfo?(dvander)
#1 topcrash in Firefox 53.0a1 accounting for nearly 12% of the overall crash volume on that version.

Correlations:
> (94.40% in signature vs 10.61% overall) Module "explorerframe.dll" = true
> (94.65% in signature vs 11.91% overall) Module "nssckbi.dll" = true
> (94.40% in signature vs 11.93% overall) Module "nssdbm3.dll" = true
> (94.89% in signature vs 14.28% overall) Module "winsta.dll" = true
> (92.70% in signature vs 12.09% overall) Module "FWPUCLNT.DLL" = true
> (92.70% in signature vs 12.28% overall) Module "rasadhlp.dll" = true
> (99.76% in signature vs 24.22% overall) reason = EXCEPTION_ACCESS_VIOLATION_READ
> (82.97% in signature vs 05.64% overall) address = 0xffffffffffffffff
> (76.64% in signature vs 07.06% overall) Module "twinapi.dll" = true
> (79.32% in signature vs 11.13% overall) Module "fastprox.dll" = true
> (79.32% in signature vs 11.14% overall) Module "wbemsvc.dll" = true
> (79.32% in signature vs 11.23% overall) Module "wbemprox.dll" = true
> (78.10% in signature vs 11.03% overall) Module "wbemcomn.dll" = true
> (73.72% in signature vs 07.15% overall) Module "linkinfo.dll" = true
> (73.72% in signature vs 07.41% overall) Module "cscapi.dll" = true
> (73.48% in signature vs 07.36% overall) Module "ntshrui.dll" = true
> (77.62% in signature vs 13.02% overall) Module "srvcli.dll" = true
> (98.30% in signature vs 37.01% overall) os_arch = amd64
> (71.05% in signature vs 08.70% overall) Module "twinapi.appcore.dll" = true
> (70.07% in signature vs 07.87% overall) Module "dataexchange.dll" = true
> (01.70% in signature vs 60.69% overall) "D2D1.1?" in app_notes = true
> (70.07% in signature vs 08.57% overall) Module "dbgcore.dll" = true
> (63.26% in signature vs 06.93% overall) ipc_channel_error = null
> (71.05% in signature vs 15.78% overall) Module "dcomp.dll" = true
> (99.03% in signature vs 48.12% overall) Module "softokn3.dll" = true
> (99.03% in signature vs 48.17% overall) Module "freebl3.dll" = true
> (74.21% in signature vs 26.03% overall) Module "ondemandconnroutehelper.dll" = true
> (01.70% in signature vs 44.78% overall) "D2D1.1+" in app_notes = true
> (75.43% in signature vs 32.49% overall) Module "winhttp.dll" = true
> (16.79% in signature vs 56.63% overall) jit_category = null
> (99.51% in signature vs 63.51% overall) Module "DWrite.dll" = true
> (66.18% in signature vs 26.80% overall) Module "MSAudDecMFT.dll" = true
> (90.27% in signature vs 53.56% overall) Module "iertutil.dll" = true
> (89.05% in signature vs 52.67% overall) Module "wininet.dll" = true
> (82.24% in signature vs 45.29% overall) Module "msmpeg2vdec.dll" = true
> (99.51% in signature vs 65.51% overall) Module "xmllite.dll" = true
> (98.78% in signature vs 64.77% overall) Module "bcrypt.dll" = true
> (82.73% in signature vs 46.31% overall) Module "mozavcodec.dll" = true
> (82.73% in signature vs 46.34% overall) Module "mozavutil.dll" = true
> (82.73% in signature vs 46.86% overall) Module "evr.dll" = true
> (100.0% in signature vs 67.18% overall) Module "d2d1.dll" = true
> (82.73% in signature vs 46.90% overall) Module "mf.dll" = true
> (82.97% in signature vs 47.59% overall) Module "mfplat.dll" = true
> (40.88% in signature vs 04.58% overall) Module "WindowsCodecs.dll" = true
> (82.73% in signature vs 47.65% overall) Module "dxva2.dll" = true
> (66.91% in signature vs 31.10% overall) Module "RTWorkQ.dll" = true
> (64.23% in signature vs 30.51% overall) ipc_fatal_error_msg = null
> (71.53% in signature vs 38.49% overall) Module "WinTypes.dll" = true
> (58.88% in signature vs 25.73% overall) Module "mfperfhelper.dll" = true
> (99.03% in signature vs 70.44% overall) Module "AudioSes.dll" = true
> (99.27% in signature vs 70.85% overall) Module "MMDevAPI.dll" = true
> (95.13% in signature vs 66.10% overall) startup_crash = 0
> (34.79% in signature vs 03.36% overall) Module "edputil.dll" = true
> (91.73% in signature vs 62.88% overall) Module "winnsi.dll" = true
> (99.27% in signature vs 72.15% overall) Module "psapi.dll" = true
> (80.54% in signature vs 50.62% overall) plugin_version = null
> (81.02% in signature vs 51.39% overall) Module "CRYPTBASE.DLL" = true
> (99.51% in signature vs 73.91% overall) Module "pnrpnsp.dll" = true
> (34.06% in signature vs 05.04% overall) Module "dui70.dll" = true
> (99.51% in signature vs 74.19% overall) Module "NapiNSP.dll" = true
> (99.51% in signature vs 74.19% overall) Module "nlaapi.dll" = true
> (100.0% in signature vs 75.03% overall) "DWrite+" in app_notes = true
> (100.0% in signature vs 75.04% overall) "DWrite?" in app_notes = true
> (89.78% in signature vs 63.17% overall) Module "cryptsp.dll" = true
> (99.76% in signature vs 75.79% overall) Module "winrnr.dll" = true
> (32.36% in signature vs 04.98% overall) Module "duser.dll" = true
> (100.0% in signature vs 77.06% overall) Module "mscms.dll" = true
> (90.27% in signature vs 65.12% overall) Module "dxgi.dll" = true
> (99.76% in signature vs 77.18% overall) Module "dnsapi.dll" = true
> (100.0% in signature vs 77.62% overall) Module "mswsock.dll" = true
> (81.75% in signature vs 56.63% overall) Module "rsaenh.dll" = true
> (82.97% in signature vs 58.02% overall) Module "kernel.appcore.dll" = true
> (83.45% in signature vs 59.07% overall) Module "SHCore.dll" = true
> (83.45% in signature vs 59.11% overall) Module "bcryptPrimitives.dll" = true
> (83.45% in signature vs 59.12% overall) Module "combase.dll" = true
> (68.13% in signature vs 44.23% overall) Module "win32u.dll" = true
> (68.13% in signature vs 44.23% overall) Module "gdi32full.dll" = true
> (71.05% in signature vs 47.59% overall) Module "msvcp_win.dll" = true
> (100.0% in signature vs 80.56% overall) Module "propsys.dll" = true
> (100.0% in signature vs 80.61% overall) Module "firefox.exe" = true
> (100.0% in signature vs 80.74% overall) Module "powrprof.dll" = true
> (72.99% in signature vs 50.20% overall) platform_pretty_version = Windows 10
> (72.26% in signature vs 50.04% overall) Module "windows.storage.dll" = true
> (61.07% in signature vs 39.15% overall) platform_version = 10.0.14393
> (35.77% in signature vs 14.07% overall) Module "apphelp.dll" = true
> (79.08% in signature vs 58.51% overall) Module "WINMMBASE.dll" = true
> (51.82% in signature vs 30.64% overall) Module "wshbth.dll" = true
> (93.43% in signature vs 74.83% overall) cpu_arch = amd64
> (99.76% in signature vs 83.43% overall) Module "nsi.dll" = true
> (06.57% in signature vs 24.52% overall) cpu_arch = x86
> (19.46% in signature vs 00.97% overall) GFX_ERROR "GFX: D3D11 skip BeginFrame with device-removed." = true
> (02.92% in signature vs 19.03% overall) "GL Context+" in app_notes = true
> (02.92% in signature vs 19.03% overall) "GL Context?" in app_notes = true
> (11.44% in signature vs 27.03% overall) app_init_dlls = null
> (21.17% in signature vs 04.84% overall) CPU Info = family 6 model 94 stepping 3
> (33.58% in signature vs 16.70% overall) has dual GPUs = true
> (44.53% in signature vs 28.13% overall) adapter_vendor_id = NVIDIA Corporation
> (15.82% in signature vs 30.95% overall) platform_pretty_version = Windows 7
> (51.82% in signature vs 35.42% overall) contains_memory_report = null
> (72.26% in signature vs 38.43% overall) Module "d3d11.dll" = true ∧ platform_pretty_version = Windows 10
> (60.83% in signature vs 30.14% overall) platform_version = 10.0.14393 ∧ Module "d3d11.dll" = true
> (01.70% in signature vs 18.24% overall) Module "d3d11.dll" = true ∧ platform_pretty_version = Windows 7
> (01.70% in signature vs 17.09% overall) platform_version = 6.1.7601 Service Pack 1 ∧ Module "d3d11.dll" = true
status-firefox50: --- → unaffected
status-firefox51: --- → unaffected
status-firefox52: affected → unaffected
status-firefox53: --- → affected
status-firefox-esr45: --- → unaffected
OS: Windows 7 → Windows
Version: Trunk → 53 Branch
We think this should be fixed by the patch in bug 1319271 (revision 80818c868020). That should be in today's nightly but not yesterday's.
(In reply to Bill McCloskey (:billm) from comment #12)
> We think this should be fixed by the patch in bug 1319271 (revision
> 80818c868020). That should be in today's nightly but not yesterday's.

The early numbers are promising -- there have been two Nightlies today, 20161215030215 and 20161215061212, and there's no sign of this crash so far in either of them. But we need another 24 hours of data to say for sure.
Flags: needinfo?(dvander)
There are so many other problems with PLayer that I'm just going to remove it in bug 1323539. If for some reason we end up uplifting the original patch to bug 1319271 then we can uplift the minimal fix in this bug as well.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.