Closed Bug 1316652 Opened 3 years ago Closed 3 years ago

7,000 instances of "NS_ENSURE_TRUE(layerManager) failed" emitted from dom/media/MediaDecoder.cpp during linux64 debug testing

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: erahm, Assigned: mattwoodrow)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

> 6101 WARNING: NS_ENSURE_TRUE(layerManager) failed: file dom/media/MediaDecoder.cpp, line 301

This warning [1] shows up in the following test suites:

>   1448 - desktop-test-linux64/debug-reftest-6 R6
>   1448 - desktop-test-linux64/debug-reftest-no-accel-6 Ru6
>   1044 - desktop-test-linux64/debug-web-platform-tests-reftests-e10s Wr
>   1028 - desktop-test-linux64/debug-web-platform-tests-reftests Wr
>    178 - desktop-test-linux64/debug-web-platform-tests-10 10
>    142 - desktop-test-linux64/debug-web-platform-tests-e10s-10 10
>     62 - desktop-test-linux64/debug-mochitest-webgl-3 gl3
>     62 - desktop-test-linux64/debug-mochitest-webgl-e10s-3 gl3
>     54 - desktop-test-linux64/debug-mochitest-browser-chrome-4 bc4
>     52 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
>     50 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
>     50 - desktop-test-linux64/debug-mochitest-browser-chrome-3 bc3
>     38 - desktop-test-linux64/debug-mochitest-browser-chrome-7 bc7
>     28 - desktop-test-linux64/debug-mochitest-webgl-e10s-1 gl1
>     28 - desktop-test-linux64/debug-mochitest-webgl-1 gl1
>     26 - desktop-test-linux64/debug-crashtest C
>     24 - desktop-test-linux64/debug-crashtest-e10s C
>     23 - desktop-test-linux64/debug-web-platform-tests-1 1
>     23 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
>     20 - desktop-test-linux64/debug-mochitest-media mda
>     19 - desktop-test-linux64/debug-mochitest-media-e10s mda
>     18 - desktop-test-linux64/debug-web-platform-tests-e10s-1 1
>     17 - desktop-test-linux64/debug-web-platform-tests-8 8
>     14 - desktop-test-linux64/debug-web-platform-tests-e10s-8 8
>     14 - desktop-test-linux64/debug-mochitest-e10s-10 10
>     13 - desktop-test-linux64/debug-mochitest-10 10
>     12 - desktop-test-linux64/debug-mochitest-2 2
>     10 - desktop-test-linux64/debug-reftest-no-accel-e10s-8 Ru8
>     10 - desktop-test-linux64/debug-reftest-8 R8
>     10 - desktop-test-linux64/debug-reftest-no-accel-8 Ru8
>     10 - desktop-test-linux64/debug-reftest-no-accel-e10s-6 Ru6
>     10 - desktop-test-linux64/debug-reftest-e10s-6 R6
>     10 - desktop-test-linux64/debug-reftest-e10s-8 R8
>      8 - desktop-test-linux64/debug-web-platform-tests-e10s-6 6
>      8 - desktop-test-linux64/debug-web-platform-tests-6 6
>      7 - desktop-test-linux64/debug-web-platform-tests-5 5
>      6 - desktop-test-linux64/debug-web-platform-tests-e10s-5 5
>      6 - desktop-test-linux64/debug-web-platform-tests-4 4
>      5 - desktop-test-linux64/debug-reftest-no-accel-5 Ru5
>      5 - desktop-test-linux64/debug-reftest-no-accel-e10s-5 Ru5
>      5 - desktop-test-linux64/debug-reftest-e10s-5 R5
>      5 - desktop-test-linux64/debug-web-platform-tests-12 12
>      5 - desktop-test-linux64/debug-reftest-5 R5
>      5 - desktop-test-linux64/debug-web-platform-tests-3 3
>      4 - desktop-test-linux64/debug-mochitest-chrome-1 c1
>      4 - desktop-test-linux64/debug-web-platform-tests-9 9
>      4 - desktop-test-linux64/debug-web-platform-tests-e10s-12 12
>      4 - desktop-test-linux64/debug-web-platform-tests-e10s-9 9
>      4 - desktop-test-linux64/debug-web-platform-tests-e10s-4 4
>      4 - desktop-test-linux64/debug-web-platform-tests-e10s-3 3
>      4 - desktop-test-linux64/debug-mochitest-e10s-2 2
>      3 - desktop-test-linux64/debug-firefox-ui-functional-local en-US
>      3 - desktop-test-linux64/debug-firefox-ui-functional-local-e10s en-US
>      3 - desktop-test-linux64/debug-web-platform-tests-11 11
>      2 - desktop-test-linux64/debug-web-platform-tests-e10s-11 11
>      2 - desktop-test-linux64/debug-mochitest-chrome-3 c3

It shows up in 756 tests. A few of the most prevalent:

>    454 -        view-source:file:///home/worker/workspace/build/tests/reftest/tests/parser/htmlparser/tests/reftest/bug482921-2.xhtml == file:///home/worker/workspace/build/tests/reftest/tests/parser/htmlparser/tests/reftest/bug482921-2-ref.html
>    452 -        file:///home/worker/workspace/build/tests/reftest/tests/parser/htmlparser/tests/reftest/bug659763-3.html == file:///home/worker/workspace/build/tests/reftest/tests/parser/htmlparser/tests/reftest/bug659763-3-ref.html
>    156 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-none-webm-001.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-none-webm-001-ref.html
>    154 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-fill-webm-002.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-fill-webm-002-ref.html
>    126 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-none-webm-002.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-none-webm-002-ref.html
>    126 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-contain-webm-002.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-contain-webm-002-ref.html
>    126 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-fill-webm-001.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-fill-webm-001-ref.html
>    126 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-cover-webm-001.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-cover-webm-001-ref.html
>    126 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-scale-down-webm-002.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-scale-down-webm-002-ref.html
>    126 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-scale-down-webm-001.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-scale-down-webm-001-ref.html

[1] https://hg.mozilla.org/mozilla-central/annotate/02876b8cf2b0/dom/media/MediaDecoder.cpp#l301
Component: Audio/Video → Audio/Video: Playback
This is currently the #1 most verbose warning. Bisection points to https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=01800003ec3b043995e4ec1daaaf827e7ee2bbee&tochange=3e74d390dea4d3311b2eea00be094331dfe3f64f

Matt I get the feeling it's one of your bugs in that range.
Flags: needinfo?(matt.woodrow)
This continues to be a top warning and has become more verbose.
Summary: 6,100 instances of "NS_ENSURE_TRUE(layerManager) failed" emitted from dom/media/MediaDecoder.cpp during linux64 debug testing → 7,000 instances of "NS_ENSURE_TRUE(layerManager) failed" emitted from dom/media/MediaDecoder.cpp during linux64 debug testing
This continues to be a top warning and has become more verbose.
Attached patch check-lm-quietlySplinter Review
Assignee: nobody → matt.woodrow
Flags: needinfo?(matt.woodrow)
Attachment #8825239 - Flags: review?(jyavenard)
Attachment #8825239 - Flags: review?(jyavenard) → review+
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5afe688be64c
Silence unnecessary warning in MediaDecoder. r=jya
https://hg.mozilla.org/mozilla-central/rev/5afe688be64c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.