1316687 - Make use of the default value for "app.update.url" because "app.update.url.override" was removed

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Bug 1315506 will get rid of this preference, so we have to get rid of this option in our firefox-ui update harness. Instead we have to set the default value of "app.update.url".

I will work on this once bug 1315506 has been fixed.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1316687 - Make use of the default value for "app.update.url" because "app.update.url.override" was removed.

Review commit: https://reviewboard.mozilla.org/r/93282/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93282/

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8811044 [details]
Bug 1316687 - Make use of the default value for "app.update.url" because "app.update.url.override" was removed.

https://reviewboard.mozilla.org/r/93282/#review93538

One question. Everything else look OK.

::: testing/firefox-ui/harness/firefox_ui_harness/runners/update.py
(Diff revision 1)
>  
>          self.original_bin = self.bin
>  
>          self.prefs.update(DEFAULT_PREFS)
>  
> -        # In case of overriding the update URL, set the appropriate preference

Don't you want to set app.update.url here, too? (Right now it's set at restart. Is that enough? Does a restart always happen before the tests start?)

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8811044 [details]
Bug 1316687 - Make use of the default value for "app.update.url" because "app.update.url.override" was removed.

https://reviewboard.mozilla.org/r/93282/#review93538

> Don't you want to set app.update.url here, too? (Right now it's set at restart. Is that enough? Does a restart always happen before the tests start?)

Good question Maja! So we cannot set the url inside the runner, because the first start of Firefox would reset the value. If we want to set the default at the beginning of the test, it would have to be done in setUp() for the update testcase class.

Right now we always restart Firefox before checking for updates. So the above change would not be necessary. But I would like to get rid of this extra restart soon to get the app.update.log working on Windows. As such it will be good to get this code also added in setUp.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8811044 [details]
Bug 1316687 - Make use of the default value for "app.update.url" because "app.update.url.override" was removed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93282/diff/1-2/

Comment 5

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8811044 [details]
Bug 1316687 - Make use of the default value for "app.update.url" because "app.update.url.override" was removed.

https://reviewboard.mozilla.org/r/93282/#review93978

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/852fa3bf50d7
Make use of the default value for "app.update.url" because "app.update.url.override" was removed. r=maja_zf

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/852fa3bf50d7

Comment 8

[areya]

https://hg.mozilla.org/mozilla-central/rev/852fa3bf50d7