1316886 - Port sdp_file_parser unit test to standalone binary

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Dan Minor [:dminor]]

As it stands, we don't run this test in automation anyway.

It appears the intention is to be able to run it as a standalone executable, point it to a binary file containing sdp and manually verify the output.

If we want to run it in automation, we should come up with a standard input and an expected output. Otherwise, we should see if we can build it as a standalone executable, or just remove it.

Comment 1

[Dan Minor [:dminor]]

Byron, what do you think we should do with this one? Thanks!

Comment 2

[Byron Campen [:bwc]]

I _think_ this doesn't use any XPCOM in any meaningful way, so we should be able to build it standalone. We could also build it as a gecko gtest but make its only test-case disabled.

Comment 3

[Nils Ohlmeier [:drno]]

Dan I created this binary for the purpose of fuzz testing our SDP parser (which is at least 10 times faster via this binary then going all the way through Firefox). And I would like to keep it around for that purpose (assuming the effort to keep it around is not too high).

And yes Byron is right this should be converted into a standalone binary. I don't think it makes sense to keep this around if get converted into a gecko gtest.

Comment 4

[Eric Rahm [:erahm]]

There's a prototype of xul-gtestifying this in bug 1257713. It proposes adding an env var, SDP_FILE_PARSER_FILE, rather than passing the file in via command-line.

Building standalone is probably not an option. I'll attach the colossal linking failure.

Comment 5

[Eric Rahm [:erahm]]

Attachment: Link failure when trying to build as a CppUnitTest

Comment 6

[Dan Minor [:dminor]]

Attachment: Bug 1316886 - Port sdp_file_parser unit test to standalone binary;

Review commit: https://reviewboard.mozilla.org/r/92470/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92470/

Comment 7

[Dan Minor [:dminor]]

Try run here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=84bcb3822d417f37927f543aad32ee723c75c795

Comment 8

[Nils Ohlmeier [:drno]]

Comment on attachment 8810003 [details]
Bug 1316886 - Port sdp_file_parser unit test to standalone binary;

https://reviewboard.mozilla.org/r/92470/#review92538

LGTM. Thanks for solving it properly!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09b5ba29c6db
Port sdp_file_parser unit test to standalone binary; r=drno

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/09b5ba29c6db