1316957 - Include windows.configure conditionally instead of using depends_win

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1316957 - Include windows.configure conditionally instead of using @depends_win.

Review commit: https://reviewboard.mozilla.org/r/92408/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92408/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8809938 [details]
Bug 1316957 - Include windows.configure conditionally instead of using @depends_win.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92408/diff/1-2/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8809938 [details]
Bug 1316957 - Include windows.configure conditionally instead of using @depends_win.

https://reviewboard.mozilla.org/r/92408/#review92514

::: build/moz.configure/windows.configure:93
(Diff revision 2)
>  def valid_windows_sdk_dir_result(value):
>      if value:
>          return '0x%04x in %s' % (value.version, quote(value.path))
>  
> -@depends_win(c_compiler, windows_sdk_dir, valid_windows_version,
> +@depends(c_compiler, windows_sdk_dir, valid_windows_version,
>               'WINDOWSSDKDIR')

This indendation is off now.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8809938 [details]
Bug 1316957 - Include windows.configure conditionally instead of using @depends_win.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92408/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b174353e76a
Include windows.configure conditionally instead of using @depends_win. r=chmanchester

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Glandium asked for this to be backed out, so https://hg.mozilla.org/integration/autoland/rev/b45288800745

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8809938 [details]
Bug 1316957 - Include windows.configure conditionally instead of using @depends_win.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92408/diff/3-4/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d63d083ab767
Include windows.configure conditionally instead of using @depends_win. r=chmanchester

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d63d083ab767

Comment 10

[Mike Hommey [:glandium]]

Backed out on aurora. See bug 1322025.
https://hg.mozilla.org/releases/mozilla-aurora/rev/cceb7f61ef17d0c10d42f4e4a9820d40cc46528d