Closed Bug 1316957 Opened 3 years ago Closed 3 years ago

Include windows.configure conditionally instead of using depends_win

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: glandium, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8809938 [details]
Bug 1316957 - Include windows.configure conditionally instead of using @depends_win.

https://reviewboard.mozilla.org/r/92408/#review92514

::: build/moz.configure/windows.configure:93
(Diff revision 2)
>  def valid_windows_sdk_dir_result(value):
>      if value:
>          return '0x%04x in %s' % (value.version, quote(value.path))
>  
> -@depends_win(c_compiler, windows_sdk_dir, valid_windows_version,
> +@depends(c_compiler, windows_sdk_dir, valid_windows_version,
>               'WINDOWSSDKDIR')

This indendation is off now.
Attachment #8809938 - Flags: review?(cmanchester) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/2b174353e76a
Include windows.configure conditionally instead of using @depends_win. r=chmanchester
Glandium asked for this to be backed out, so https://hg.mozilla.org/integration/autoland/rev/b45288800745
Flags: needinfo?(mh+mozilla)
Depends on: 1317504
Flags: needinfo?(mh+mozilla)
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/d63d083ab767
Include windows.configure conditionally instead of using @depends_win. r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/d63d083ab767
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Depends on: 1322025
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.